From: kernel test robot <lkp@intel.com>
To: Johan Jonker <jbx6244@gmail.com>
Cc: oe-kbuild-all@lists.linux.dev,
Linux Memory Management List <linux-mm@kvack.org>,
Heiko Stuebner <heiko@sntech.de>
Subject: [linux-next:master 1690/4884] drivers/gpu/drm/rockchip/rk3066_hdmi.c:397:22: error: implicit declaration of function 'drm_atomic_get_new_connector_state'; did you mean 'drm_atomic_helper_connector_reset'?
Date: Wed, 6 Dec 2023 04:19:17 +0800 [thread overview]
Message-ID: <202312060423.LEZ1ttyo-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 0f5f12ac05f36f117e793656c3f560625e927f1b
commit: ae3436a5e7c2ef4f92938133bd99f92fc47ea34e [1690/4884] drm/rockchip: rk3066_hdmi: Switch encoder hooks to atomic
config: x86_64-buildonly-randconfig-006-20231203 (https://download.01.org/0day-ci/archive/20231206/202312060423.LEZ1ttyo-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231206/202312060423.LEZ1ttyo-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312060423.LEZ1ttyo-lkp@intel.com/
Note: the linux-next/master HEAD 0f5f12ac05f36f117e793656c3f560625e927f1b builds fine.
It may have been fixed somewhere.
All errors (new ones prefixed by >>):
drivers/gpu/drm/rockchip/rk3066_hdmi.c: In function 'rk3066_hdmi_encoder_enable':
>> drivers/gpu/drm/rockchip/rk3066_hdmi.c:397:22: error: implicit declaration of function 'drm_atomic_get_new_connector_state'; did you mean 'drm_atomic_helper_connector_reset'? [-Werror=implicit-function-declaration]
397 | conn_state = drm_atomic_get_new_connector_state(state, &hdmi->connector);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| drm_atomic_helper_connector_reset
drivers/gpu/drm/rockchip/rk3066_hdmi.c:397:20: warning: assignment to 'struct drm_connector_state *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
397 | conn_state = drm_atomic_get_new_connector_state(state, &hdmi->connector);
| ^
>> drivers/gpu/drm/rockchip/rk3066_hdmi.c:401:22: error: implicit declaration of function 'drm_atomic_get_new_crtc_state'; did you mean 'drm_atomic_helper_swap_state'? [-Werror=implicit-function-declaration]
401 | crtc_state = drm_atomic_get_new_crtc_state(state, conn_state->crtc);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| drm_atomic_helper_swap_state
drivers/gpu/drm/rockchip/rk3066_hdmi.c:401:20: warning: assignment to 'struct drm_crtc_state *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
401 | crtc_state = drm_atomic_get_new_crtc_state(state, conn_state->crtc);
| ^
cc1: some warnings being treated as errors
vim +397 drivers/gpu/drm/rockchip/rk3066_hdmi.c
388
389 static void rk3066_hdmi_encoder_enable(struct drm_encoder *encoder,
390 struct drm_atomic_state *state)
391 {
392 struct rk3066_hdmi *hdmi = encoder_to_rk3066_hdmi(encoder);
393 struct drm_connector_state *conn_state;
394 struct drm_crtc_state *crtc_state;
395 int mux, val;
396
> 397 conn_state = drm_atomic_get_new_connector_state(state, &hdmi->connector);
398 if (WARN_ON(!conn_state))
399 return;
400
> 401 crtc_state = drm_atomic_get_new_crtc_state(state, conn_state->crtc);
402 if (WARN_ON(!crtc_state))
403 return;
404
405 mux = drm_of_encoder_active_endpoint_id(hdmi->dev->of_node, encoder);
406 if (mux)
407 val = (HDMI_VIDEO_SEL << 16) | HDMI_VIDEO_SEL;
408 else
409 val = HDMI_VIDEO_SEL << 16;
410
411 regmap_write(hdmi->grf_regmap, GRF_SOC_CON0, val);
412
413 DRM_DEV_DEBUG(hdmi->dev, "hdmi encoder enable select: vop%s\n",
414 (mux) ? "1" : "0");
415
416 rk3066_hdmi_setup(hdmi, &crtc_state->adjusted_mode);
417 }
418
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2023-12-05 20:19 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202312060423.LEZ1ttyo-lkp@intel.com \
--to=lkp@intel.com \
--cc=heiko@sntech.de \
--cc=jbx6244@gmail.com \
--cc=linux-mm@kvack.org \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.