From: Christoph Hellwig <hch@lst.de>
To: Guixin Liu <kanie@linux.alibaba.com>
Cc: kbusch@kernel.org, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH 1/2] nvme: introduce nvme_check_ctrl_fabric_info helper
Date: Wed, 6 Dec 2023 06:39:03 +0100 [thread overview]
Message-ID: <20231206053903.GA18935@lst.de> (raw)
In-Reply-To: <1701761860-17623-1-git-send-email-kanie@linux.alibaba.com>
> +static int nvme_check_ctrl_fabric_info(struct nvme_ctrl *ctrl, struct nvme_id_ctrl *id)
Overly long line.
I'd also rename this to something like nvmf_validate_identify_ctrl.
Otherwise this looks good.
next prev parent reply other threads:[~2023-12-06 5:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 7:37 [PATCH 1/2] nvme: introduce nvme_check_ctrl_fabric_info helper Guixin Liu
2023-12-05 7:37 ` [PATCH 2/2] nvme-fabrics: check ioccsz and iorcsz Guixin Liu
2023-12-05 10:02 ` Sagi Grimberg
2023-12-06 5:39 ` Christoph Hellwig
2023-12-05 10:02 ` [PATCH 1/2] nvme: introduce nvme_check_ctrl_fabric_info helper Sagi Grimberg
2023-12-06 5:39 ` Christoph Hellwig [this message]
2023-12-06 23:22 ` Keith Busch
2023-12-06 23:26 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231206053903.GA18935@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=kanie@linux.alibaba.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.