From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Thomas Haller <thaller@redhat.com>,
Florian Westphal <fw@strlen.de>,
netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft] tests: shell: flush ruleset with -U after feature probing
Date: Wed, 6 Dec 2023 13:18:28 +0100 [thread overview]
Message-ID: <20231206121828.GI8352@breakpoint.cc> (raw)
In-Reply-To: <ZXBlvcV3jUfJCnMs@calendula>
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > The mode without unshare exists for historic reasons, as unshare was
> > added initially. At this point, what is the use of supporting or using
> > that?
>
> This provides an easy way for me to test 'nft monitor'.
>
> I can keep it out of tree if you prefer -U remains broken.
No no no, I was just asking if '-U' should still run the
feature probes without a netns, which is what its doing right
now.
Perhaps -U should just disable the unshare for the actual shell
tests, not for the feature probe scripts.
next prev parent reply other threads:[~2023-12-06 12:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 15:43 [PATCH nft] tests: shell: flush ruleset with -U after feature probing Pablo Neira Ayuso
2023-12-05 19:29 ` Florian Westphal
2023-12-06 6:47 ` Thomas Haller
2023-12-06 12:14 ` Pablo Neira Ayuso
2023-12-06 12:18 ` Florian Westphal [this message]
2023-12-06 12:33 ` Pablo Neira Ayuso
2023-12-06 12:49 ` Pablo Neira Ayuso
2023-12-06 12:52 ` Florian Westphal
2023-12-06 13:12 ` Thomas Haller
2023-12-06 12:45 ` Thomas Haller
2023-12-06 12:57 ` Pablo Neira Ayuso
2023-12-06 12:29 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231206121828.GI8352@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=thaller@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.