From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f47.google.com (mail-ot1-f47.google.com [209.85.210.47]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62D85B5; Wed, 6 Dec 2023 06:56:47 -0800 (PST) Received: by mail-ot1-f47.google.com with SMTP id 46e09a7af769-6d9a1dd6fdcso467569a34.1; Wed, 06 Dec 2023 06:56:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701874606; x=1702479406; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dMFxTkt+APt9VkSo60/Rj4cKZLAsbnVIJIMVqJP/nRI=; b=qri2uqUTwj/abp8PAD7G7hQ0iisfXb3C5gHRiuoDGEnnPptrvDXqEPF2nxvtjqmz2l jOXHFzOy5knLtxAni5Oxwvmih9OPw9J/DT8VZ8IJT5TvnSt9YU+ywswBiwJshvJv3VNv 2o9NTKPHsGBnyy/08nlwd2o9huJOKUxqABwL1cKIOx+7BOwrrPJmw5K6WrUMopgByQn8 HAH2BMPZEMcSeGNfxirR665CJ6saeZ82FrVOl3pZLDotSkGPLjTX7jy1xRZHMTOkrNBX e0qGUFbd2r3z8p7MpXtWEK16iG3BS55aY4tawa1ToPXFxTa1qdGQtY//gBGnZPdl/6s0 o72A== X-Gm-Message-State: AOJu0YzOqKF5MeQUZXnoSj3fsQul1YcnBfqzRYZBYZe1JPT5KwtSkCq4 W1kYE4P9XYZBmhycqcljQBbPlCbs0g== X-Google-Smtp-Source: AGHT+IGo7Nw4yr8MZn9UYM3es1DB4fV7+KFr86PkrLstPfPuNnxjgC+QKtK0LxxDfWXey61y9+S+nQ== X-Received: by 2002:a05:6830:c89:b0:6d8:74f0:30d3 with SMTP id bn9-20020a0568300c8900b006d874f030d3mr1429643otb.29.1701874606223; Wed, 06 Dec 2023 06:56:46 -0800 (PST) Received: from herring.priv (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id m2-20020a9d4c82000000b006d879b8e68csm1880241otf.69.2023.12.06.06.56.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Dec 2023 06:56:45 -0800 (PST) Received: (nullmailer pid 2138604 invoked by uid 1000); Wed, 06 Dec 2023 14:56:44 -0000 Date: Wed, 6 Dec 2023 08:56:44 -0600 From: Rob Herring To: Alain Volmat Cc: Andi Shyti , Krzysztof Kozlowski , Conor Dooley , Maxime Coquelin , Alexandre Torgue , Pierre-Yves MORDRET , linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/7] dt-bindings: i2c: document st,stm32mp25-i2c compatible Message-ID: <20231206145644.GA2133904-robh@kernel.org> References: <20231129125920.1702497-1-alain.volmat@foss.st.com> <20231129125920.1702497-4-alain.volmat@foss.st.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231129125920.1702497-4-alain.volmat@foss.st.com> On Wed, Nov 29, 2023 at 01:59:12PM +0100, Alain Volmat wrote: > Add a new compatible st,stm32mp25-i2c for the STM32MP25 series which > has only one interrupt line for both events and errors and differs in > term of handling of FastModePlus. > > Signed-off-by: Alain Volmat > --- > .../devicetree/bindings/i2c/st,stm32-i2c.yaml | 49 +++++++++++++++---- > 1 file changed, 39 insertions(+), 10 deletions(-) > > diff --git a/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml b/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml > index 94b75d9f66cd..6a69bb6de23e 100644 > --- a/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml > +++ b/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml > @@ -19,6 +19,7 @@ allOf: > - st,stm32f7-i2c > - st,stm32mp13-i2c > - st,stm32mp15-i2c > + - st,stm32mp25-i2c > then: > properties: > i2c-scl-rising-time-ns: > @@ -41,6 +42,43 @@ allOf: > clock-frequency: > enum: [100000, 400000] > > + - if: > + properties: > + compatible: > + contains: > + enum: > + - st,stm32f4-i2c > + - st,stm32f7-i2c > + - st,stm32mp13-i2c > + - st,stm32mp15-i2c > + then: > + properties: > + interrupts: > + items: > + - description: interrupt ID for I2C event > + - description: interrupt ID for I2C error > + > + interrupt-names: > + items: > + - const: event > + - const: error > + > + - if: > + properties: > + compatible: > + contains: > + enum: > + - st,stm32mp25-i2c > + then: > + properties: > + interrupts: > + items: > + - description: common interrupt for events and errors > + > + interrupt-names: > + items: > + - const: event > + > properties: > compatible: > enum: > @@ -48,20 +86,11 @@ properties: > - st,stm32f7-i2c > - st,stm32mp13-i2c > - st,stm32mp15-i2c > + - st,stm32mp25-i2c > > reg: > maxItems: 1 > > - interrupts: > - items: > - - description: interrupt ID for I2C event > - - description: interrupt ID for I2C error > - > - interrupt-names: > - items: > - - const: event > - - const: error No this should remain. You are duplicating defining the names otherwise. Add 'minItems: 1' here. Then the if/then schemas should just have 'maxItems: 1' or 'minItems: 2'. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0924FC4167B for ; Wed, 6 Dec 2023 14:57:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iEXYgMKxvac8NURhFyCM57r7Et9XhuFZsq+XRuElLNU=; b=PQu6oKxeiXMnWL d355/XrjV3m5NzllSgqVlQicFLOxIM8KGih6jPMCtUkEwDgCp4tyu0g8s8tmmd0nh3f7Lucshlm5Q Ay0+opaUPZLAhHBPMuNpAXevbbMMyHCZzIS0PdfDWlMvDJX1o5UwAt0QIz5n7fPqUV//Eay8ugsfk ON9tBxWluDgDZj1qMev7a/a14VojV9Nasl0INaN45OpHmE7tZl/i8bVoYx1QGHptahcY2TJtNaaMC wm5KEwA2nXCVHaWxVJ9NIT4vC48pXUUc8SImPZFJd2w8IkzV1IwbfNIpqXnz9B7d0BuRX6V+LNQzU GYDsxUyXwnuD3aUJ92LQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rAtKV-00AZPA-2F; Wed, 06 Dec 2023 14:56:51 +0000 Received: from mail-ot1-f50.google.com ([209.85.210.50]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rAtKS-00AZOT-1N for linux-arm-kernel@lists.infradead.org; Wed, 06 Dec 2023 14:56:50 +0000 Received: by mail-ot1-f50.google.com with SMTP id 46e09a7af769-6d9d29a2332so88385a34.0 for ; Wed, 06 Dec 2023 06:56:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701874606; x=1702479406; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dMFxTkt+APt9VkSo60/Rj4cKZLAsbnVIJIMVqJP/nRI=; b=VprigP+3G2SgRZFrqGv4kI7We1PtHqRIQc3qx6CxCwTTLEoOUuKeS5NvnHtiCEDWRz jGYWGM5lY7lQFxv+Br7sb0EDoybCXi2MTTG+N7oPixbAWJVBTukwT+dDJA/wv+2Ld/eg EqsznUJRloXiR1wdgu3HyLgdXwmeaa8nVa6NojQvCtbJarQJ+VtLqK1UdrCU94wKh0FB t9sPgd1g9i2SaiLS/EqCrl4Cyh+1xbTejPmZOsc7GjTOGTRfol1dGtwlZksWZ8u6vun4 pXyDYmPOrUbmt89bhnWf46unix60PLFCSSGWpiyXQ0T1gdeTdznmmt5n5BKeZ2Jj3wvy u7Ag== X-Gm-Message-State: AOJu0YwlJQOZxrIa9x+h4ZBsYQQZ2vbaNf4fi/BifJ0YoPIKRUWERxYA Yk5a7GHByF8bPevRxPvdPQ== X-Google-Smtp-Source: AGHT+IGo7Nw4yr8MZn9UYM3es1DB4fV7+KFr86PkrLstPfPuNnxjgC+QKtK0LxxDfWXey61y9+S+nQ== X-Received: by 2002:a05:6830:c89:b0:6d8:74f0:30d3 with SMTP id bn9-20020a0568300c8900b006d874f030d3mr1429643otb.29.1701874606223; Wed, 06 Dec 2023 06:56:46 -0800 (PST) Received: from herring.priv (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id m2-20020a9d4c82000000b006d879b8e68csm1880241otf.69.2023.12.06.06.56.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Dec 2023 06:56:45 -0800 (PST) Received: (nullmailer pid 2138604 invoked by uid 1000); Wed, 06 Dec 2023 14:56:44 -0000 Date: Wed, 6 Dec 2023 08:56:44 -0600 From: Rob Herring To: Alain Volmat Cc: Andi Shyti , Krzysztof Kozlowski , Conor Dooley , Maxime Coquelin , Alexandre Torgue , Pierre-Yves MORDRET , linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/7] dt-bindings: i2c: document st,stm32mp25-i2c compatible Message-ID: <20231206145644.GA2133904-robh@kernel.org> References: <20231129125920.1702497-1-alain.volmat@foss.st.com> <20231129125920.1702497-4-alain.volmat@foss.st.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231129125920.1702497-4-alain.volmat@foss.st.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231206_065648_477172_14BD72C8 X-CRM114-Status: GOOD ( 17.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 29, 2023 at 01:59:12PM +0100, Alain Volmat wrote: > Add a new compatible st,stm32mp25-i2c for the STM32MP25 series which > has only one interrupt line for both events and errors and differs in > term of handling of FastModePlus. > > Signed-off-by: Alain Volmat > --- > .../devicetree/bindings/i2c/st,stm32-i2c.yaml | 49 +++++++++++++++---- > 1 file changed, 39 insertions(+), 10 deletions(-) > > diff --git a/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml b/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml > index 94b75d9f66cd..6a69bb6de23e 100644 > --- a/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml > +++ b/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml > @@ -19,6 +19,7 @@ allOf: > - st,stm32f7-i2c > - st,stm32mp13-i2c > - st,stm32mp15-i2c > + - st,stm32mp25-i2c > then: > properties: > i2c-scl-rising-time-ns: > @@ -41,6 +42,43 @@ allOf: > clock-frequency: > enum: [100000, 400000] > > + - if: > + properties: > + compatible: > + contains: > + enum: > + - st,stm32f4-i2c > + - st,stm32f7-i2c > + - st,stm32mp13-i2c > + - st,stm32mp15-i2c > + then: > + properties: > + interrupts: > + items: > + - description: interrupt ID for I2C event > + - description: interrupt ID for I2C error > + > + interrupt-names: > + items: > + - const: event > + - const: error > + > + - if: > + properties: > + compatible: > + contains: > + enum: > + - st,stm32mp25-i2c > + then: > + properties: > + interrupts: > + items: > + - description: common interrupt for events and errors > + > + interrupt-names: > + items: > + - const: event > + > properties: > compatible: > enum: > @@ -48,20 +86,11 @@ properties: > - st,stm32f7-i2c > - st,stm32mp13-i2c > - st,stm32mp15-i2c > + - st,stm32mp25-i2c > > reg: > maxItems: 1 > > - interrupts: > - items: > - - description: interrupt ID for I2C event > - - description: interrupt ID for I2C error > - > - interrupt-names: > - items: > - - const: event > - - const: error No this should remain. You are duplicating defining the names otherwise. Add 'minItems: 1' here. Then the if/then schemas should just have 'maxItems: 1' or 'minItems: 2'. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel