From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E2583D98C; Wed, 6 Dec 2023 15:32:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="rGASEMZu" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3B75DC433C7; Wed, 6 Dec 2023 15:32:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701876772; bh=w1otnxj6ZQubR19XyLc2pJyxuUrOYv5s6Wn1rb3d1zM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rGASEMZu2w8Un5785u0aGDVqoWrEGsXz1MReexBAxddidRe4ZZe5zAr1Sm0k93D+u Ui2+j1KIQLPLlEMwubHnwKWoqH9i2LMROw+PNo+os8rAPeQ4hST37N62nDpHBIkPO4 uHH8Emz7IPGW/hZ6oLAl6gSzocpcZnFhp6YtRXrD5oszVH52J7j9aOgXwG0nWmcR3T k6K524JwL7SyQMLDxr20AN1PKLPXkVriRV40ck2DScbYe+1PPJuMSCQUvXO70HkFBw uGJnKtfwIFtCkPIEyrUnhg4Hi3AGxm9XoGnIVmFItvXFPxt/PpS5LdtUW6oEHHL6xL hEgUg9hmtXlZg== Date: Wed, 6 Dec 2023 21:02:42 +0530 From: Manivannan Sadhasivam To: Naresh Maramaina Cc: Bart Van Assche , "James E.J. Bottomley" , "Martin K. Petersen" , Peter Wang , Andy Gross , Bjorn Andersson , Konrad Dybcio , Matthias Brugger , AngeloGioacchino Del Regno , chu.stanley@gmail.com, Alim Akhtar , Avri Altman , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, quic_cang@quicinc.com, quic_nguyenb@quicinc.com, Nitin Rawat Subject: Re: [PATCH V2 1/3] ufs: core: Add CPU latency QoS support for ufs driver Message-ID: <20231206153242.GI12802@thinkpad> References: <20231204143101.64163-1-quic_mnaresh@quicinc.com> <20231204143101.64163-2-quic_mnaresh@quicinc.com> <590ade27-b4da-49be-933b-e9959aa0cd4c@acm.org> <692cd503-5b14-4be6-831d-d8e9c282a95e@quicinc.com> <5e7c5c75-cb5f-4afe-9d57-b0cab01a6f26@acm.org> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed, Dec 06, 2023 at 07:32:54PM +0530, Naresh Maramaina wrote: > > > On 12/5/2023 10:41 PM, Bart Van Assche wrote: > > On 12/4/23 21:58, Naresh Maramaina wrote: > > > On 12/5/2023 12:30 AM, Bart Van Assche wrote: > > > > On 12/4/23 06:30, Maramaina Naresh wrote: > > > > > +    /* This capability allows the host controller driver to > > > > > use the PM QoS > > > > > +     * feature. > > > > > +     */ > > > > > +    UFSHCD_CAP_PM_QOS                = 1 << 13, > > > > >   }; > > > > > > > > Why does it depend on the host driver whether or not PM QoS is > > > > enabled? Why isn't it enabled unconditionally? > > > > > > For some platform vendors power KPI might be more important than > > > random io KPI. Hence this flag is disabled by default and can be > > > enabled based on platform requirement. > > > > How about leaving this flag out unless if a host vendor asks explicitly > > for this flag? > > IMHO, instead of completely removing this flag, how about having > flag like "UFSHCD_CAP_DISABLE_PM_QOS" which will make PMQOS enable > by default and if some host vendor wants to disable it explicitly, > they can enable that flag. > Please let me know your opinion. > If a vendor wants to disable this feature, then the driver has to be modified. That won't be very convenient. So either this has to be configured through sysfs or Kconfig if flexibility matters. - Mani > > > > > > > > > + * @pm_qos_req: PM QoS request handle > > > > > + * @pm_qos_init: flag to check if pm qos init completed > > > > >    */ > > > > > > > > Documentation for pm_qos_init is missing. > > > > > > > Sorry, i didn't get your comment, i have already added documentation > > > for @pm_qos_init, @pm_qos_req variable as above. Do you want me to > > > add this information some where else as well? > > > > Oops, I meant 'qos_vote'. > > Sure. I'll take of this in next patchset. > > > > > Thanks, > > > > Bart. > > > > Thanks, > Naresh > -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 02F32C4167B for ; Wed, 6 Dec 2023 15:33:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6+G3D0uLT+AQMlHEJunWWa+8SpMicy7FC0L6jsCwjsQ=; b=wh3E4ZvSu7bGku BqngrzVfPcKtXGMRKbcNnmtMbtLPvBS7GXq0ypdywS0d+MYWyQ9d2x88jjdwZ2VAedW7rVOcKDYAW gqPZQfZKfIrdUQWB/nA8tUeyytjZm6kpM2212WmHwXQVOzxMFor3roDBzAFHRFC1htE25TH0mjTgJ p7FAy2kdo++u6IHtIEEELK6GgwjMD+Vrwh1/4duPg7bYL+6xsPLryPylYwKA5mQns4bc0IJAC6dpd yPdzbydnBwD0pZxWDNGD9mmN68Ci+SnRPmuru/2UW8Up25TAKXHLXRqKHE6qj1ISQ1F12wVEhcCBv gG4zsP2Z2KwUG5omDrhA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rAttS-00AdJf-1W; Wed, 06 Dec 2023 15:32:58 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rAttP-00AdIT-0i; Wed, 06 Dec 2023 15:32:56 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 7C3C5B8218F; Wed, 6 Dec 2023 15:32:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3B75DC433C7; Wed, 6 Dec 2023 15:32:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701876772; bh=w1otnxj6ZQubR19XyLc2pJyxuUrOYv5s6Wn1rb3d1zM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rGASEMZu2w8Un5785u0aGDVqoWrEGsXz1MReexBAxddidRe4ZZe5zAr1Sm0k93D+u Ui2+j1KIQLPLlEMwubHnwKWoqH9i2LMROw+PNo+os8rAPeQ4hST37N62nDpHBIkPO4 uHH8Emz7IPGW/hZ6oLAl6gSzocpcZnFhp6YtRXrD5oszVH52J7j9aOgXwG0nWmcR3T k6K524JwL7SyQMLDxr20AN1PKLPXkVriRV40ck2DScbYe+1PPJuMSCQUvXO70HkFBw uGJnKtfwIFtCkPIEyrUnhg4Hi3AGxm9XoGnIVmFItvXFPxt/PpS5LdtUW6oEHHL6xL hEgUg9hmtXlZg== Date: Wed, 6 Dec 2023 21:02:42 +0530 From: Manivannan Sadhasivam To: Naresh Maramaina Cc: Bart Van Assche , "James E.J. Bottomley" , "Martin K. Petersen" , Peter Wang , Andy Gross , Bjorn Andersson , Konrad Dybcio , Matthias Brugger , AngeloGioacchino Del Regno , chu.stanley@gmail.com, Alim Akhtar , Avri Altman , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, quic_cang@quicinc.com, quic_nguyenb@quicinc.com, Nitin Rawat Subject: Re: [PATCH V2 1/3] ufs: core: Add CPU latency QoS support for ufs driver Message-ID: <20231206153242.GI12802@thinkpad> References: <20231204143101.64163-1-quic_mnaresh@quicinc.com> <20231204143101.64163-2-quic_mnaresh@quicinc.com> <590ade27-b4da-49be-933b-e9959aa0cd4c@acm.org> <692cd503-5b14-4be6-831d-d8e9c282a95e@quicinc.com> <5e7c5c75-cb5f-4afe-9d57-b0cab01a6f26@acm.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231206_073255_552101_1AA1E731 X-CRM114-Status: GOOD ( 24.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBEZWMgMDYsIDIwMjMgYXQgMDc6MzI6NTRQTSArMDUzMCwgTmFyZXNoIE1hcmFtYWlu YSB3cm90ZToKPiAKPiAKPiBPbiAxMi81LzIwMjMgMTA6NDEgUE0sIEJhcnQgVmFuIEFzc2NoZSB3 cm90ZToKPiA+IE9uIDEyLzQvMjMgMjE6NTgsIE5hcmVzaCBNYXJhbWFpbmEgd3JvdGU6Cj4gPiA+ IE9uIDEyLzUvMjAyMyAxMjozMCBBTSwgQmFydCBWYW4gQXNzY2hlIHdyb3RlOgo+ID4gPiA+IE9u IDEyLzQvMjMgMDY6MzAsIE1hcmFtYWluYSBOYXJlc2ggd3JvdGU6Cj4gPiA+ID4gPiArwqDCoMKg IC8qIFRoaXMgY2FwYWJpbGl0eSBhbGxvd3MgdGhlIGhvc3QgY29udHJvbGxlciBkcml2ZXIgdG8K PiA+ID4gPiA+IHVzZSB0aGUgUE0gUW9TCj4gPiA+ID4gPiArwqDCoMKgwqAgKiBmZWF0dXJlLgo+ ID4gPiA+ID4gK8KgwqDCoMKgICovCj4gPiA+ID4gPiArwqDCoMKgIFVGU0hDRF9DQVBfUE1fUU9T wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgID0gMSA8PCAxMywKPiA+ID4gPiA+IMKgIH07 Cj4gPiA+ID4gCj4gPiA+ID4gV2h5IGRvZXMgaXQgZGVwZW5kIG9uIHRoZSBob3N0IGRyaXZlciB3 aGV0aGVyIG9yIG5vdCBQTSBRb1MgaXMKPiA+ID4gPiBlbmFibGVkPyBXaHkgaXNuJ3QgaXQgZW5h YmxlZCB1bmNvbmRpdGlvbmFsbHk/Cj4gPiA+IAo+ID4gPiBGb3Igc29tZSBwbGF0Zm9ybSB2ZW5k b3JzIHBvd2VyIEtQSSBtaWdodCBiZSBtb3JlIGltcG9ydGFudCB0aGFuCj4gPiA+IHJhbmRvbSBp byBLUEkuIEhlbmNlIHRoaXMgZmxhZyBpcyBkaXNhYmxlZCBieSBkZWZhdWx0IGFuZCBjYW4gYmUK PiA+ID4gZW5hYmxlZCBiYXNlZCBvbiBwbGF0Zm9ybSByZXF1aXJlbWVudC4KPiA+IAo+ID4gSG93 IGFib3V0IGxlYXZpbmcgdGhpcyBmbGFnIG91dCB1bmxlc3MgaWYgYSBob3N0IHZlbmRvciBhc2tz IGV4cGxpY2l0bHkKPiA+IGZvciB0aGlzIGZsYWc/Cj4gCj4gSU1ITywgaW5zdGVhZCBvZiBjb21w bGV0ZWx5IHJlbW92aW5nIHRoaXMgZmxhZywgaG93IGFib3V0IGhhdmluZwo+IGZsYWcgbGlrZSAi VUZTSENEX0NBUF9ESVNBQkxFX1BNX1FPUyIgd2hpY2ggd2lsbCBtYWtlIFBNUU9TIGVuYWJsZQo+ IGJ5IGRlZmF1bHQgYW5kIGlmIHNvbWUgaG9zdCB2ZW5kb3Igd2FudHMgdG8gZGlzYWJsZSBpdCBl eHBsaWNpdGx5LAo+IHRoZXkgY2FuIGVuYWJsZSB0aGF0IGZsYWcuCj4gUGxlYXNlIGxldCBtZSBr bm93IHlvdXIgb3Bpbmlvbi4KPiAKCklmIGEgdmVuZG9yIHdhbnRzIHRvIGRpc2FibGUgdGhpcyBm ZWF0dXJlLCB0aGVuIHRoZSBkcml2ZXIgaGFzIHRvIGJlIG1vZGlmaWVkLgpUaGF0IHdvbid0IGJl IHZlcnkgY29udmVuaWVudC4gU28gZWl0aGVyIHRoaXMgaGFzIHRvIGJlIGNvbmZpZ3VyZWQgdGhy b3VnaCBzeXNmcwpvciBLY29uZmlnIGlmIGZsZXhpYmlsaXR5IG1hdHRlcnMuCgotIE1hbmkKCj4g PiA+ID4gCj4gPiA+ID4gPiArICogQHBtX3Fvc19yZXE6IFBNIFFvUyByZXF1ZXN0IGhhbmRsZQo+ ID4gPiA+ID4gKyAqIEBwbV9xb3NfaW5pdDogZmxhZyB0byBjaGVjayBpZiBwbSBxb3MgaW5pdCBj b21wbGV0ZWQKPiA+ID4gPiA+IMKgwqAgKi8KPiA+ID4gPiAKPiA+ID4gPiBEb2N1bWVudGF0aW9u IGZvciBwbV9xb3NfaW5pdCBpcyBtaXNzaW5nLgo+ID4gPiA+IAo+ID4gPiBTb3JyeSwgaSBkaWRu J3QgZ2V0IHlvdXIgY29tbWVudCwgaSBoYXZlIGFscmVhZHkgYWRkZWQgZG9jdW1lbnRhdGlvbgo+ ID4gPiBmb3IgQHBtX3Fvc19pbml0LCBAcG1fcW9zX3JlcSB2YXJpYWJsZSBhcyBhYm92ZS4gRG8g eW91IHdhbnQgbWUgdG8KPiA+ID4gYWRkIHRoaXMgaW5mb3JtYXRpb24gc29tZSB3aGVyZSBlbHNl IGFzIHdlbGw/Cj4gPiAKPiA+IE9vcHMsIEkgbWVhbnQgJ3Fvc192b3RlJy4KPiAKPiBTdXJlLiBJ J2xsIHRha2Ugb2YgdGhpcyBpbiBuZXh0IHBhdGNoc2V0Lgo+IAo+ID4gCj4gPiBUaGFua3MsCj4g PiAKPiA+IEJhcnQuCj4gPiAKPiAKPiBUaGFua3MsCj4gTmFyZXNoCj4gCgotLSAK4K6u4K6j4K6/ 4K614K6j4K+N4K6j4K6p4K+NIOCumuCupOCuvuCumuCuv+CuteCuruCvjQoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWls aW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0 cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=