From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 672A6C9 for ; Wed, 6 Dec 2023 09:11:33 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 96166143D; Wed, 6 Dec 2023 09:12:18 -0800 (PST) Received: from donnerap.manchester.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6CD263F762; Wed, 6 Dec 2023 09:11:31 -0800 (PST) Date: Wed, 6 Dec 2023 17:11:28 +0000 From: Andre Przywara To: Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= Cc: Thierry Reding , kernel@pengutronix.de, Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: Re: [PATCH v4 097/115] pwm: sun4i: Make use of devm_pwmchip_alloc() function Message-ID: <20231206171128.3e2391ea@donnerap.manchester.arm.com> In-Reply-To: References: Organization: ARM X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) Precedence: bulk X-Mailing-List: linux-pwm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed, 6 Dec 2023 12:44:51 +0100 Uwe Kleine-K=C3=B6nig wrote: Hi, > This prepares the pwm-sun4i driver to further changes of the pwm core > outlined in the commit introducing devm_pwmchip_alloc(). There is no > intended semantical change and the driver should behave as before. >=20 > Signed-off-by: Uwe Kleine-K=C3=B6nig That looks alright to me, it's really only wrapping the access to struct sun4i_pwm_chip using the newly provided functions. Reviewed-by: Andre Przywara Cheers, Andre > --- > drivers/pwm/pwm-sun4i.c | 34 +++++++++++++++++++--------------- > 1 file changed, 19 insertions(+), 15 deletions(-) >=20 > diff --git a/drivers/pwm/pwm-sun4i.c b/drivers/pwm/pwm-sun4i.c > index 44edf1ce5739..36a8dc65b19c 100644 > --- a/drivers/pwm/pwm-sun4i.c > +++ b/drivers/pwm/pwm-sun4i.c > @@ -81,7 +81,6 @@ struct sun4i_pwm_data { > }; > =20 > struct sun4i_pwm_chip { > - struct pwm_chip chip; > struct clk *bus_clk; > struct clk *clk; > struct reset_control *rst; > @@ -92,7 +91,7 @@ struct sun4i_pwm_chip { > =20 > static inline struct sun4i_pwm_chip *to_sun4i_pwm_chip(struct pwm_chip *= chip) > { > - return container_of(chip, struct sun4i_pwm_chip, chip); > + return pwmchip_get_drvdata(chip); > } > =20 > static inline u32 sun4i_pwm_readl(struct sun4i_pwm_chip *chip, > @@ -384,17 +383,22 @@ MODULE_DEVICE_TABLE(of, sun4i_pwm_dt_ids); > =20 > static int sun4i_pwm_probe(struct platform_device *pdev) > { > + struct pwm_chip *chip; > struct sun4i_pwm_chip *sun4ichip; > + const struct sun4i_pwm_data *data; > int ret; > =20 > - sun4ichip =3D devm_kzalloc(&pdev->dev, sizeof(*sun4ichip), GFP_KERNEL); > - if (!sun4ichip) > - return -ENOMEM; > - > - sun4ichip->data =3D of_device_get_match_data(&pdev->dev); > - if (!sun4ichip->data) > + data =3D of_device_get_match_data(&pdev->dev); > + if (!data) > return -ENODEV; > =20 > + chip =3D devm_pwmchip_alloc(&pdev->dev, data->npwm, sizeof(*sun4ichip)); > + if (IS_ERR(chip)) > + return PTR_ERR(chip); > + sun4ichip =3D to_sun4i_pwm_chip(chip); > + > + sun4ichip->data =3D data; > + > sun4ichip->base =3D devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(sun4ichip->base)) > return PTR_ERR(sun4ichip->base); > @@ -451,19 +455,18 @@ static int sun4i_pwm_probe(struct platform_device *= pdev) > goto err_bus; > } > =20 > - sun4ichip->chip.dev =3D &pdev->dev; > - sun4ichip->chip.ops =3D &sun4i_pwm_ops; > - sun4ichip->chip.npwm =3D sun4ichip->data->npwm; > + chip->ops =3D &sun4i_pwm_ops; > + chip->npwm =3D sun4ichip->data->npwm; > =20 > spin_lock_init(&sun4ichip->ctrl_lock); > =20 > - ret =3D pwmchip_add(&sun4ichip->chip); > + ret =3D pwmchip_add(chip); > if (ret < 0) { > dev_err(&pdev->dev, "failed to add PWM chip: %d\n", ret); > goto err_pwm_add; > } > =20 > - platform_set_drvdata(pdev, sun4ichip); > + platform_set_drvdata(pdev, chip); > =20 > return 0; > =20 > @@ -477,9 +480,10 @@ static int sun4i_pwm_probe(struct platform_device *p= dev) > =20 > static void sun4i_pwm_remove(struct platform_device *pdev) > { > - struct sun4i_pwm_chip *sun4ichip =3D platform_get_drvdata(pdev); > + struct pwm_chip *chip =3D platform_get_drvdata(pdev); > + struct sun4i_pwm_chip *sun4ichip =3D to_sun4i_pwm_chip(chip); > =20 > - pwmchip_remove(&sun4ichip->chip); > + pwmchip_remove(chip); > =20 > clk_disable_unprepare(sun4ichip->bus_clk); > reset_control_assert(sun4ichip->rst); From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A7707C4167B for ; Wed, 6 Dec 2023 17:12:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=P3c4nwh1qzYeF+6sBFzQw+/iAu3JL0dso1wYlbQ+aCg=; b=vzfJFwMsbw8cYV fGDZMRlx7kO682g7Y1PxP4BABIu8+jafK4uuFRDEWWlfrBBTznZ6vEaVqA+wnqyFfcIPBFnKqo2a9 OxqvSlKVkUMT7oOS6IXANjuBKPWthQGdAwXw4UbdhwTtVC2EClHrK04xzWxvVRrH8NcFmB3AtJjrT 6hBPQTbZau+iSGX83QssrFNcX29eXgEN1qI5UuXU21eq52sgL/kxNj4932Qo9/GQMiGGXm9Z0ftMy BGHAG7l7avMpJvcwgei5MELQxkByBz+CsVCmsO/K6vTA8Wq/ZaOxt4d2MciPH64KnU6QPSWpQgm4K n3J9bDB0OoRflU+krfIg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rAvR1-00ArNr-0T; Wed, 06 Dec 2023 17:11:43 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rAvQy-00ArNJ-0K for linux-arm-kernel@lists.infradead.org; Wed, 06 Dec 2023 17:11:41 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 96166143D; Wed, 6 Dec 2023 09:12:18 -0800 (PST) Received: from donnerap.manchester.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6CD263F762; Wed, 6 Dec 2023 09:11:31 -0800 (PST) Date: Wed, 6 Dec 2023 17:11:28 +0000 From: Andre Przywara To: Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= Cc: Thierry Reding , kernel@pengutronix.de, Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: Re: [PATCH v4 097/115] pwm: sun4i: Make use of devm_pwmchip_alloc() function Message-ID: <20231206171128.3e2391ea@donnerap.manchester.arm.com> In-Reply-To: References: Organization: ARM X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231206_091140_258422_BAD40C8C X-CRM114-Status: GOOD ( 19.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCAgNiBEZWMgMjAyMyAxMjo0NDo1MSArMDEwMApVd2UgS2xlaW5lLUvDtm5pZyA8dS5r bGVpbmUta29lbmlnQHBlbmd1dHJvbml4LmRlPiB3cm90ZToKCkhpLAoKPiBUaGlzIHByZXBhcmVz IHRoZSBwd20tc3VuNGkgZHJpdmVyIHRvIGZ1cnRoZXIgY2hhbmdlcyBvZiB0aGUgcHdtIGNvcmUK PiBvdXRsaW5lZCBpbiB0aGUgY29tbWl0IGludHJvZHVjaW5nIGRldm1fcHdtY2hpcF9hbGxvYygp LiBUaGVyZSBpcyBubwo+IGludGVuZGVkIHNlbWFudGljYWwgY2hhbmdlIGFuZCB0aGUgZHJpdmVy IHNob3VsZCBiZWhhdmUgYXMgYmVmb3JlLgo+IAo+IFNpZ25lZC1vZmYtYnk6IFV3ZSBLbGVpbmUt S8O2bmlnIDx1LmtsZWluZS1rb2VuaWdAcGVuZ3V0cm9uaXguZGU+CgpUaGF0IGxvb2tzIGFscmln aHQgdG8gbWUsIGl0J3MgcmVhbGx5IG9ubHkgd3JhcHBpbmcgdGhlIGFjY2VzcyB0bwpzdHJ1Y3Qg c3VuNGlfcHdtX2NoaXAgdXNpbmcgdGhlIG5ld2x5IHByb3ZpZGVkIGZ1bmN0aW9ucy4KClJldmll d2VkLWJ5OiBBbmRyZSBQcnp5d2FyYSA8YW5kcmUucHJ6eXdhcmFAYXJtLmNvbT4KCkNoZWVycywK QW5kcmUKCj4gLS0tCj4gIGRyaXZlcnMvcHdtL3B3bS1zdW40aS5jIHwgMzQgKysrKysrKysrKysr KysrKysrKy0tLS0tLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMTkgaW5zZXJ0aW9ucygr KSwgMTUgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvcHdtL3B3bS1zdW40 aS5jIGIvZHJpdmVycy9wd20vcHdtLXN1bjRpLmMKPiBpbmRleCA0NGVkZjFjZTU3MzkuLjM2YThk YzY1YjE5YyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3B3bS9wd20tc3VuNGkuYwo+ICsrKyBiL2Ry aXZlcnMvcHdtL3B3bS1zdW40aS5jCj4gQEAgLTgxLDcgKzgxLDYgQEAgc3RydWN0IHN1bjRpX3B3 bV9kYXRhIHsKPiAgfTsKPiAgCj4gIHN0cnVjdCBzdW40aV9wd21fY2hpcCB7Cj4gLQlzdHJ1Y3Qg cHdtX2NoaXAgY2hpcDsKPiAgCXN0cnVjdCBjbGsgKmJ1c19jbGs7Cj4gIAlzdHJ1Y3QgY2xrICpj bGs7Cj4gIAlzdHJ1Y3QgcmVzZXRfY29udHJvbCAqcnN0Owo+IEBAIC05Miw3ICs5MSw3IEBAIHN0 cnVjdCBzdW40aV9wd21fY2hpcCB7Cj4gIAo+ICBzdGF0aWMgaW5saW5lIHN0cnVjdCBzdW40aV9w d21fY2hpcCAqdG9fc3VuNGlfcHdtX2NoaXAoc3RydWN0IHB3bV9jaGlwICpjaGlwKQo+ICB7Cj4g LQlyZXR1cm4gY29udGFpbmVyX29mKGNoaXAsIHN0cnVjdCBzdW40aV9wd21fY2hpcCwgY2hpcCk7 Cj4gKwlyZXR1cm4gcHdtY2hpcF9nZXRfZHJ2ZGF0YShjaGlwKTsKPiAgfQo+ICAKPiAgc3RhdGlj IGlubGluZSB1MzIgc3VuNGlfcHdtX3JlYWRsKHN0cnVjdCBzdW40aV9wd21fY2hpcCAqY2hpcCwK PiBAQCAtMzg0LDE3ICszODMsMjIgQEAgTU9EVUxFX0RFVklDRV9UQUJMRShvZiwgc3VuNGlfcHdt X2R0X2lkcyk7Cj4gIAo+ICBzdGF0aWMgaW50IHN1bjRpX3B3bV9wcm9iZShzdHJ1Y3QgcGxhdGZv cm1fZGV2aWNlICpwZGV2KQo+ICB7Cj4gKwlzdHJ1Y3QgcHdtX2NoaXAgKmNoaXA7Cj4gIAlzdHJ1 Y3Qgc3VuNGlfcHdtX2NoaXAgKnN1bjRpY2hpcDsKPiArCWNvbnN0IHN0cnVjdCBzdW40aV9wd21f ZGF0YSAqZGF0YTsKPiAgCWludCByZXQ7Cj4gIAo+IC0Jc3VuNGljaGlwID0gZGV2bV9remFsbG9j KCZwZGV2LT5kZXYsIHNpemVvZigqc3VuNGljaGlwKSwgR0ZQX0tFUk5FTCk7Cj4gLQlpZiAoIXN1 bjRpY2hpcCkKPiAtCQlyZXR1cm4gLUVOT01FTTsKPiAtCj4gLQlzdW40aWNoaXAtPmRhdGEgPSBv Zl9kZXZpY2VfZ2V0X21hdGNoX2RhdGEoJnBkZXYtPmRldik7Cj4gLQlpZiAoIXN1bjRpY2hpcC0+ ZGF0YSkKPiArCWRhdGEgPSBvZl9kZXZpY2VfZ2V0X21hdGNoX2RhdGEoJnBkZXYtPmRldik7Cj4g KwlpZiAoIWRhdGEpCj4gIAkJcmV0dXJuIC1FTk9ERVY7Cj4gIAo+ICsJY2hpcCA9IGRldm1fcHdt Y2hpcF9hbGxvYygmcGRldi0+ZGV2LCBkYXRhLT5ucHdtLCBzaXplb2YoKnN1bjRpY2hpcCkpOwo+ ICsJaWYgKElTX0VSUihjaGlwKSkKPiArCQlyZXR1cm4gUFRSX0VSUihjaGlwKTsKPiArCXN1bjRp Y2hpcCA9IHRvX3N1bjRpX3B3bV9jaGlwKGNoaXApOwo+ICsKPiArCXN1bjRpY2hpcC0+ZGF0YSA9 IGRhdGE7Cj4gKwo+ICAJc3VuNGljaGlwLT5iYXNlID0gZGV2bV9wbGF0Zm9ybV9pb3JlbWFwX3Jl c291cmNlKHBkZXYsIDApOwo+ICAJaWYgKElTX0VSUihzdW40aWNoaXAtPmJhc2UpKQo+ICAJCXJl dHVybiBQVFJfRVJSKHN1bjRpY2hpcC0+YmFzZSk7Cj4gQEAgLTQ1MSwxOSArNDU1LDE4IEBAIHN0 YXRpYyBpbnQgc3VuNGlfcHdtX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4g IAkJZ290byBlcnJfYnVzOwo+ICAJfQo+ICAKPiAtCXN1bjRpY2hpcC0+Y2hpcC5kZXYgPSAmcGRl di0+ZGV2Owo+IC0Jc3VuNGljaGlwLT5jaGlwLm9wcyA9ICZzdW40aV9wd21fb3BzOwo+IC0Jc3Vu NGljaGlwLT5jaGlwLm5wd20gPSBzdW40aWNoaXAtPmRhdGEtPm5wd207Cj4gKwljaGlwLT5vcHMg PSAmc3VuNGlfcHdtX29wczsKPiArCWNoaXAtPm5wd20gPSBzdW40aWNoaXAtPmRhdGEtPm5wd207 Cj4gIAo+ICAJc3Bpbl9sb2NrX2luaXQoJnN1bjRpY2hpcC0+Y3RybF9sb2NrKTsKPiAgCj4gLQly ZXQgPSBwd21jaGlwX2FkZCgmc3VuNGljaGlwLT5jaGlwKTsKPiArCXJldCA9IHB3bWNoaXBfYWRk KGNoaXApOwo+ICAJaWYgKHJldCA8IDApIHsKPiAgCQlkZXZfZXJyKCZwZGV2LT5kZXYsICJmYWls ZWQgdG8gYWRkIFBXTSBjaGlwOiAlZFxuIiwgcmV0KTsKPiAgCQlnb3RvIGVycl9wd21fYWRkOwo+ ICAJfQo+ICAKPiAtCXBsYXRmb3JtX3NldF9kcnZkYXRhKHBkZXYsIHN1bjRpY2hpcCk7Cj4gKwlw bGF0Zm9ybV9zZXRfZHJ2ZGF0YShwZGV2LCBjaGlwKTsKPiAgCj4gIAlyZXR1cm4gMDsKPiAgCj4g QEAgLTQ3Nyw5ICs0ODAsMTAgQEAgc3RhdGljIGludCBzdW40aV9wd21fcHJvYmUoc3RydWN0IHBs YXRmb3JtX2RldmljZSAqcGRldikKPiAgCj4gIHN0YXRpYyB2b2lkIHN1bjRpX3B3bV9yZW1vdmUo c3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiAgewo+IC0Jc3RydWN0IHN1bjRpX3B3bV9j aGlwICpzdW40aWNoaXAgPSBwbGF0Zm9ybV9nZXRfZHJ2ZGF0YShwZGV2KTsKPiArCXN0cnVjdCBw d21fY2hpcCAqY2hpcCA9IHBsYXRmb3JtX2dldF9kcnZkYXRhKHBkZXYpOwo+ICsJc3RydWN0IHN1 bjRpX3B3bV9jaGlwICpzdW40aWNoaXAgPSB0b19zdW40aV9wd21fY2hpcChjaGlwKTsKPiAgCj4g LQlwd21jaGlwX3JlbW92ZSgmc3VuNGljaGlwLT5jaGlwKTsKPiArCXB3bWNoaXBfcmVtb3ZlKGNo aXApOwo+ICAKPiAgCWNsa19kaXNhYmxlX3VucHJlcGFyZShzdW40aWNoaXAtPmJ1c19jbGspOwo+ ICAJcmVzZXRfY29udHJvbF9hc3NlcnQoc3VuNGljaGlwLT5yc3QpOwoKCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGlu ZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMu aW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK