From: kernel test robot <lkp@intel.com>
To: Yury Norov <yury.norov@gmail.com>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [norov:for_each_numa_cpu 6/7] drivers/net/ethernet/mellanox/mlx5/core/eq.c:840:9: error: implicit declaration of function 'for_each_numa_hop_mask'; did you mean 'for_each_numa_cpu'?
Date: Wed, 6 Dec 2023 20:28:40 +0800 [thread overview]
Message-ID: <202312062028.IvSWI4kh-lkp@intel.com> (raw)
tree: https://github.com/norov/linux for_each_numa_cpu
head: d348e04a6f8498089a335a87fc5e7b03bca42411
commit: 00d4334c1cccbcd557bfbef79b4ab30bc0cffb77 [6/7] sched: drop for_each_numa_hop_mask()
config: arm64-defconfig (https://download.01.org/0day-ci/archive/20231206/202312062028.IvSWI4kh-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231206/202312062028.IvSWI4kh-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312062028.IvSWI4kh-lkp@intel.com/
All error/warnings (new ones prefixed by >>):
drivers/net/ethernet/mellanox/mlx5/core/eq.c: In function 'mlx5_cpumask_default_spread':
>> drivers/net/ethernet/mellanox/mlx5/core/eq.c:840:9: error: implicit declaration of function 'for_each_numa_hop_mask'; did you mean 'for_each_numa_cpu'? [-Werror=implicit-function-declaration]
840 | for_each_numa_hop_mask(mask, numa_node) {
| ^~~~~~~~~~~~~~~~~~~~~~
| for_each_numa_cpu
>> drivers/net/ethernet/mellanox/mlx5/core/eq.c:840:48: error: expected ';' before '{' token
840 | for_each_numa_hop_mask(mask, numa_node) {
| ^~
| ;
>> drivers/net/ethernet/mellanox/mlx5/core/eq.c:837:13: warning: unused variable 'cpu' [-Wunused-variable]
837 | int cpu;
| ^~~
>> drivers/net/ethernet/mellanox/mlx5/core/eq.c:836:13: warning: unused variable 'i' [-Wunused-variable]
836 | int i = 0;
| ^
>> drivers/net/ethernet/mellanox/mlx5/core/eq.c:833:31: warning: unused variable 'prev' [-Wunused-variable]
833 | const struct cpumask *prev = cpu_none_mask;
| ^~~~
cc1: some warnings being treated as errors
vim +840 drivers/net/ethernet/mellanox/mlx5/core/eq.c
79b60ca83b6fa6 Shay Drory 2021-12-12 830
ddd2c79da02021 Maher Sanalla 2023-06-12 831 static int mlx5_cpumask_default_spread(int numa_node, int index)
79b60ca83b6fa6 Shay Drory 2021-12-12 832 {
2acda57736de1e Tariq Toukan 2023-01-20 @833 const struct cpumask *prev = cpu_none_mask;
2acda57736de1e Tariq Toukan 2023-01-20 834 const struct cpumask *mask;
54b2cf41b853e0 Maher Sanalla 2023-06-12 835 int found_cpu = 0;
54b2cf41b853e0 Maher Sanalla 2023-06-12 @836 int i = 0;
2acda57736de1e Tariq Toukan 2023-01-20 @837 int cpu;
2acda57736de1e Tariq Toukan 2023-01-20 838
2acda57736de1e Tariq Toukan 2023-01-20 839 rcu_read_lock();
ddd2c79da02021 Maher Sanalla 2023-06-12 @840 for_each_numa_hop_mask(mask, numa_node) {
2acda57736de1e Tariq Toukan 2023-01-20 841 for_each_cpu_andnot(cpu, mask, prev) {
ddd2c79da02021 Maher Sanalla 2023-06-12 842 if (i++ == index) {
54b2cf41b853e0 Maher Sanalla 2023-06-12 843 found_cpu = cpu;
2acda57736de1e Tariq Toukan 2023-01-20 844 goto spread_done;
2acda57736de1e Tariq Toukan 2023-01-20 845 }
54b2cf41b853e0 Maher Sanalla 2023-06-12 846 }
2acda57736de1e Tariq Toukan 2023-01-20 847 prev = mask;
2acda57736de1e Tariq Toukan 2023-01-20 848 }
54b2cf41b853e0 Maher Sanalla 2023-06-12 849
2acda57736de1e Tariq Toukan 2023-01-20 850 spread_done:
2acda57736de1e Tariq Toukan 2023-01-20 851 rcu_read_unlock();
ddd2c79da02021 Maher Sanalla 2023-06-12 852 return found_cpu;
ddd2c79da02021 Maher Sanalla 2023-06-12 853 }
ddd2c79da02021 Maher Sanalla 2023-06-12 854
:::::: The code at line 840 was first introduced by commit
:::::: ddd2c79da02021153dc8674e5a7e9748e56c1240 net/mlx5: Introduce mlx5_cpumask_default_spread
:::::: TO: Maher Sanalla <msanalla@nvidia.com>
:::::: CC: Saeed Mahameed <saeedm@nvidia.com>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2023-12-06 12:29 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202312062028.IvSWI4kh-lkp@intel.com \
--to=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.