From: Jakub Kicinski <kuba@kernel.org>
To: Michael Chan <michael.chan@broadcom.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, gospo@broadcom.com,
Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
Somnath Kotur <somnath.kotur@broadcom.com>,
Andy Gospodarek <andrew.gospodarek@broadcom.com>,
Vikas Gupta <vikas.gupta@broadcom.com>
Subject: Re: [PATCH net v2 2/4] bnxt_en: Fix skb recycling logic in bnxt_deliver_skb()
Date: Thu, 7 Dec 2023 10:21:44 -0800 [thread overview]
Message-ID: <20231207102144.6634a108@kernel.org> (raw)
In-Reply-To: <20231207000551.138584-3-michael.chan@broadcom.com>
On Wed, 6 Dec 2023 16:05:49 -0800 Michael Chan wrote:
> Receive SKBs can go through the VF-rep path or the normal path.
> skb_mark_for_recycle() is only called for the normal path. Fix it
> to do it for both paths to fix possible stalled page pool shutdown
> errors.
This patch is probably fine, but since I'm complaining -
IMHO it may be better to mark the skbs right after they
are allocated. Catching all "exit points" seems very error
prone...
next prev parent reply other threads:[~2023-12-07 18:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-07 0:05 [PATCH net v2 0/4] bnxt_en: Misc. fixes Michael Chan
2023-12-07 0:05 ` [PATCH net v2 1/4] bnxt_en: Clear resource reservation during resume Michael Chan
2023-12-07 18:20 ` Jakub Kicinski
2023-12-07 0:05 ` [PATCH net v2 2/4] bnxt_en: Fix skb recycling logic in bnxt_deliver_skb() Michael Chan
2023-12-07 18:21 ` Jakub Kicinski [this message]
2023-12-07 18:22 ` Jakub Kicinski
2023-12-07 18:37 ` Andy Gospodarek
2023-12-07 18:41 ` Jakub Kicinski
2023-12-07 0:05 ` [PATCH net v2 3/4] bnxt_en: Fix wrong return value check in bnxt_close_nic() Michael Chan
2023-12-07 18:27 ` Jakub Kicinski
2023-12-07 22:24 ` Michael Chan
2023-12-07 22:31 ` Jakub Kicinski
2023-12-07 0:05 ` [PATCH net v2 4/4] bnxt_en: Fix HWTSTAMP_FILTER_ALL packet timestamp logic Michael Chan
2023-12-07 12:04 ` [PATCH net v2 0/4] bnxt_en: Misc. fixes Vadim Fedorenko
2023-12-07 16:24 ` Michael Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231207102144.6634a108@kernel.org \
--to=kuba@kernel.org \
--cc=andrew.gospodarek@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gospo@broadcom.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=somnath.kotur@broadcom.com \
--cc=sreekanth.reddy@broadcom.com \
--cc=vikas.gupta@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.