From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="sFef0Kf+" Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 649311985 for ; Thu, 7 Dec 2023 04:44:53 -0800 (PST) Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 5F5AE669; Thu, 7 Dec 2023 13:44:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1701953050; bh=gtDwbglrvA3fVGX5Y00vGoREOSqrPfWHQKahmtsUrgM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sFef0Kf+4oau8nI5mQqoA2lfnPCba//YQxD9D8WKhcatsHQcyPlUg3vk968JREDpC 1OeYRV2JxftH1pI5KXjc1YMy4hwbAEKWnJ5V1/Dk9ujbfW+K03HbnoMLbiSE3+j2sS +1c5iomGbkYhSr28iwuYtQrl0uUjkber3eggip1Q= Date: Thu, 7 Dec 2023 14:44:58 +0200 From: Laurent Pinchart To: Sakari Ailus Cc: linux-media@vger.kernel.org, Mauro Carvalho Chehab , hverkuil@xs4all.nl Subject: Re: [PATCH 2/6] media: adv7183: Don't set format in sub-device state Message-ID: <20231207124458.GD9675@pendragon.ideasonboard.com> References: <20231207120912.270716-1-sakari.ailus@linux.intel.com> <20231207120912.270716-3-sakari.ailus@linux.intel.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20231207120912.270716-3-sakari.ailus@linux.intel.com> Hi Sakari, Thank you for the patch. On Thu, Dec 07, 2023 at 02:09:08PM +0200, Sakari Ailus wrote: > For the purpose of setting old non-pad based sub-device try format as a > basis for VIDIOC_TRY_FMT implementation, there is no need to set the > format in the sub-device state. Drop the assignment to the state, which > would result in a NULL pointer dereference. > > Fixes: fd17e3a9a788 ("media: i2c: Use accessors for pad config 'try_*' fields") > Signed-off-by: Sakari Ailus Reviewed-by: Laurent Pinchart > --- > drivers/media/i2c/adv7183.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/media/i2c/adv7183.c b/drivers/media/i2c/adv7183.c > index bcb99ba9a272..2a2cace4a153 100644 > --- a/drivers/media/i2c/adv7183.c > +++ b/drivers/media/i2c/adv7183.c > @@ -442,8 +442,6 @@ static int adv7183_set_fmt(struct v4l2_subdev *sd, > } > if (format->which == V4L2_SUBDEV_FORMAT_ACTIVE) > decoder->fmt = *fmt; > - else > - *v4l2_subdev_state_get_format(sd_state, 0) = *fmt; > return 0; > } > -- Regards, Laurent Pinchart