From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f41.google.com (mail-oo1-f41.google.com [209.85.161.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A9F210CA; Thu, 7 Dec 2023 09:30:40 -0800 (PST) Received: by mail-oo1-f41.google.com with SMTP id 006d021491bc7-58d12b53293so517835eaf.0; Thu, 07 Dec 2023 09:30:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701970239; x=1702575039; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aqj0z6kEygULbYJbl9fDvMATmV0n6DPZZ0Ol7473clQ=; b=Ie5KPFuFjNI8LNiDdCiUbWAFSd2o1hOXcif1JKQTnMuY1iUrf9Blu7xLWZbOgMp/Su xzFr90mpeCXCyADJMqI8H2+7tKfEViPZ8PlSZElYepQsf62aLAJIVYSRls90PBc4AJhZ DSm1fLrhG7VQjxO9vYF9eiu2rKho7XEk6y4p4J3SUWwIGOWKQNGD2qk7r9AbTHpbYiOg 17irKggpuMwn3YLqs/VVnilZNQcxccDnHwhxlDM87h1IF9BrNo0ZYR5snejn2SAgRV1X medlzFHj3R8H7asvuHs8l5TmaOpklms5lkL+WRH8sUQ0+xqf7OXHbwId4gf3Bkosn6+G YKWw== X-Gm-Message-State: AOJu0YwTKaxma+/Tj7UCgdn33v2ZVTAz+bZv43nNjkxGOFassR3KFEL2 yE5ZZe5xGGG94o4IBnFZUA== X-Google-Smtp-Source: AGHT+IF3F8YBAWZBvd1RIa5py5Lvvl2NkA72wnpM8EkmUcXD/AJYQyxVqC4by4fUaPk/uragnrGJtQ== X-Received: by 2002:a05:6820:1c90:b0:58d:9ff4:7646 with SMTP id ct16-20020a0568201c9000b0058d9ff47646mr3042277oob.4.1701970239382; Thu, 07 Dec 2023 09:30:39 -0800 (PST) Received: from herring.priv (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id w21-20020a4a3555000000b00587947707aasm10168oog.4.2023.12.07.09.30.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Dec 2023 09:30:38 -0800 (PST) Received: (nullmailer pid 2946014 invoked by uid 1000); Thu, 07 Dec 2023 17:30:37 -0000 Date: Thu, 7 Dec 2023 11:30:37 -0600 From: Rob Herring To: Javier Martinez Canillas Cc: Thomas Zimmermann , Ard Biesheuvel , devicetree@vger.kernel.org, Sergio Lopez , Sima Vetter , Hector Martin , Andrew Worsley , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Frank Rowand Subject: Re: [RFC PATCH] of/platform: Disable sysfb if a simple-framebuffer node is found Message-ID: <20231207173037.GA2944721-robh@kernel.org> References: <87jzqi59bt.fsf@minerva.mail-host-address-is-not-set> <874jhj1fm3.fsf@minerva.mail-host-address-is-not-set> <58672ab8-99bf-4a2a-af79-031d1e8fcba0@suse.de> <87fs0mxlyp.fsf@minerva.mail-host-address-is-not-set> <87a5qqxq56.fsf@minerva.mail-host-address-is-not-set> <87zfyqvtpx.fsf@minerva.mail-host-address-is-not-set> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87zfyqvtpx.fsf@minerva.mail-host-address-is-not-set> On Mon, Dec 04, 2023 at 05:05:30PM +0100, Javier Martinez Canillas wrote: > Rob Herring writes: > > > On Mon, Dec 4, 2023 at 3:39 AM Javier Martinez Canillas > > wrote: > >> Rob Herring writes: > >> > On Fri, Dec 1, 2023 at 4:21 AM Javier Martinez Canillas > > [...] > > >> > >> > However, there might be one other issue with that and this fix. The DT > >> > simplefb can have resources such as clocks and regulators. With > >> > fw_devlink, the driver won't probe until those dependencies are met. > >> > So if you want the framebuffer console up early, then you may want to > >> > register the EFI framebuffer first and then handoff to the DT simplefb > >> > when it probes (rather than registering the device). > >> > > >> > But I agree, probably better to take this patch now and have those > >> > quirks instead of flat out not working. > >> > > >> > >> If we do that what's the plan? Are you thinking about merging this patch > >> through your OF tree or do you want to go through drm-misc with your ack? > > > > I can take it. Do we need this in 6.7 and stable? > > > > IMO this can wait for v6.8 since is not a fix for a change introduced in > the v6.7 merge window and something that only happens on a very specific > setup (DT systems booting with u-boot EFI and providing an EFI-GOP table). > > Also the -rc cycle is already in -rc5, so it seems risky to push a change > at this point. And distros can pick the patch if want to have it earlier. Okay, I've applied it for 6.8. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 07CAEC4167B for ; Thu, 7 Dec 2023 17:30:43 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 56B8610E1A2; Thu, 7 Dec 2023 17:30:42 +0000 (UTC) Received: from mail-oo1-f52.google.com (mail-oo1-f52.google.com [209.85.161.52]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2BB4A10E1A2 for ; Thu, 7 Dec 2023 17:30:40 +0000 (UTC) Received: by mail-oo1-f52.google.com with SMTP id 006d021491bc7-58e28e0461bso511621eaf.1 for ; Thu, 07 Dec 2023 09:30:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701970239; x=1702575039; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aqj0z6kEygULbYJbl9fDvMATmV0n6DPZZ0Ol7473clQ=; b=CtnwFTqJZk1jwv9/50HcIivWYYhu/n1MQYzMToEWP4oEgv9hx42XBpZy/FXSuCW3px WC5O4rOnh7Xna3xcwUxbOL+vW93OsDtuGvrykIKWZLPVnluCliPDGd/2I/iQg6nqW+j7 cIUMccvawPDfzzWLun4Ei2p1x9N9Iw1iSAAbnsHTtPgL7rPAGip9exN8PuQ8/Z+5w9ri 4Cbekq+hUIMPAG7m2N38W8qVF6KC9JCKN8jcr/JCNOCNZXiylknOOPpVVmQ30EajwF1+ M9yXcyfBxob9wvgrtQvM42Cg0sK+MaLCAbA33MFMnLc62NplefuJbtQIZWlWKqvbUglq pwew== X-Gm-Message-State: AOJu0YytwKCPlPXT7ldyFyzkR90TJgm/184nNwAFv/UjqOIO4AdPsdCX NApArY645eZoqkUmhV5OVvlrAZhSbw== X-Google-Smtp-Source: AGHT+IF3F8YBAWZBvd1RIa5py5Lvvl2NkA72wnpM8EkmUcXD/AJYQyxVqC4by4fUaPk/uragnrGJtQ== X-Received: by 2002:a05:6820:1c90:b0:58d:9ff4:7646 with SMTP id ct16-20020a0568201c9000b0058d9ff47646mr3042277oob.4.1701970239382; Thu, 07 Dec 2023 09:30:39 -0800 (PST) Received: from herring.priv (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id w21-20020a4a3555000000b00587947707aasm10168oog.4.2023.12.07.09.30.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Dec 2023 09:30:38 -0800 (PST) Received: (nullmailer pid 2946014 invoked by uid 1000); Thu, 07 Dec 2023 17:30:37 -0000 Date: Thu, 7 Dec 2023 11:30:37 -0600 From: Rob Herring To: Javier Martinez Canillas Subject: Re: [RFC PATCH] of/platform: Disable sysfb if a simple-framebuffer node is found Message-ID: <20231207173037.GA2944721-robh@kernel.org> References: <87jzqi59bt.fsf@minerva.mail-host-address-is-not-set> <874jhj1fm3.fsf@minerva.mail-host-address-is-not-set> <58672ab8-99bf-4a2a-af79-031d1e8fcba0@suse.de> <87fs0mxlyp.fsf@minerva.mail-host-address-is-not-set> <87a5qqxq56.fsf@minerva.mail-host-address-is-not-set> <87zfyqvtpx.fsf@minerva.mail-host-address-is-not-set> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87zfyqvtpx.fsf@minerva.mail-host-address-is-not-set> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Sergio Lopez , Sima Vetter , Hector Martin , Andrew Worsley , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Thomas Zimmermann , Frank Rowand , Ard Biesheuvel Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Dec 04, 2023 at 05:05:30PM +0100, Javier Martinez Canillas wrote: > Rob Herring writes: > > > On Mon, Dec 4, 2023 at 3:39 AM Javier Martinez Canillas > > wrote: > >> Rob Herring writes: > >> > On Fri, Dec 1, 2023 at 4:21 AM Javier Martinez Canillas > > [...] > > >> > >> > However, there might be one other issue with that and this fix. The DT > >> > simplefb can have resources such as clocks and regulators. With > >> > fw_devlink, the driver won't probe until those dependencies are met. > >> > So if you want the framebuffer console up early, then you may want to > >> > register the EFI framebuffer first and then handoff to the DT simplefb > >> > when it probes (rather than registering the device). > >> > > >> > But I agree, probably better to take this patch now and have those > >> > quirks instead of flat out not working. > >> > > >> > >> If we do that what's the plan? Are you thinking about merging this patch > >> through your OF tree or do you want to go through drm-misc with your ack? > > > > I can take it. Do we need this in 6.7 and stable? > > > > IMO this can wait for v6.8 since is not a fix for a change introduced in > the v6.7 merge window and something that only happens on a very specific > setup (DT systems booting with u-boot EFI and providing an EFI-GOP table). > > Also the -rc cycle is already in -rc5, so it seems risky to push a change > at this point. And distros can pick the patch if want to have it earlier. Okay, I've applied it for 6.8. Rob