All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Rob Herring <robh@kernel.org>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [robh:for-next 6/7] drivers/reset/sti/reset-syscfg.c:196:1: warning: control reaches end of non-void function
Date: Thu, 7 Dec 2023 22:45:06 +0800	[thread overview]
Message-ID: <202312072209.EZJmUcli-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
head:   6c26cfb1561efbf12fe3cf700ddc2e956866af45
commit: f793fea7761d32ed64767311c82f39f0798fe6d6 [6/7] of: Stop circularly including of_device.h and of_platform.h
config: arm-multi_v7_defconfig (https://download.01.org/0day-ci/archive/20231207/202312072209.EZJmUcli-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231207/202312072209.EZJmUcli-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312072209.EZJmUcli-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/reset/sti/reset-syscfg.c: In function 'syscfg_reset_probe':
   drivers/reset/sti/reset-syscfg.c:192:29: error: invalid use of undefined type 'const struct of_device_id'
     192 |         if (!match || !match->data)
         |                             ^~
   drivers/reset/sti/reset-syscfg.c:195:59: error: invalid use of undefined type 'const struct of_device_id'
     195 |         return syscfg_reset_controller_register(dev, match->data);
         |                                                           ^~
>> drivers/reset/sti/reset-syscfg.c:196:1: warning: control reaches end of non-void function [-Wreturn-type]
     196 | }
         | ^


vim +196 drivers/reset/sti/reset-syscfg.c

e5d76075d9300a4 Stephen Gallimore 2013-08-07  182  
e5d76075d9300a4 Stephen Gallimore 2013-08-07  183  int syscfg_reset_probe(struct platform_device *pdev)
e5d76075d9300a4 Stephen Gallimore 2013-08-07  184  {
e5d76075d9300a4 Stephen Gallimore 2013-08-07  185  	struct device *dev = pdev ? &pdev->dev : NULL;
e5d76075d9300a4 Stephen Gallimore 2013-08-07  186  	const struct of_device_id *match;
e5d76075d9300a4 Stephen Gallimore 2013-08-07  187  
e5d76075d9300a4 Stephen Gallimore 2013-08-07  188  	if (!dev || !dev->driver)
e5d76075d9300a4 Stephen Gallimore 2013-08-07  189  		return -ENODEV;
e5d76075d9300a4 Stephen Gallimore 2013-08-07  190  
e5d76075d9300a4 Stephen Gallimore 2013-08-07  191  	match = of_match_device(dev->driver->of_match_table, dev);
e5d76075d9300a4 Stephen Gallimore 2013-08-07  192  	if (!match || !match->data)
e5d76075d9300a4 Stephen Gallimore 2013-08-07  193  		return -EINVAL;
e5d76075d9300a4 Stephen Gallimore 2013-08-07  194  
e5d76075d9300a4 Stephen Gallimore 2013-08-07  195  	return syscfg_reset_controller_register(dev, match->data);
e5d76075d9300a4 Stephen Gallimore 2013-08-07 @196  }

:::::: The code at line 196 was first introduced by commit
:::::: e5d76075d9300a483619f7f308a693311af9c2cb drivers: reset: STi SoC system configuration reset controller support

:::::: TO: Stephen Gallimore <stephen.gallimore@st.com>
:::::: CC: Srinivas Kandagatla <srinivas.kandagatla@st.com>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2023-12-07 14:45 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202312072209.EZJmUcli-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.