From: Gang Li <gang.li@linux.dev>
To: David Rientjes <rientjes@google.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
ligang.bdlg@bytedance.com, Gang Li <gang.li@linux.dev>
Subject: [PATCH 1/1] hugetlb: add timing to hugetlb allocations on boot
Date: Fri, 8 Dec 2023 10:56:17 +0800 [thread overview]
Message-ID: <20231208025617.5299-1-gang.li@linux.dev> (raw)
In-Reply-To: <20231208025240.4744-1-gang.li@linux.dev>
Add timing to hugetlb allocations for further optimization.
Debug only.
Signed-off-by: Gang Li <gang.li@linux.dev>
---
mm/hugetlb.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index 1169ef2f2176f..51f50bb3dc092 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -4490,6 +4490,7 @@ static inline void hugetlb_sysctl_init(void) { }
static int __init hugetlb_init(void)
{
int i;
+ unsigned long start;
BUILD_BUG_ON(sizeof_field(struct page, private) * BITS_PER_BYTE <
__NR_HPAGEFLAGS);
@@ -4536,8 +4537,11 @@ static int __init hugetlb_init(void)
}
hugetlb_cma_check();
+ start = jiffies;
hugetlb_init_hstates();
gather_bootmem_prealloc();
+ pr_info("HugeTLB: 2M alloc, init and 1G init takes %u ms\n",
+ jiffies_to_msecs(jiffies - start));
report_hugepages();
hugetlb_sysfs_init();
@@ -4682,6 +4686,7 @@ static int __init hugepages_setup(char *s)
}
}
+ unsigned long start = jiffies;
/*
* Global state is always initialized later in hugetlb_init.
* But we need to allocate gigantic hstates here early to still
@@ -4692,6 +4697,7 @@ static int __init hugepages_setup(char *s)
last_mhp = mhp;
+ pr_info("HugeTLB: 1G alloc takes %u ms\n", jiffies_to_msecs(jiffies - start));
return 1;
invalid:
--
2.30.2
next prev parent reply other threads:[~2023-12-08 2:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-08 2:52 [RFC PATCH v2 0/5] hugetlb: parallelize hugetlb page init on boot Gang Li
2023-12-08 2:52 ` [RFC PATCH v2 1/5] hugetlb: code clean for hugetlb_hstate_alloc_pages Gang Li
2023-12-08 2:52 ` [RFC PATCH v2 2/5] hugetlb: split hugetlb_hstate_alloc_pages Gang Li
2023-12-08 2:52 ` [RFC PATCH v2 3/5] padata: dispatch works on different nodes Gang Li
2023-12-12 23:40 ` Tim Chen
2023-12-18 6:46 ` Gang Li
2023-12-27 10:33 ` Gang Li
2023-12-08 2:52 ` [RFC PATCH v2 4/5] hugetlb: parallelize 2M hugetlb allocation and initialization Gang Li
2023-12-08 2:52 ` [RFC PATCH v2 5/5] hugetlb: parallelize 1G hugetlb initialization Gang Li
2023-12-08 2:56 ` Gang Li [this message]
2023-12-12 20:06 ` [RFC PATCH v2 0/5] hugetlb: parallelize hugetlb page init on boot Mike Kravetz
2023-12-21 7:22 ` Gang Li
2023-12-12 22:14 ` David Rientjes
2023-12-12 23:08 ` Mike Kravetz
2023-12-13 0:10 ` David Rientjes
2023-12-18 6:34 ` Gang Li
2023-12-22 4:33 ` David Rientjes
2023-12-25 5:21 ` David Rientjes
2023-12-25 6:24 ` Gang Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231208025617.5299-1-gang.li@linux.dev \
--to=gang.li@linux.dev \
--cc=ligang.bdlg@bytedance.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.