* drivers/irqchip/irq-apple-aic.c:980 aic_of_ic_init() error: uninitialized symbol 'start_off'.
@ 2022-06-06 11:18 ` Dan Carpenter
0 siblings, 0 replies; 7+ messages in thread
From: kernel test robot @ 2022-06-01 2:50 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 9454 bytes --]
CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: linux-kernel(a)vger.kernel.org
TO: Hector Martin <marcan@marcan.st>
CC: Marc Zyngier <maz@kernel.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 700170bf6b4d773e328fa54ebb70ba444007c702
commit: a801f0ee563b8180caf186493806a145a75b4a3c irqchip/apple-aic: Support multiple dies
date: 3 months ago
:::::: branch date: 3 hours ago
:::::: commit date: 3 months ago
config: arm64-randconfig-m031-20220530 (https://download.01.org/0day-ci/archive/20220601/202206011052.du9opGWF-lkp(a)intel.com/config)
compiler: aarch64-linux-gcc (GCC) 11.3.0
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/irqchip/irq-apple-aic.c:980 aic_of_ic_init() error: uninitialized symbol 'start_off'.
Old smatch warnings:
drivers/irqchip/irq-apple-aic.c:943 aic_of_ic_init() warn: possible memory leak of 'irqc'
drivers/irqchip/irq-apple-aic.c:965 aic_of_ic_init() error: uninitialized symbol 'off'.
drivers/irqchip/irq-apple-aic.c:1029 aic_of_ic_init() warn: 'regs' from of_iomap() not released on lines: 937,943.
vim +/start_off +980 drivers/irqchip/irq-apple-aic.c
b6ca556c352979 Marc Zyngier 2021-02-28 922
76cde26394114f Hector Martin 2021-01-21 923 static int __init aic_of_ic_init(struct device_node *node, struct device_node *parent)
76cde26394114f Hector Martin 2021-01-21 924 {
a801f0ee563b81 Hector Martin 2022-03-10 925 int i, die;
a801f0ee563b81 Hector Martin 2022-03-10 926 u32 off, start_off;
76cde26394114f Hector Martin 2021-01-21 927 void __iomem *regs;
76cde26394114f Hector Martin 2021-01-21 928 struct aic_irq_chip *irqc;
2cf68211664acd Hector Martin 2022-03-10 929 const struct of_device_id *match;
76cde26394114f Hector Martin 2021-01-21 930
76cde26394114f Hector Martin 2021-01-21 931 regs = of_iomap(node, 0);
76cde26394114f Hector Martin 2021-01-21 932 if (WARN_ON(!regs))
76cde26394114f Hector Martin 2021-01-21 933 return -EIO;
76cde26394114f Hector Martin 2021-01-21 934
76cde26394114f Hector Martin 2021-01-21 935 irqc = kzalloc(sizeof(*irqc), GFP_KERNEL);
76cde26394114f Hector Martin 2021-01-21 936 if (!irqc)
76cde26394114f Hector Martin 2021-01-21 937 return -ENOMEM;
76cde26394114f Hector Martin 2021-01-21 938
76cde26394114f Hector Martin 2021-01-21 939 irqc->base = regs;
76cde26394114f Hector Martin 2021-01-21 940
2cf68211664acd Hector Martin 2022-03-10 941 match = of_match_node(aic_info_match, node);
2cf68211664acd Hector Martin 2022-03-10 942 if (!match)
2cf68211664acd Hector Martin 2022-03-10 943 return -ENODEV;
2cf68211664acd Hector Martin 2022-03-10 944
2cf68211664acd Hector Martin 2022-03-10 945 irqc->info = *(struct aic_info *)match->data;
2cf68211664acd Hector Martin 2022-03-10 946
2cf68211664acd Hector Martin 2022-03-10 947 aic_irqc = irqc;
2cf68211664acd Hector Martin 2022-03-10 948
dc97fd6fec0099 Hector Martin 2022-03-10 949 switch (irqc->info.version) {
dc97fd6fec0099 Hector Martin 2022-03-10 950 case 1: {
dc97fd6fec0099 Hector Martin 2022-03-10 951 u32 info;
dc97fd6fec0099 Hector Martin 2022-03-10 952
76cde26394114f Hector Martin 2021-01-21 953 info = aic_ic_read(irqc, AIC_INFO);
7c841f5f6fa3f9 Hector Martin 2022-03-10 954 irqc->nr_irq = FIELD_GET(AIC_INFO_NR_IRQ, info);
dc97fd6fec0099 Hector Martin 2022-03-10 955 irqc->max_irq = AIC_MAX_IRQ;
a801f0ee563b81 Hector Martin 2022-03-10 956 irqc->nr_die = irqc->max_die = 1;
dc97fd6fec0099 Hector Martin 2022-03-10 957
a801f0ee563b81 Hector Martin 2022-03-10 958 off = start_off = irqc->info.target_cpu;
dc97fd6fec0099 Hector Martin 2022-03-10 959 off += sizeof(u32) * irqc->max_irq; /* TARGET_CPU */
dc97fd6fec0099 Hector Martin 2022-03-10 960
dc97fd6fec0099 Hector Martin 2022-03-10 961 break;
dc97fd6fec0099 Hector Martin 2022-03-10 962 }
dc97fd6fec0099 Hector Martin 2022-03-10 963 }
dc97fd6fec0099 Hector Martin 2022-03-10 964
dc97fd6fec0099 Hector Martin 2022-03-10 965 irqc->info.sw_set = off;
dc97fd6fec0099 Hector Martin 2022-03-10 966 off += sizeof(u32) * (irqc->max_irq >> 5); /* SW_SET */
dc97fd6fec0099 Hector Martin 2022-03-10 967 irqc->info.sw_clr = off;
dc97fd6fec0099 Hector Martin 2022-03-10 968 off += sizeof(u32) * (irqc->max_irq >> 5); /* SW_CLR */
dc97fd6fec0099 Hector Martin 2022-03-10 969 irqc->info.mask_set = off;
dc97fd6fec0099 Hector Martin 2022-03-10 970 off += sizeof(u32) * (irqc->max_irq >> 5); /* MASK_SET */
dc97fd6fec0099 Hector Martin 2022-03-10 971 irqc->info.mask_clr = off;
dc97fd6fec0099 Hector Martin 2022-03-10 972 off += sizeof(u32) * (irqc->max_irq >> 5); /* MASK_CLR */
dc97fd6fec0099 Hector Martin 2022-03-10 973 off += sizeof(u32) * (irqc->max_irq >> 5); /* HW_STATE */
76cde26394114f Hector Martin 2021-01-21 974
2cf68211664acd Hector Martin 2022-03-10 975 if (irqc->info.fast_ipi)
2cf68211664acd Hector Martin 2022-03-10 976 static_branch_enable(&use_fast_ipi);
2cf68211664acd Hector Martin 2022-03-10 977 else
2cf68211664acd Hector Martin 2022-03-10 978 static_branch_disable(&use_fast_ipi);
2cf68211664acd Hector Martin 2022-03-10 979
a801f0ee563b81 Hector Martin 2022-03-10 @980 irqc->info.die_stride = off - start_off;
a801f0ee563b81 Hector Martin 2022-03-10 981
7c841f5f6fa3f9 Hector Martin 2022-03-10 982 irqc->hw_domain = irq_domain_create_tree(of_node_to_fwnode(node),
76cde26394114f Hector Martin 2021-01-21 983 &aic_irq_domain_ops, irqc);
76cde26394114f Hector Martin 2021-01-21 984 if (WARN_ON(!irqc->hw_domain)) {
76cde26394114f Hector Martin 2021-01-21 985 iounmap(irqc->base);
76cde26394114f Hector Martin 2021-01-21 986 kfree(irqc);
76cde26394114f Hector Martin 2021-01-21 987 return -ENODEV;
76cde26394114f Hector Martin 2021-01-21 988 }
76cde26394114f Hector Martin 2021-01-21 989
76cde26394114f Hector Martin 2021-01-21 990 irq_domain_update_bus_token(irqc->hw_domain, DOMAIN_BUS_WIRED);
76cde26394114f Hector Martin 2021-01-21 991
76cde26394114f Hector Martin 2021-01-21 992 if (aic_init_smp(irqc, node)) {
76cde26394114f Hector Martin 2021-01-21 993 irq_domain_remove(irqc->hw_domain);
76cde26394114f Hector Martin 2021-01-21 994 iounmap(irqc->base);
76cde26394114f Hector Martin 2021-01-21 995 kfree(irqc);
76cde26394114f Hector Martin 2021-01-21 996 return -ENODEV;
76cde26394114f Hector Martin 2021-01-21 997 }
76cde26394114f Hector Martin 2021-01-21 998
76cde26394114f Hector Martin 2021-01-21 999 set_handle_irq(aic_handle_irq);
76cde26394114f Hector Martin 2021-01-21 1000 set_handle_fiq(aic_handle_fiq);
76cde26394114f Hector Martin 2021-01-21 1001
a801f0ee563b81 Hector Martin 2022-03-10 1002 off = 0;
a801f0ee563b81 Hector Martin 2022-03-10 1003 for (die = 0; die < irqc->nr_die; die++) {
7c841f5f6fa3f9 Hector Martin 2022-03-10 1004 for (i = 0; i < BITS_TO_U32(irqc->nr_irq); i++)
a801f0ee563b81 Hector Martin 2022-03-10 1005 aic_ic_write(irqc, irqc->info.mask_set + off + i * 4, U32_MAX);
7c841f5f6fa3f9 Hector Martin 2022-03-10 1006 for (i = 0; i < BITS_TO_U32(irqc->nr_irq); i++)
a801f0ee563b81 Hector Martin 2022-03-10 1007 aic_ic_write(irqc, irqc->info.sw_clr + off + i * 4, U32_MAX);
a801f0ee563b81 Hector Martin 2022-03-10 1008 if (irqc->info.target_cpu)
7c841f5f6fa3f9 Hector Martin 2022-03-10 1009 for (i = 0; i < irqc->nr_irq; i++)
a801f0ee563b81 Hector Martin 2022-03-10 1010 aic_ic_write(irqc, irqc->info.target_cpu + off + i * 4, 1);
a801f0ee563b81 Hector Martin 2022-03-10 1011 off += irqc->info.die_stride;
a801f0ee563b81 Hector Martin 2022-03-10 1012 }
76cde26394114f Hector Martin 2021-01-21 1013
76cde26394114f Hector Martin 2021-01-21 1014 if (!is_kernel_in_hyp_mode())
76cde26394114f Hector Martin 2021-01-21 1015 pr_info("Kernel running in EL1, mapping interrupts");
76cde26394114f Hector Martin 2021-01-21 1016
2cf68211664acd Hector Martin 2022-03-10 1017 if (static_branch_likely(&use_fast_ipi))
2cf68211664acd Hector Martin 2022-03-10 1018 pr_info("Using Fast IPIs");
2cf68211664acd Hector Martin 2022-03-10 1019
76cde26394114f Hector Martin 2021-01-21 1020 cpuhp_setup_state(CPUHP_AP_IRQ_APPLE_AIC_STARTING,
76cde26394114f Hector Martin 2021-01-21 1021 "irqchip/apple-aic/ipi:starting",
76cde26394114f Hector Martin 2021-01-21 1022 aic_init_cpu, NULL);
76cde26394114f Hector Martin 2021-01-21 1023
b6ca556c352979 Marc Zyngier 2021-02-28 1024 vgic_set_kvm_info(&vgic_info);
b6ca556c352979 Marc Zyngier 2021-02-28 1025
a801f0ee563b81 Hector Martin 2022-03-10 1026 pr_info("Initialized with %d/%d IRQs * %d/%d die(s), %d FIQs, %d vIPIs",
a801f0ee563b81 Hector Martin 2022-03-10 1027 irqc->nr_irq, irqc->max_irq, irqc->nr_die, irqc->max_die, AIC_NR_FIQ, AIC_NR_SWIPI);
76cde26394114f Hector Martin 2021-01-21 1028
76cde26394114f Hector Martin 2021-01-21 1029 return 0;
76cde26394114f Hector Martin 2021-01-21 1030 }
76cde26394114f Hector Martin 2021-01-21 1031
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] 7+ messages in thread
* drivers/irqchip/irq-apple-aic.c:980 aic_of_ic_init() error: uninitialized symbol 'start_off'.
@ 2022-06-04 5:31 kernel test robot
0 siblings, 0 replies; 7+ messages in thread
From: kernel test robot @ 2022-06-04 5:31 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 9454 bytes --]
CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: linux-kernel(a)vger.kernel.org
TO: Hector Martin <marcan@marcan.st>
CC: Marc Zyngier <maz@kernel.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 032dcf09e2bf7c822be25b4abef7a6c913870d98
commit: a801f0ee563b8180caf186493806a145a75b4a3c irqchip/apple-aic: Support multiple dies
date: 3 months ago
:::::: branch date: 2 hours ago
:::::: commit date: 3 months ago
config: arm64-randconfig-m031-20220530 (https://download.01.org/0day-ci/archive/20220604/202206041300.b8BwT9Np-lkp(a)intel.com/config)
compiler: aarch64-linux-gcc (GCC) 11.3.0
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/irqchip/irq-apple-aic.c:980 aic_of_ic_init() error: uninitialized symbol 'start_off'.
Old smatch warnings:
drivers/irqchip/irq-apple-aic.c:943 aic_of_ic_init() warn: possible memory leak of 'irqc'
drivers/irqchip/irq-apple-aic.c:965 aic_of_ic_init() error: uninitialized symbol 'off'.
drivers/irqchip/irq-apple-aic.c:1029 aic_of_ic_init() warn: 'regs' from of_iomap() not released on lines: 937,943.
vim +/start_off +980 drivers/irqchip/irq-apple-aic.c
b6ca556c352979 Marc Zyngier 2021-02-28 922
76cde26394114f Hector Martin 2021-01-21 923 static int __init aic_of_ic_init(struct device_node *node, struct device_node *parent)
76cde26394114f Hector Martin 2021-01-21 924 {
a801f0ee563b81 Hector Martin 2022-03-10 925 int i, die;
a801f0ee563b81 Hector Martin 2022-03-10 926 u32 off, start_off;
76cde26394114f Hector Martin 2021-01-21 927 void __iomem *regs;
76cde26394114f Hector Martin 2021-01-21 928 struct aic_irq_chip *irqc;
2cf68211664acd Hector Martin 2022-03-10 929 const struct of_device_id *match;
76cde26394114f Hector Martin 2021-01-21 930
76cde26394114f Hector Martin 2021-01-21 931 regs = of_iomap(node, 0);
76cde26394114f Hector Martin 2021-01-21 932 if (WARN_ON(!regs))
76cde26394114f Hector Martin 2021-01-21 933 return -EIO;
76cde26394114f Hector Martin 2021-01-21 934
76cde26394114f Hector Martin 2021-01-21 935 irqc = kzalloc(sizeof(*irqc), GFP_KERNEL);
76cde26394114f Hector Martin 2021-01-21 936 if (!irqc)
76cde26394114f Hector Martin 2021-01-21 937 return -ENOMEM;
76cde26394114f Hector Martin 2021-01-21 938
76cde26394114f Hector Martin 2021-01-21 939 irqc->base = regs;
76cde26394114f Hector Martin 2021-01-21 940
2cf68211664acd Hector Martin 2022-03-10 941 match = of_match_node(aic_info_match, node);
2cf68211664acd Hector Martin 2022-03-10 942 if (!match)
2cf68211664acd Hector Martin 2022-03-10 943 return -ENODEV;
2cf68211664acd Hector Martin 2022-03-10 944
2cf68211664acd Hector Martin 2022-03-10 945 irqc->info = *(struct aic_info *)match->data;
2cf68211664acd Hector Martin 2022-03-10 946
2cf68211664acd Hector Martin 2022-03-10 947 aic_irqc = irqc;
2cf68211664acd Hector Martin 2022-03-10 948
dc97fd6fec0099 Hector Martin 2022-03-10 949 switch (irqc->info.version) {
dc97fd6fec0099 Hector Martin 2022-03-10 950 case 1: {
dc97fd6fec0099 Hector Martin 2022-03-10 951 u32 info;
dc97fd6fec0099 Hector Martin 2022-03-10 952
76cde26394114f Hector Martin 2021-01-21 953 info = aic_ic_read(irqc, AIC_INFO);
7c841f5f6fa3f9 Hector Martin 2022-03-10 954 irqc->nr_irq = FIELD_GET(AIC_INFO_NR_IRQ, info);
dc97fd6fec0099 Hector Martin 2022-03-10 955 irqc->max_irq = AIC_MAX_IRQ;
a801f0ee563b81 Hector Martin 2022-03-10 956 irqc->nr_die = irqc->max_die = 1;
dc97fd6fec0099 Hector Martin 2022-03-10 957
a801f0ee563b81 Hector Martin 2022-03-10 958 off = start_off = irqc->info.target_cpu;
dc97fd6fec0099 Hector Martin 2022-03-10 959 off += sizeof(u32) * irqc->max_irq; /* TARGET_CPU */
dc97fd6fec0099 Hector Martin 2022-03-10 960
dc97fd6fec0099 Hector Martin 2022-03-10 961 break;
dc97fd6fec0099 Hector Martin 2022-03-10 962 }
dc97fd6fec0099 Hector Martin 2022-03-10 963 }
dc97fd6fec0099 Hector Martin 2022-03-10 964
dc97fd6fec0099 Hector Martin 2022-03-10 965 irqc->info.sw_set = off;
dc97fd6fec0099 Hector Martin 2022-03-10 966 off += sizeof(u32) * (irqc->max_irq >> 5); /* SW_SET */
dc97fd6fec0099 Hector Martin 2022-03-10 967 irqc->info.sw_clr = off;
dc97fd6fec0099 Hector Martin 2022-03-10 968 off += sizeof(u32) * (irqc->max_irq >> 5); /* SW_CLR */
dc97fd6fec0099 Hector Martin 2022-03-10 969 irqc->info.mask_set = off;
dc97fd6fec0099 Hector Martin 2022-03-10 970 off += sizeof(u32) * (irqc->max_irq >> 5); /* MASK_SET */
dc97fd6fec0099 Hector Martin 2022-03-10 971 irqc->info.mask_clr = off;
dc97fd6fec0099 Hector Martin 2022-03-10 972 off += sizeof(u32) * (irqc->max_irq >> 5); /* MASK_CLR */
dc97fd6fec0099 Hector Martin 2022-03-10 973 off += sizeof(u32) * (irqc->max_irq >> 5); /* HW_STATE */
76cde26394114f Hector Martin 2021-01-21 974
2cf68211664acd Hector Martin 2022-03-10 975 if (irqc->info.fast_ipi)
2cf68211664acd Hector Martin 2022-03-10 976 static_branch_enable(&use_fast_ipi);
2cf68211664acd Hector Martin 2022-03-10 977 else
2cf68211664acd Hector Martin 2022-03-10 978 static_branch_disable(&use_fast_ipi);
2cf68211664acd Hector Martin 2022-03-10 979
a801f0ee563b81 Hector Martin 2022-03-10 @980 irqc->info.die_stride = off - start_off;
a801f0ee563b81 Hector Martin 2022-03-10 981
7c841f5f6fa3f9 Hector Martin 2022-03-10 982 irqc->hw_domain = irq_domain_create_tree(of_node_to_fwnode(node),
76cde26394114f Hector Martin 2021-01-21 983 &aic_irq_domain_ops, irqc);
76cde26394114f Hector Martin 2021-01-21 984 if (WARN_ON(!irqc->hw_domain)) {
76cde26394114f Hector Martin 2021-01-21 985 iounmap(irqc->base);
76cde26394114f Hector Martin 2021-01-21 986 kfree(irqc);
76cde26394114f Hector Martin 2021-01-21 987 return -ENODEV;
76cde26394114f Hector Martin 2021-01-21 988 }
76cde26394114f Hector Martin 2021-01-21 989
76cde26394114f Hector Martin 2021-01-21 990 irq_domain_update_bus_token(irqc->hw_domain, DOMAIN_BUS_WIRED);
76cde26394114f Hector Martin 2021-01-21 991
76cde26394114f Hector Martin 2021-01-21 992 if (aic_init_smp(irqc, node)) {
76cde26394114f Hector Martin 2021-01-21 993 irq_domain_remove(irqc->hw_domain);
76cde26394114f Hector Martin 2021-01-21 994 iounmap(irqc->base);
76cde26394114f Hector Martin 2021-01-21 995 kfree(irqc);
76cde26394114f Hector Martin 2021-01-21 996 return -ENODEV;
76cde26394114f Hector Martin 2021-01-21 997 }
76cde26394114f Hector Martin 2021-01-21 998
76cde26394114f Hector Martin 2021-01-21 999 set_handle_irq(aic_handle_irq);
76cde26394114f Hector Martin 2021-01-21 1000 set_handle_fiq(aic_handle_fiq);
76cde26394114f Hector Martin 2021-01-21 1001
a801f0ee563b81 Hector Martin 2022-03-10 1002 off = 0;
a801f0ee563b81 Hector Martin 2022-03-10 1003 for (die = 0; die < irqc->nr_die; die++) {
7c841f5f6fa3f9 Hector Martin 2022-03-10 1004 for (i = 0; i < BITS_TO_U32(irqc->nr_irq); i++)
a801f0ee563b81 Hector Martin 2022-03-10 1005 aic_ic_write(irqc, irqc->info.mask_set + off + i * 4, U32_MAX);
7c841f5f6fa3f9 Hector Martin 2022-03-10 1006 for (i = 0; i < BITS_TO_U32(irqc->nr_irq); i++)
a801f0ee563b81 Hector Martin 2022-03-10 1007 aic_ic_write(irqc, irqc->info.sw_clr + off + i * 4, U32_MAX);
a801f0ee563b81 Hector Martin 2022-03-10 1008 if (irqc->info.target_cpu)
7c841f5f6fa3f9 Hector Martin 2022-03-10 1009 for (i = 0; i < irqc->nr_irq; i++)
a801f0ee563b81 Hector Martin 2022-03-10 1010 aic_ic_write(irqc, irqc->info.target_cpu + off + i * 4, 1);
a801f0ee563b81 Hector Martin 2022-03-10 1011 off += irqc->info.die_stride;
a801f0ee563b81 Hector Martin 2022-03-10 1012 }
76cde26394114f Hector Martin 2021-01-21 1013
76cde26394114f Hector Martin 2021-01-21 1014 if (!is_kernel_in_hyp_mode())
76cde26394114f Hector Martin 2021-01-21 1015 pr_info("Kernel running in EL1, mapping interrupts");
76cde26394114f Hector Martin 2021-01-21 1016
2cf68211664acd Hector Martin 2022-03-10 1017 if (static_branch_likely(&use_fast_ipi))
2cf68211664acd Hector Martin 2022-03-10 1018 pr_info("Using Fast IPIs");
2cf68211664acd Hector Martin 2022-03-10 1019
76cde26394114f Hector Martin 2021-01-21 1020 cpuhp_setup_state(CPUHP_AP_IRQ_APPLE_AIC_STARTING,
76cde26394114f Hector Martin 2021-01-21 1021 "irqchip/apple-aic/ipi:starting",
76cde26394114f Hector Martin 2021-01-21 1022 aic_init_cpu, NULL);
76cde26394114f Hector Martin 2021-01-21 1023
b6ca556c352979 Marc Zyngier 2021-02-28 1024 vgic_set_kvm_info(&vgic_info);
b6ca556c352979 Marc Zyngier 2021-02-28 1025
a801f0ee563b81 Hector Martin 2022-03-10 1026 pr_info("Initialized with %d/%d IRQs * %d/%d die(s), %d FIQs, %d vIPIs",
a801f0ee563b81 Hector Martin 2022-03-10 1027 irqc->nr_irq, irqc->max_irq, irqc->nr_die, irqc->max_die, AIC_NR_FIQ, AIC_NR_SWIPI);
76cde26394114f Hector Martin 2021-01-21 1028
76cde26394114f Hector Martin 2021-01-21 1029 return 0;
76cde26394114f Hector Martin 2021-01-21 1030 }
76cde26394114f Hector Martin 2021-01-21 1031
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] 7+ messages in thread
* drivers/irqchip/irq-apple-aic.c:980 aic_of_ic_init() error: uninitialized symbol 'start_off'.
@ 2022-06-06 11:18 ` Dan Carpenter
0 siblings, 0 replies; 7+ messages in thread
From: Dan Carpenter @ 2022-06-06 11:18 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 9433 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 700170bf6b4d773e328fa54ebb70ba444007c702
commit: a801f0ee563b8180caf186493806a145a75b4a3c irqchip/apple-aic: Support multiple dies
config: arm64-randconfig-m031-20220530 (https://download.01.org/0day-ci/archive/20220601/202206011052.du9opGWF-lkp(a)intel.com/config)
compiler: aarch64-linux-gcc (GCC) 11.3.0
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/irqchip/irq-apple-aic.c:980 aic_of_ic_init() error: uninitialized symbol 'start_off'.
Old smatch warnings:
drivers/irqchip/irq-apple-aic.c:943 aic_of_ic_init() warn: possible memory leak of 'irqc'
drivers/irqchip/irq-apple-aic.c:965 aic_of_ic_init() error: uninitialized symbol 'off'.
drivers/irqchip/irq-apple-aic.c:1029 aic_of_ic_init() warn: 'regs' from of_iomap() not released on lines: 937,943.
vim +/start_off +980 drivers/irqchip/irq-apple-aic.c
76cde26394114f Hector Martin 2021-01-21 923 static int __init aic_of_ic_init(struct device_node *node, struct device_node *parent)
76cde26394114f Hector Martin 2021-01-21 924 {
a801f0ee563b81 Hector Martin 2022-03-10 925 int i, die;
a801f0ee563b81 Hector Martin 2022-03-10 926 u32 off, start_off;
76cde26394114f Hector Martin 2021-01-21 927 void __iomem *regs;
76cde26394114f Hector Martin 2021-01-21 928 struct aic_irq_chip *irqc;
2cf68211664acd Hector Martin 2022-03-10 929 const struct of_device_id *match;
76cde26394114f Hector Martin 2021-01-21 930
76cde26394114f Hector Martin 2021-01-21 931 regs = of_iomap(node, 0);
76cde26394114f Hector Martin 2021-01-21 932 if (WARN_ON(!regs))
76cde26394114f Hector Martin 2021-01-21 933 return -EIO;
76cde26394114f Hector Martin 2021-01-21 934
76cde26394114f Hector Martin 2021-01-21 935 irqc = kzalloc(sizeof(*irqc), GFP_KERNEL);
76cde26394114f Hector Martin 2021-01-21 936 if (!irqc)
76cde26394114f Hector Martin 2021-01-21 937 return -ENOMEM;
76cde26394114f Hector Martin 2021-01-21 938
76cde26394114f Hector Martin 2021-01-21 939 irqc->base = regs;
76cde26394114f Hector Martin 2021-01-21 940
2cf68211664acd Hector Martin 2022-03-10 941 match = of_match_node(aic_info_match, node);
2cf68211664acd Hector Martin 2022-03-10 942 if (!match)
2cf68211664acd Hector Martin 2022-03-10 943 return -ENODEV;
ret = -ENOMEM;
goto err_free_irqc;
2cf68211664acd Hector Martin 2022-03-10 944
2cf68211664acd Hector Martin 2022-03-10 945 irqc->info = *(struct aic_info *)match->data;
2cf68211664acd Hector Martin 2022-03-10 946
2cf68211664acd Hector Martin 2022-03-10 947 aic_irqc = irqc;
2cf68211664acd Hector Martin 2022-03-10 948
dc97fd6fec0099 Hector Martin 2022-03-10 949 switch (irqc->info.version) {
dc97fd6fec0099 Hector Martin 2022-03-10 950 case 1: {
dc97fd6fec0099 Hector Martin 2022-03-10 951 u32 info;
dc97fd6fec0099 Hector Martin 2022-03-10 952
76cde26394114f Hector Martin 2021-01-21 953 info = aic_ic_read(irqc, AIC_INFO);
7c841f5f6fa3f9 Hector Martin 2022-03-10 954 irqc->nr_irq = FIELD_GET(AIC_INFO_NR_IRQ, info);
dc97fd6fec0099 Hector Martin 2022-03-10 955 irqc->max_irq = AIC_MAX_IRQ;
a801f0ee563b81 Hector Martin 2022-03-10 956 irqc->nr_die = irqc->max_die = 1;
dc97fd6fec0099 Hector Martin 2022-03-10 957
a801f0ee563b81 Hector Martin 2022-03-10 958 off = start_off = irqc->info.target_cpu;
dc97fd6fec0099 Hector Martin 2022-03-10 959 off += sizeof(u32) * irqc->max_irq; /* TARGET_CPU */
dc97fd6fec0099 Hector Martin 2022-03-10 960
dc97fd6fec0099 Hector Martin 2022-03-10 961 break;
dc97fd6fec0099 Hector Martin 2022-03-10 962 }
dc97fd6fec0099 Hector Martin 2022-03-10 963 }
dc97fd6fec0099 Hector Martin 2022-03-10 964
dc97fd6fec0099 Hector Martin 2022-03-10 965 irqc->info.sw_set = off;
dc97fd6fec0099 Hector Martin 2022-03-10 966 off += sizeof(u32) * (irqc->max_irq >> 5); /* SW_SET */
dc97fd6fec0099 Hector Martin 2022-03-10 967 irqc->info.sw_clr = off;
dc97fd6fec0099 Hector Martin 2022-03-10 968 off += sizeof(u32) * (irqc->max_irq >> 5); /* SW_CLR */
dc97fd6fec0099 Hector Martin 2022-03-10 969 irqc->info.mask_set = off;
dc97fd6fec0099 Hector Martin 2022-03-10 970 off += sizeof(u32) * (irqc->max_irq >> 5); /* MASK_SET */
dc97fd6fec0099 Hector Martin 2022-03-10 971 irqc->info.mask_clr = off;
dc97fd6fec0099 Hector Martin 2022-03-10 972 off += sizeof(u32) * (irqc->max_irq >> 5); /* MASK_CLR */
dc97fd6fec0099 Hector Martin 2022-03-10 973 off += sizeof(u32) * (irqc->max_irq >> 5); /* HW_STATE */
76cde26394114f Hector Martin 2021-01-21 974
2cf68211664acd Hector Martin 2022-03-10 975 if (irqc->info.fast_ipi)
2cf68211664acd Hector Martin 2022-03-10 976 static_branch_enable(&use_fast_ipi);
2cf68211664acd Hector Martin 2022-03-10 977 else
2cf68211664acd Hector Martin 2022-03-10 978 static_branch_disable(&use_fast_ipi);
2cf68211664acd Hector Martin 2022-03-10 979
a801f0ee563b81 Hector Martin 2022-03-10 @980 irqc->info.die_stride = off - start_off;
a801f0ee563b81 Hector Martin 2022-03-10 981
7c841f5f6fa3f9 Hector Martin 2022-03-10 982 irqc->hw_domain = irq_domain_create_tree(of_node_to_fwnode(node),
76cde26394114f Hector Martin 2021-01-21 983 &aic_irq_domain_ops, irqc);
76cde26394114f Hector Martin 2021-01-21 984 if (WARN_ON(!irqc->hw_domain)) {
76cde26394114f Hector Martin 2021-01-21 985 iounmap(irqc->base);
76cde26394114f Hector Martin 2021-01-21 986 kfree(irqc);
76cde26394114f Hector Martin 2021-01-21 987 return -ENODEV;
ret = -ENODEV;
goto err_unmap;
76cde26394114f Hector Martin 2021-01-21 988 }
76cde26394114f Hector Martin 2021-01-21 989
76cde26394114f Hector Martin 2021-01-21 990 irq_domain_update_bus_token(irqc->hw_domain, DOMAIN_BUS_WIRED);
76cde26394114f Hector Martin 2021-01-21 991
76cde26394114f Hector Martin 2021-01-21 992 if (aic_init_smp(irqc, node)) {
76cde26394114f Hector Martin 2021-01-21 993 irq_domain_remove(irqc->hw_domain);
76cde26394114f Hector Martin 2021-01-21 994 iounmap(irqc->base);
76cde26394114f Hector Martin 2021-01-21 995 kfree(irqc);
76cde26394114f Hector Martin 2021-01-21 996 return -ENODEV;
ret = -ENODEV;
goto err_remove_domain;
76cde26394114f Hector Martin 2021-01-21 997 }
76cde26394114f Hector Martin 2021-01-21 998
76cde26394114f Hector Martin 2021-01-21 999 set_handle_irq(aic_handle_irq);
76cde26394114f Hector Martin 2021-01-21 1000 set_handle_fiq(aic_handle_fiq);
76cde26394114f Hector Martin 2021-01-21 1001
a801f0ee563b81 Hector Martin 2022-03-10 1002 off = 0;
a801f0ee563b81 Hector Martin 2022-03-10 1003 for (die = 0; die < irqc->nr_die; die++) {
7c841f5f6fa3f9 Hector Martin 2022-03-10 1004 for (i = 0; i < BITS_TO_U32(irqc->nr_irq); i++)
a801f0ee563b81 Hector Martin 2022-03-10 1005 aic_ic_write(irqc, irqc->info.mask_set + off + i * 4, U32_MAX);
7c841f5f6fa3f9 Hector Martin 2022-03-10 1006 for (i = 0; i < BITS_TO_U32(irqc->nr_irq); i++)
a801f0ee563b81 Hector Martin 2022-03-10 1007 aic_ic_write(irqc, irqc->info.sw_clr + off + i * 4, U32_MAX);
a801f0ee563b81 Hector Martin 2022-03-10 1008 if (irqc->info.target_cpu)
7c841f5f6fa3f9 Hector Martin 2022-03-10 1009 for (i = 0; i < irqc->nr_irq; i++)
a801f0ee563b81 Hector Martin 2022-03-10 1010 aic_ic_write(irqc, irqc->info.target_cpu + off + i * 4, 1);
a801f0ee563b81 Hector Martin 2022-03-10 1011 off += irqc->info.die_stride;
a801f0ee563b81 Hector Martin 2022-03-10 1012 }
76cde26394114f Hector Martin 2021-01-21 1013
76cde26394114f Hector Martin 2021-01-21 1014 if (!is_kernel_in_hyp_mode())
76cde26394114f Hector Martin 2021-01-21 1015 pr_info("Kernel running in EL1, mapping interrupts");
76cde26394114f Hector Martin 2021-01-21 1016
2cf68211664acd Hector Martin 2022-03-10 1017 if (static_branch_likely(&use_fast_ipi))
2cf68211664acd Hector Martin 2022-03-10 1018 pr_info("Using Fast IPIs");
2cf68211664acd Hector Martin 2022-03-10 1019
76cde26394114f Hector Martin 2021-01-21 1020 cpuhp_setup_state(CPUHP_AP_IRQ_APPLE_AIC_STARTING,
76cde26394114f Hector Martin 2021-01-21 1021 "irqchip/apple-aic/ipi:starting",
76cde26394114f Hector Martin 2021-01-21 1022 aic_init_cpu, NULL);
76cde26394114f Hector Martin 2021-01-21 1023
b6ca556c352979 Marc Zyngier 2021-02-28 1024 vgic_set_kvm_info(&vgic_info);
b6ca556c352979 Marc Zyngier 2021-02-28 1025
a801f0ee563b81 Hector Martin 2022-03-10 1026 pr_info("Initialized with %d/%d IRQs * %d/%d die(s), %d FIQs, %d vIPIs",
a801f0ee563b81 Hector Martin 2022-03-10 1027 irqc->nr_irq, irqc->max_irq, irqc->nr_die, irqc->max_die, AIC_NR_FIQ, AIC_NR_SWIPI);
76cde26394114f Hector Martin 2021-01-21 1028
76cde26394114f Hector Martin 2021-01-21 1029 return 0;
return 0;
err_remove_domain:
irq_domain_remove(irqc->hw_domain);
err_unmap:
iounmap(irqc->base);
err_free_irqc:
kfree(irqc);
return ret;
76cde26394114f Hector Martin 2021-01-21 1030 }
76cde26394114f Hector Martin 2021-01-21 1031
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] 7+ messages in thread
* drivers/irqchip/irq-apple-aic.c:980 aic_of_ic_init() error: uninitialized symbol 'start_off'.
@ 2022-06-06 11:18 ` Dan Carpenter
0 siblings, 0 replies; 7+ messages in thread
From: Dan Carpenter @ 2022-06-06 11:18 UTC (permalink / raw)
To: kbuild, Hector Martin; +Cc: lkp, kbuild-all, linux-kernel, Marc Zyngier
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 700170bf6b4d773e328fa54ebb70ba444007c702
commit: a801f0ee563b8180caf186493806a145a75b4a3c irqchip/apple-aic: Support multiple dies
config: arm64-randconfig-m031-20220530 (https://download.01.org/0day-ci/archive/20220601/202206011052.du9opGWF-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 11.3.0
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/irqchip/irq-apple-aic.c:980 aic_of_ic_init() error: uninitialized symbol 'start_off'.
Old smatch warnings:
drivers/irqchip/irq-apple-aic.c:943 aic_of_ic_init() warn: possible memory leak of 'irqc'
drivers/irqchip/irq-apple-aic.c:965 aic_of_ic_init() error: uninitialized symbol 'off'.
drivers/irqchip/irq-apple-aic.c:1029 aic_of_ic_init() warn: 'regs' from of_iomap() not released on lines: 937,943.
vim +/start_off +980 drivers/irqchip/irq-apple-aic.c
76cde26394114f Hector Martin 2021-01-21 923 static int __init aic_of_ic_init(struct device_node *node, struct device_node *parent)
76cde26394114f Hector Martin 2021-01-21 924 {
a801f0ee563b81 Hector Martin 2022-03-10 925 int i, die;
a801f0ee563b81 Hector Martin 2022-03-10 926 u32 off, start_off;
76cde26394114f Hector Martin 2021-01-21 927 void __iomem *regs;
76cde26394114f Hector Martin 2021-01-21 928 struct aic_irq_chip *irqc;
2cf68211664acd Hector Martin 2022-03-10 929 const struct of_device_id *match;
76cde26394114f Hector Martin 2021-01-21 930
76cde26394114f Hector Martin 2021-01-21 931 regs = of_iomap(node, 0);
76cde26394114f Hector Martin 2021-01-21 932 if (WARN_ON(!regs))
76cde26394114f Hector Martin 2021-01-21 933 return -EIO;
76cde26394114f Hector Martin 2021-01-21 934
76cde26394114f Hector Martin 2021-01-21 935 irqc = kzalloc(sizeof(*irqc), GFP_KERNEL);
76cde26394114f Hector Martin 2021-01-21 936 if (!irqc)
76cde26394114f Hector Martin 2021-01-21 937 return -ENOMEM;
76cde26394114f Hector Martin 2021-01-21 938
76cde26394114f Hector Martin 2021-01-21 939 irqc->base = regs;
76cde26394114f Hector Martin 2021-01-21 940
2cf68211664acd Hector Martin 2022-03-10 941 match = of_match_node(aic_info_match, node);
2cf68211664acd Hector Martin 2022-03-10 942 if (!match)
2cf68211664acd Hector Martin 2022-03-10 943 return -ENODEV;
ret = -ENOMEM;
goto err_free_irqc;
2cf68211664acd Hector Martin 2022-03-10 944
2cf68211664acd Hector Martin 2022-03-10 945 irqc->info = *(struct aic_info *)match->data;
2cf68211664acd Hector Martin 2022-03-10 946
2cf68211664acd Hector Martin 2022-03-10 947 aic_irqc = irqc;
2cf68211664acd Hector Martin 2022-03-10 948
dc97fd6fec0099 Hector Martin 2022-03-10 949 switch (irqc->info.version) {
dc97fd6fec0099 Hector Martin 2022-03-10 950 case 1: {
dc97fd6fec0099 Hector Martin 2022-03-10 951 u32 info;
dc97fd6fec0099 Hector Martin 2022-03-10 952
76cde26394114f Hector Martin 2021-01-21 953 info = aic_ic_read(irqc, AIC_INFO);
7c841f5f6fa3f9 Hector Martin 2022-03-10 954 irqc->nr_irq = FIELD_GET(AIC_INFO_NR_IRQ, info);
dc97fd6fec0099 Hector Martin 2022-03-10 955 irqc->max_irq = AIC_MAX_IRQ;
a801f0ee563b81 Hector Martin 2022-03-10 956 irqc->nr_die = irqc->max_die = 1;
dc97fd6fec0099 Hector Martin 2022-03-10 957
a801f0ee563b81 Hector Martin 2022-03-10 958 off = start_off = irqc->info.target_cpu;
dc97fd6fec0099 Hector Martin 2022-03-10 959 off += sizeof(u32) * irqc->max_irq; /* TARGET_CPU */
dc97fd6fec0099 Hector Martin 2022-03-10 960
dc97fd6fec0099 Hector Martin 2022-03-10 961 break;
dc97fd6fec0099 Hector Martin 2022-03-10 962 }
dc97fd6fec0099 Hector Martin 2022-03-10 963 }
dc97fd6fec0099 Hector Martin 2022-03-10 964
dc97fd6fec0099 Hector Martin 2022-03-10 965 irqc->info.sw_set = off;
dc97fd6fec0099 Hector Martin 2022-03-10 966 off += sizeof(u32) * (irqc->max_irq >> 5); /* SW_SET */
dc97fd6fec0099 Hector Martin 2022-03-10 967 irqc->info.sw_clr = off;
dc97fd6fec0099 Hector Martin 2022-03-10 968 off += sizeof(u32) * (irqc->max_irq >> 5); /* SW_CLR */
dc97fd6fec0099 Hector Martin 2022-03-10 969 irqc->info.mask_set = off;
dc97fd6fec0099 Hector Martin 2022-03-10 970 off += sizeof(u32) * (irqc->max_irq >> 5); /* MASK_SET */
dc97fd6fec0099 Hector Martin 2022-03-10 971 irqc->info.mask_clr = off;
dc97fd6fec0099 Hector Martin 2022-03-10 972 off += sizeof(u32) * (irqc->max_irq >> 5); /* MASK_CLR */
dc97fd6fec0099 Hector Martin 2022-03-10 973 off += sizeof(u32) * (irqc->max_irq >> 5); /* HW_STATE */
76cde26394114f Hector Martin 2021-01-21 974
2cf68211664acd Hector Martin 2022-03-10 975 if (irqc->info.fast_ipi)
2cf68211664acd Hector Martin 2022-03-10 976 static_branch_enable(&use_fast_ipi);
2cf68211664acd Hector Martin 2022-03-10 977 else
2cf68211664acd Hector Martin 2022-03-10 978 static_branch_disable(&use_fast_ipi);
2cf68211664acd Hector Martin 2022-03-10 979
a801f0ee563b81 Hector Martin 2022-03-10 @980 irqc->info.die_stride = off - start_off;
a801f0ee563b81 Hector Martin 2022-03-10 981
7c841f5f6fa3f9 Hector Martin 2022-03-10 982 irqc->hw_domain = irq_domain_create_tree(of_node_to_fwnode(node),
76cde26394114f Hector Martin 2021-01-21 983 &aic_irq_domain_ops, irqc);
76cde26394114f Hector Martin 2021-01-21 984 if (WARN_ON(!irqc->hw_domain)) {
76cde26394114f Hector Martin 2021-01-21 985 iounmap(irqc->base);
76cde26394114f Hector Martin 2021-01-21 986 kfree(irqc);
76cde26394114f Hector Martin 2021-01-21 987 return -ENODEV;
ret = -ENODEV;
goto err_unmap;
76cde26394114f Hector Martin 2021-01-21 988 }
76cde26394114f Hector Martin 2021-01-21 989
76cde26394114f Hector Martin 2021-01-21 990 irq_domain_update_bus_token(irqc->hw_domain, DOMAIN_BUS_WIRED);
76cde26394114f Hector Martin 2021-01-21 991
76cde26394114f Hector Martin 2021-01-21 992 if (aic_init_smp(irqc, node)) {
76cde26394114f Hector Martin 2021-01-21 993 irq_domain_remove(irqc->hw_domain);
76cde26394114f Hector Martin 2021-01-21 994 iounmap(irqc->base);
76cde26394114f Hector Martin 2021-01-21 995 kfree(irqc);
76cde26394114f Hector Martin 2021-01-21 996 return -ENODEV;
ret = -ENODEV;
goto err_remove_domain;
76cde26394114f Hector Martin 2021-01-21 997 }
76cde26394114f Hector Martin 2021-01-21 998
76cde26394114f Hector Martin 2021-01-21 999 set_handle_irq(aic_handle_irq);
76cde26394114f Hector Martin 2021-01-21 1000 set_handle_fiq(aic_handle_fiq);
76cde26394114f Hector Martin 2021-01-21 1001
a801f0ee563b81 Hector Martin 2022-03-10 1002 off = 0;
a801f0ee563b81 Hector Martin 2022-03-10 1003 for (die = 0; die < irqc->nr_die; die++) {
7c841f5f6fa3f9 Hector Martin 2022-03-10 1004 for (i = 0; i < BITS_TO_U32(irqc->nr_irq); i++)
a801f0ee563b81 Hector Martin 2022-03-10 1005 aic_ic_write(irqc, irqc->info.mask_set + off + i * 4, U32_MAX);
7c841f5f6fa3f9 Hector Martin 2022-03-10 1006 for (i = 0; i < BITS_TO_U32(irqc->nr_irq); i++)
a801f0ee563b81 Hector Martin 2022-03-10 1007 aic_ic_write(irqc, irqc->info.sw_clr + off + i * 4, U32_MAX);
a801f0ee563b81 Hector Martin 2022-03-10 1008 if (irqc->info.target_cpu)
7c841f5f6fa3f9 Hector Martin 2022-03-10 1009 for (i = 0; i < irqc->nr_irq; i++)
a801f0ee563b81 Hector Martin 2022-03-10 1010 aic_ic_write(irqc, irqc->info.target_cpu + off + i * 4, 1);
a801f0ee563b81 Hector Martin 2022-03-10 1011 off += irqc->info.die_stride;
a801f0ee563b81 Hector Martin 2022-03-10 1012 }
76cde26394114f Hector Martin 2021-01-21 1013
76cde26394114f Hector Martin 2021-01-21 1014 if (!is_kernel_in_hyp_mode())
76cde26394114f Hector Martin 2021-01-21 1015 pr_info("Kernel running in EL1, mapping interrupts");
76cde26394114f Hector Martin 2021-01-21 1016
2cf68211664acd Hector Martin 2022-03-10 1017 if (static_branch_likely(&use_fast_ipi))
2cf68211664acd Hector Martin 2022-03-10 1018 pr_info("Using Fast IPIs");
2cf68211664acd Hector Martin 2022-03-10 1019
76cde26394114f Hector Martin 2021-01-21 1020 cpuhp_setup_state(CPUHP_AP_IRQ_APPLE_AIC_STARTING,
76cde26394114f Hector Martin 2021-01-21 1021 "irqchip/apple-aic/ipi:starting",
76cde26394114f Hector Martin 2021-01-21 1022 aic_init_cpu, NULL);
76cde26394114f Hector Martin 2021-01-21 1023
b6ca556c352979 Marc Zyngier 2021-02-28 1024 vgic_set_kvm_info(&vgic_info);
b6ca556c352979 Marc Zyngier 2021-02-28 1025
a801f0ee563b81 Hector Martin 2022-03-10 1026 pr_info("Initialized with %d/%d IRQs * %d/%d die(s), %d FIQs, %d vIPIs",
a801f0ee563b81 Hector Martin 2022-03-10 1027 irqc->nr_irq, irqc->max_irq, irqc->nr_die, irqc->max_die, AIC_NR_FIQ, AIC_NR_SWIPI);
76cde26394114f Hector Martin 2021-01-21 1028
76cde26394114f Hector Martin 2021-01-21 1029 return 0;
return 0;
err_remove_domain:
irq_domain_remove(irqc->hw_domain);
err_unmap:
iounmap(irqc->base);
err_free_irqc:
kfree(irqc);
return ret;
76cde26394114f Hector Martin 2021-01-21 1030 }
76cde26394114f Hector Martin 2021-01-21 1031
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] 7+ messages in thread
* drivers/irqchip/irq-apple-aic.c:980 aic_of_ic_init() error: uninitialized symbol 'start_off'.
@ 2023-12-03 23:10 kernel test robot
0 siblings, 0 replies; 7+ messages in thread
From: kernel test robot @ 2023-12-03 23:10 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp, Dan Carpenter
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Hector Martin <marcan@marcan.st>
CC: Marc Zyngier <maz@kernel.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 33cc938e65a98f1d29d0a18403dbbee050dcad9a
commit: a801f0ee563b8180caf186493806a145a75b4a3c irqchip/apple-aic: Support multiple dies
date: 1 year, 9 months ago
:::::: branch date: 13 hours ago
:::::: commit date: 1 year, 9 months ago
config: arm64-randconfig-r081-20231127 (https://download.01.org/0day-ci/archive/20231204/202312040603.1rTP1WmL-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project.git f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce: (https://download.01.org/0day-ci/archive/20231204/202312040603.1rTP1WmL-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202312040603.1rTP1WmL-lkp@intel.com/
New smatch warnings:
drivers/irqchip/irq-apple-aic.c:980 aic_of_ic_init() error: uninitialized symbol 'start_off'.
Old smatch warnings:
drivers/irqchip/irq-apple-aic.c:943 aic_of_ic_init() warn: possible memory leak of 'irqc'
drivers/irqchip/irq-apple-aic.c:965 aic_of_ic_init() error: uninitialized symbol 'off'.
drivers/irqchip/irq-apple-aic.c:1029 aic_of_ic_init() warn: 'regs' from of_iomap() not released on lines: 937,943.
vim +/start_off +980 drivers/irqchip/irq-apple-aic.c
b6ca556c352979 Marc Zyngier 2021-02-28 922
76cde26394114f Hector Martin 2021-01-21 923 static int __init aic_of_ic_init(struct device_node *node, struct device_node *parent)
76cde26394114f Hector Martin 2021-01-21 924 {
a801f0ee563b81 Hector Martin 2022-03-10 925 int i, die;
a801f0ee563b81 Hector Martin 2022-03-10 926 u32 off, start_off;
76cde26394114f Hector Martin 2021-01-21 927 void __iomem *regs;
76cde26394114f Hector Martin 2021-01-21 928 struct aic_irq_chip *irqc;
2cf68211664acd Hector Martin 2022-03-10 929 const struct of_device_id *match;
76cde26394114f Hector Martin 2021-01-21 930
76cde26394114f Hector Martin 2021-01-21 931 regs = of_iomap(node, 0);
76cde26394114f Hector Martin 2021-01-21 932 if (WARN_ON(!regs))
76cde26394114f Hector Martin 2021-01-21 933 return -EIO;
76cde26394114f Hector Martin 2021-01-21 934
76cde26394114f Hector Martin 2021-01-21 935 irqc = kzalloc(sizeof(*irqc), GFP_KERNEL);
76cde26394114f Hector Martin 2021-01-21 936 if (!irqc)
76cde26394114f Hector Martin 2021-01-21 937 return -ENOMEM;
76cde26394114f Hector Martin 2021-01-21 938
76cde26394114f Hector Martin 2021-01-21 939 irqc->base = regs;
76cde26394114f Hector Martin 2021-01-21 940
2cf68211664acd Hector Martin 2022-03-10 941 match = of_match_node(aic_info_match, node);
2cf68211664acd Hector Martin 2022-03-10 942 if (!match)
2cf68211664acd Hector Martin 2022-03-10 943 return -ENODEV;
2cf68211664acd Hector Martin 2022-03-10 944
2cf68211664acd Hector Martin 2022-03-10 945 irqc->info = *(struct aic_info *)match->data;
2cf68211664acd Hector Martin 2022-03-10 946
2cf68211664acd Hector Martin 2022-03-10 947 aic_irqc = irqc;
2cf68211664acd Hector Martin 2022-03-10 948
dc97fd6fec0099 Hector Martin 2022-03-10 949 switch (irqc->info.version) {
dc97fd6fec0099 Hector Martin 2022-03-10 950 case 1: {
dc97fd6fec0099 Hector Martin 2022-03-10 951 u32 info;
dc97fd6fec0099 Hector Martin 2022-03-10 952
76cde26394114f Hector Martin 2021-01-21 953 info = aic_ic_read(irqc, AIC_INFO);
7c841f5f6fa3f9 Hector Martin 2022-03-10 954 irqc->nr_irq = FIELD_GET(AIC_INFO_NR_IRQ, info);
dc97fd6fec0099 Hector Martin 2022-03-10 955 irqc->max_irq = AIC_MAX_IRQ;
a801f0ee563b81 Hector Martin 2022-03-10 956 irqc->nr_die = irqc->max_die = 1;
dc97fd6fec0099 Hector Martin 2022-03-10 957
a801f0ee563b81 Hector Martin 2022-03-10 958 off = start_off = irqc->info.target_cpu;
dc97fd6fec0099 Hector Martin 2022-03-10 959 off += sizeof(u32) * irqc->max_irq; /* TARGET_CPU */
dc97fd6fec0099 Hector Martin 2022-03-10 960
dc97fd6fec0099 Hector Martin 2022-03-10 961 break;
dc97fd6fec0099 Hector Martin 2022-03-10 962 }
dc97fd6fec0099 Hector Martin 2022-03-10 963 }
dc97fd6fec0099 Hector Martin 2022-03-10 964
dc97fd6fec0099 Hector Martin 2022-03-10 965 irqc->info.sw_set = off;
dc97fd6fec0099 Hector Martin 2022-03-10 966 off += sizeof(u32) * (irqc->max_irq >> 5); /* SW_SET */
dc97fd6fec0099 Hector Martin 2022-03-10 967 irqc->info.sw_clr = off;
dc97fd6fec0099 Hector Martin 2022-03-10 968 off += sizeof(u32) * (irqc->max_irq >> 5); /* SW_CLR */
dc97fd6fec0099 Hector Martin 2022-03-10 969 irqc->info.mask_set = off;
dc97fd6fec0099 Hector Martin 2022-03-10 970 off += sizeof(u32) * (irqc->max_irq >> 5); /* MASK_SET */
dc97fd6fec0099 Hector Martin 2022-03-10 971 irqc->info.mask_clr = off;
dc97fd6fec0099 Hector Martin 2022-03-10 972 off += sizeof(u32) * (irqc->max_irq >> 5); /* MASK_CLR */
dc97fd6fec0099 Hector Martin 2022-03-10 973 off += sizeof(u32) * (irqc->max_irq >> 5); /* HW_STATE */
76cde26394114f Hector Martin 2021-01-21 974
2cf68211664acd Hector Martin 2022-03-10 975 if (irqc->info.fast_ipi)
2cf68211664acd Hector Martin 2022-03-10 976 static_branch_enable(&use_fast_ipi);
2cf68211664acd Hector Martin 2022-03-10 977 else
2cf68211664acd Hector Martin 2022-03-10 978 static_branch_disable(&use_fast_ipi);
2cf68211664acd Hector Martin 2022-03-10 979
a801f0ee563b81 Hector Martin 2022-03-10 @980 irqc->info.die_stride = off - start_off;
a801f0ee563b81 Hector Martin 2022-03-10 981
7c841f5f6fa3f9 Hector Martin 2022-03-10 982 irqc->hw_domain = irq_domain_create_tree(of_node_to_fwnode(node),
76cde26394114f Hector Martin 2021-01-21 983 &aic_irq_domain_ops, irqc);
76cde26394114f Hector Martin 2021-01-21 984 if (WARN_ON(!irqc->hw_domain)) {
76cde26394114f Hector Martin 2021-01-21 985 iounmap(irqc->base);
76cde26394114f Hector Martin 2021-01-21 986 kfree(irqc);
76cde26394114f Hector Martin 2021-01-21 987 return -ENODEV;
76cde26394114f Hector Martin 2021-01-21 988 }
76cde26394114f Hector Martin 2021-01-21 989
76cde26394114f Hector Martin 2021-01-21 990 irq_domain_update_bus_token(irqc->hw_domain, DOMAIN_BUS_WIRED);
76cde26394114f Hector Martin 2021-01-21 991
76cde26394114f Hector Martin 2021-01-21 992 if (aic_init_smp(irqc, node)) {
76cde26394114f Hector Martin 2021-01-21 993 irq_domain_remove(irqc->hw_domain);
76cde26394114f Hector Martin 2021-01-21 994 iounmap(irqc->base);
76cde26394114f Hector Martin 2021-01-21 995 kfree(irqc);
76cde26394114f Hector Martin 2021-01-21 996 return -ENODEV;
76cde26394114f Hector Martin 2021-01-21 997 }
76cde26394114f Hector Martin 2021-01-21 998
76cde26394114f Hector Martin 2021-01-21 999 set_handle_irq(aic_handle_irq);
76cde26394114f Hector Martin 2021-01-21 1000 set_handle_fiq(aic_handle_fiq);
76cde26394114f Hector Martin 2021-01-21 1001
a801f0ee563b81 Hector Martin 2022-03-10 1002 off = 0;
a801f0ee563b81 Hector Martin 2022-03-10 1003 for (die = 0; die < irqc->nr_die; die++) {
7c841f5f6fa3f9 Hector Martin 2022-03-10 1004 for (i = 0; i < BITS_TO_U32(irqc->nr_irq); i++)
a801f0ee563b81 Hector Martin 2022-03-10 1005 aic_ic_write(irqc, irqc->info.mask_set + off + i * 4, U32_MAX);
7c841f5f6fa3f9 Hector Martin 2022-03-10 1006 for (i = 0; i < BITS_TO_U32(irqc->nr_irq); i++)
a801f0ee563b81 Hector Martin 2022-03-10 1007 aic_ic_write(irqc, irqc->info.sw_clr + off + i * 4, U32_MAX);
a801f0ee563b81 Hector Martin 2022-03-10 1008 if (irqc->info.target_cpu)
7c841f5f6fa3f9 Hector Martin 2022-03-10 1009 for (i = 0; i < irqc->nr_irq; i++)
a801f0ee563b81 Hector Martin 2022-03-10 1010 aic_ic_write(irqc, irqc->info.target_cpu + off + i * 4, 1);
a801f0ee563b81 Hector Martin 2022-03-10 1011 off += irqc->info.die_stride;
a801f0ee563b81 Hector Martin 2022-03-10 1012 }
76cde26394114f Hector Martin 2021-01-21 1013
76cde26394114f Hector Martin 2021-01-21 1014 if (!is_kernel_in_hyp_mode())
76cde26394114f Hector Martin 2021-01-21 1015 pr_info("Kernel running in EL1, mapping interrupts");
76cde26394114f Hector Martin 2021-01-21 1016
2cf68211664acd Hector Martin 2022-03-10 1017 if (static_branch_likely(&use_fast_ipi))
2cf68211664acd Hector Martin 2022-03-10 1018 pr_info("Using Fast IPIs");
2cf68211664acd Hector Martin 2022-03-10 1019
76cde26394114f Hector Martin 2021-01-21 1020 cpuhp_setup_state(CPUHP_AP_IRQ_APPLE_AIC_STARTING,
76cde26394114f Hector Martin 2021-01-21 1021 "irqchip/apple-aic/ipi:starting",
76cde26394114f Hector Martin 2021-01-21 1022 aic_init_cpu, NULL);
76cde26394114f Hector Martin 2021-01-21 1023
b6ca556c352979 Marc Zyngier 2021-02-28 1024 vgic_set_kvm_info(&vgic_info);
b6ca556c352979 Marc Zyngier 2021-02-28 1025
a801f0ee563b81 Hector Martin 2022-03-10 1026 pr_info("Initialized with %d/%d IRQs * %d/%d die(s), %d FIQs, %d vIPIs",
a801f0ee563b81 Hector Martin 2022-03-10 1027 irqc->nr_irq, irqc->max_irq, irqc->nr_die, irqc->max_die, AIC_NR_FIQ, AIC_NR_SWIPI);
76cde26394114f Hector Martin 2021-01-21 1028
76cde26394114f Hector Martin 2021-01-21 1029 return 0;
76cde26394114f Hector Martin 2021-01-21 1030 }
76cde26394114f Hector Martin 2021-01-21 1031
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 7+ messages in thread
* drivers/irqchip/irq-apple-aic.c:980 aic_of_ic_init() error: uninitialized symbol 'start_off'.
@ 2023-12-08 2:02 kernel test robot
0 siblings, 0 replies; 7+ messages in thread
From: kernel test robot @ 2023-12-08 2:02 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp, Dan Carpenter
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Hector Martin <marcan@marcan.st>
CC: Marc Zyngier <maz@kernel.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 9ace34a8e446c1a566f3b0a3e0c4c483987e39a6
commit: a801f0ee563b8180caf186493806a145a75b4a3c irqchip/apple-aic: Support multiple dies
date: 1 year, 9 months ago
:::::: branch date: 5 hours ago
:::::: commit date: 1 year, 9 months ago
config: arm64-randconfig-r081-20231127 (https://download.01.org/0day-ci/archive/20231208/202312080934.tto3FemD-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project.git f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce: (https://download.01.org/0day-ci/archive/20231208/202312080934.tto3FemD-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202312080934.tto3FemD-lkp@intel.com/
New smatch warnings:
drivers/irqchip/irq-apple-aic.c:980 aic_of_ic_init() error: uninitialized symbol 'start_off'.
Old smatch warnings:
drivers/irqchip/irq-apple-aic.c:943 aic_of_ic_init() warn: possible memory leak of 'irqc'
drivers/irqchip/irq-apple-aic.c:965 aic_of_ic_init() error: uninitialized symbol 'off'.
drivers/irqchip/irq-apple-aic.c:1029 aic_of_ic_init() warn: 'regs' from of_iomap() not released on lines: 937,943.
vim +/start_off +980 drivers/irqchip/irq-apple-aic.c
b6ca556c352979 Marc Zyngier 2021-02-28 922
76cde26394114f Hector Martin 2021-01-21 923 static int __init aic_of_ic_init(struct device_node *node, struct device_node *parent)
76cde26394114f Hector Martin 2021-01-21 924 {
a801f0ee563b81 Hector Martin 2022-03-10 925 int i, die;
a801f0ee563b81 Hector Martin 2022-03-10 926 u32 off, start_off;
76cde26394114f Hector Martin 2021-01-21 927 void __iomem *regs;
76cde26394114f Hector Martin 2021-01-21 928 struct aic_irq_chip *irqc;
2cf68211664acd Hector Martin 2022-03-10 929 const struct of_device_id *match;
76cde26394114f Hector Martin 2021-01-21 930
76cde26394114f Hector Martin 2021-01-21 931 regs = of_iomap(node, 0);
76cde26394114f Hector Martin 2021-01-21 932 if (WARN_ON(!regs))
76cde26394114f Hector Martin 2021-01-21 933 return -EIO;
76cde26394114f Hector Martin 2021-01-21 934
76cde26394114f Hector Martin 2021-01-21 935 irqc = kzalloc(sizeof(*irqc), GFP_KERNEL);
76cde26394114f Hector Martin 2021-01-21 936 if (!irqc)
76cde26394114f Hector Martin 2021-01-21 937 return -ENOMEM;
76cde26394114f Hector Martin 2021-01-21 938
76cde26394114f Hector Martin 2021-01-21 939 irqc->base = regs;
76cde26394114f Hector Martin 2021-01-21 940
2cf68211664acd Hector Martin 2022-03-10 941 match = of_match_node(aic_info_match, node);
2cf68211664acd Hector Martin 2022-03-10 942 if (!match)
2cf68211664acd Hector Martin 2022-03-10 943 return -ENODEV;
2cf68211664acd Hector Martin 2022-03-10 944
2cf68211664acd Hector Martin 2022-03-10 945 irqc->info = *(struct aic_info *)match->data;
2cf68211664acd Hector Martin 2022-03-10 946
2cf68211664acd Hector Martin 2022-03-10 947 aic_irqc = irqc;
2cf68211664acd Hector Martin 2022-03-10 948
dc97fd6fec0099 Hector Martin 2022-03-10 949 switch (irqc->info.version) {
dc97fd6fec0099 Hector Martin 2022-03-10 950 case 1: {
dc97fd6fec0099 Hector Martin 2022-03-10 951 u32 info;
dc97fd6fec0099 Hector Martin 2022-03-10 952
76cde26394114f Hector Martin 2021-01-21 953 info = aic_ic_read(irqc, AIC_INFO);
7c841f5f6fa3f9 Hector Martin 2022-03-10 954 irqc->nr_irq = FIELD_GET(AIC_INFO_NR_IRQ, info);
dc97fd6fec0099 Hector Martin 2022-03-10 955 irqc->max_irq = AIC_MAX_IRQ;
a801f0ee563b81 Hector Martin 2022-03-10 956 irqc->nr_die = irqc->max_die = 1;
dc97fd6fec0099 Hector Martin 2022-03-10 957
a801f0ee563b81 Hector Martin 2022-03-10 958 off = start_off = irqc->info.target_cpu;
dc97fd6fec0099 Hector Martin 2022-03-10 959 off += sizeof(u32) * irqc->max_irq; /* TARGET_CPU */
dc97fd6fec0099 Hector Martin 2022-03-10 960
dc97fd6fec0099 Hector Martin 2022-03-10 961 break;
dc97fd6fec0099 Hector Martin 2022-03-10 962 }
dc97fd6fec0099 Hector Martin 2022-03-10 963 }
dc97fd6fec0099 Hector Martin 2022-03-10 964
dc97fd6fec0099 Hector Martin 2022-03-10 965 irqc->info.sw_set = off;
dc97fd6fec0099 Hector Martin 2022-03-10 966 off += sizeof(u32) * (irqc->max_irq >> 5); /* SW_SET */
dc97fd6fec0099 Hector Martin 2022-03-10 967 irqc->info.sw_clr = off;
dc97fd6fec0099 Hector Martin 2022-03-10 968 off += sizeof(u32) * (irqc->max_irq >> 5); /* SW_CLR */
dc97fd6fec0099 Hector Martin 2022-03-10 969 irqc->info.mask_set = off;
dc97fd6fec0099 Hector Martin 2022-03-10 970 off += sizeof(u32) * (irqc->max_irq >> 5); /* MASK_SET */
dc97fd6fec0099 Hector Martin 2022-03-10 971 irqc->info.mask_clr = off;
dc97fd6fec0099 Hector Martin 2022-03-10 972 off += sizeof(u32) * (irqc->max_irq >> 5); /* MASK_CLR */
dc97fd6fec0099 Hector Martin 2022-03-10 973 off += sizeof(u32) * (irqc->max_irq >> 5); /* HW_STATE */
76cde26394114f Hector Martin 2021-01-21 974
2cf68211664acd Hector Martin 2022-03-10 975 if (irqc->info.fast_ipi)
2cf68211664acd Hector Martin 2022-03-10 976 static_branch_enable(&use_fast_ipi);
2cf68211664acd Hector Martin 2022-03-10 977 else
2cf68211664acd Hector Martin 2022-03-10 978 static_branch_disable(&use_fast_ipi);
2cf68211664acd Hector Martin 2022-03-10 979
a801f0ee563b81 Hector Martin 2022-03-10 @980 irqc->info.die_stride = off - start_off;
a801f0ee563b81 Hector Martin 2022-03-10 981
7c841f5f6fa3f9 Hector Martin 2022-03-10 982 irqc->hw_domain = irq_domain_create_tree(of_node_to_fwnode(node),
76cde26394114f Hector Martin 2021-01-21 983 &aic_irq_domain_ops, irqc);
76cde26394114f Hector Martin 2021-01-21 984 if (WARN_ON(!irqc->hw_domain)) {
76cde26394114f Hector Martin 2021-01-21 985 iounmap(irqc->base);
76cde26394114f Hector Martin 2021-01-21 986 kfree(irqc);
76cde26394114f Hector Martin 2021-01-21 987 return -ENODEV;
76cde26394114f Hector Martin 2021-01-21 988 }
76cde26394114f Hector Martin 2021-01-21 989
76cde26394114f Hector Martin 2021-01-21 990 irq_domain_update_bus_token(irqc->hw_domain, DOMAIN_BUS_WIRED);
76cde26394114f Hector Martin 2021-01-21 991
76cde26394114f Hector Martin 2021-01-21 992 if (aic_init_smp(irqc, node)) {
76cde26394114f Hector Martin 2021-01-21 993 irq_domain_remove(irqc->hw_domain);
76cde26394114f Hector Martin 2021-01-21 994 iounmap(irqc->base);
76cde26394114f Hector Martin 2021-01-21 995 kfree(irqc);
76cde26394114f Hector Martin 2021-01-21 996 return -ENODEV;
76cde26394114f Hector Martin 2021-01-21 997 }
76cde26394114f Hector Martin 2021-01-21 998
76cde26394114f Hector Martin 2021-01-21 999 set_handle_irq(aic_handle_irq);
76cde26394114f Hector Martin 2021-01-21 1000 set_handle_fiq(aic_handle_fiq);
76cde26394114f Hector Martin 2021-01-21 1001
a801f0ee563b81 Hector Martin 2022-03-10 1002 off = 0;
a801f0ee563b81 Hector Martin 2022-03-10 1003 for (die = 0; die < irqc->nr_die; die++) {
7c841f5f6fa3f9 Hector Martin 2022-03-10 1004 for (i = 0; i < BITS_TO_U32(irqc->nr_irq); i++)
a801f0ee563b81 Hector Martin 2022-03-10 1005 aic_ic_write(irqc, irqc->info.mask_set + off + i * 4, U32_MAX);
7c841f5f6fa3f9 Hector Martin 2022-03-10 1006 for (i = 0; i < BITS_TO_U32(irqc->nr_irq); i++)
a801f0ee563b81 Hector Martin 2022-03-10 1007 aic_ic_write(irqc, irqc->info.sw_clr + off + i * 4, U32_MAX);
a801f0ee563b81 Hector Martin 2022-03-10 1008 if (irqc->info.target_cpu)
7c841f5f6fa3f9 Hector Martin 2022-03-10 1009 for (i = 0; i < irqc->nr_irq; i++)
a801f0ee563b81 Hector Martin 2022-03-10 1010 aic_ic_write(irqc, irqc->info.target_cpu + off + i * 4, 1);
a801f0ee563b81 Hector Martin 2022-03-10 1011 off += irqc->info.die_stride;
a801f0ee563b81 Hector Martin 2022-03-10 1012 }
76cde26394114f Hector Martin 2021-01-21 1013
76cde26394114f Hector Martin 2021-01-21 1014 if (!is_kernel_in_hyp_mode())
76cde26394114f Hector Martin 2021-01-21 1015 pr_info("Kernel running in EL1, mapping interrupts");
76cde26394114f Hector Martin 2021-01-21 1016
2cf68211664acd Hector Martin 2022-03-10 1017 if (static_branch_likely(&use_fast_ipi))
2cf68211664acd Hector Martin 2022-03-10 1018 pr_info("Using Fast IPIs");
2cf68211664acd Hector Martin 2022-03-10 1019
76cde26394114f Hector Martin 2021-01-21 1020 cpuhp_setup_state(CPUHP_AP_IRQ_APPLE_AIC_STARTING,
76cde26394114f Hector Martin 2021-01-21 1021 "irqchip/apple-aic/ipi:starting",
76cde26394114f Hector Martin 2021-01-21 1022 aic_init_cpu, NULL);
76cde26394114f Hector Martin 2021-01-21 1023
b6ca556c352979 Marc Zyngier 2021-02-28 1024 vgic_set_kvm_info(&vgic_info);
b6ca556c352979 Marc Zyngier 2021-02-28 1025
a801f0ee563b81 Hector Martin 2022-03-10 1026 pr_info("Initialized with %d/%d IRQs * %d/%d die(s), %d FIQs, %d vIPIs",
a801f0ee563b81 Hector Martin 2022-03-10 1027 irqc->nr_irq, irqc->max_irq, irqc->nr_die, irqc->max_die, AIC_NR_FIQ, AIC_NR_SWIPI);
76cde26394114f Hector Martin 2021-01-21 1028
76cde26394114f Hector Martin 2021-01-21 1029 return 0;
76cde26394114f Hector Martin 2021-01-21 1030 }
76cde26394114f Hector Martin 2021-01-21 1031
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 7+ messages in thread
* drivers/irqchip/irq-apple-aic.c:980 aic_of_ic_init() error: uninitialized symbol 'start_off'.
@ 2023-12-09 3:43 kernel test robot
0 siblings, 0 replies; 7+ messages in thread
From: kernel test robot @ 2023-12-09 3:43 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp, Dan Carpenter
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Hector Martin <marcan@marcan.st>
CC: Marc Zyngier <maz@kernel.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: f2e8a57ee9036c7d5443382b6c3c09b51a92ec7e
commit: a801f0ee563b8180caf186493806a145a75b4a3c irqchip/apple-aic: Support multiple dies
date: 1 year, 9 months ago
:::::: branch date: 7 hours ago
:::::: commit date: 1 year, 9 months ago
config: arm64-randconfig-r081-20231127 (https://download.01.org/0day-ci/archive/20231209/202312091120.v7TBktc7-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project.git f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce: (https://download.01.org/0day-ci/archive/20231209/202312091120.v7TBktc7-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202312091120.v7TBktc7-lkp@intel.com/
New smatch warnings:
drivers/irqchip/irq-apple-aic.c:980 aic_of_ic_init() error: uninitialized symbol 'start_off'.
Old smatch warnings:
drivers/irqchip/irq-apple-aic.c:943 aic_of_ic_init() warn: possible memory leak of 'irqc'
drivers/irqchip/irq-apple-aic.c:965 aic_of_ic_init() error: uninitialized symbol 'off'.
drivers/irqchip/irq-apple-aic.c:1029 aic_of_ic_init() warn: 'regs' from of_iomap() not released on lines: 937,943.
vim +/start_off +980 drivers/irqchip/irq-apple-aic.c
b6ca556c352979 Marc Zyngier 2021-02-28 922
76cde26394114f Hector Martin 2021-01-21 923 static int __init aic_of_ic_init(struct device_node *node, struct device_node *parent)
76cde26394114f Hector Martin 2021-01-21 924 {
a801f0ee563b81 Hector Martin 2022-03-10 925 int i, die;
a801f0ee563b81 Hector Martin 2022-03-10 926 u32 off, start_off;
76cde26394114f Hector Martin 2021-01-21 927 void __iomem *regs;
76cde26394114f Hector Martin 2021-01-21 928 struct aic_irq_chip *irqc;
2cf68211664acd Hector Martin 2022-03-10 929 const struct of_device_id *match;
76cde26394114f Hector Martin 2021-01-21 930
76cde26394114f Hector Martin 2021-01-21 931 regs = of_iomap(node, 0);
76cde26394114f Hector Martin 2021-01-21 932 if (WARN_ON(!regs))
76cde26394114f Hector Martin 2021-01-21 933 return -EIO;
76cde26394114f Hector Martin 2021-01-21 934
76cde26394114f Hector Martin 2021-01-21 935 irqc = kzalloc(sizeof(*irqc), GFP_KERNEL);
76cde26394114f Hector Martin 2021-01-21 936 if (!irqc)
76cde26394114f Hector Martin 2021-01-21 937 return -ENOMEM;
76cde26394114f Hector Martin 2021-01-21 938
76cde26394114f Hector Martin 2021-01-21 939 irqc->base = regs;
76cde26394114f Hector Martin 2021-01-21 940
2cf68211664acd Hector Martin 2022-03-10 941 match = of_match_node(aic_info_match, node);
2cf68211664acd Hector Martin 2022-03-10 942 if (!match)
2cf68211664acd Hector Martin 2022-03-10 943 return -ENODEV;
2cf68211664acd Hector Martin 2022-03-10 944
2cf68211664acd Hector Martin 2022-03-10 945 irqc->info = *(struct aic_info *)match->data;
2cf68211664acd Hector Martin 2022-03-10 946
2cf68211664acd Hector Martin 2022-03-10 947 aic_irqc = irqc;
2cf68211664acd Hector Martin 2022-03-10 948
dc97fd6fec0099 Hector Martin 2022-03-10 949 switch (irqc->info.version) {
dc97fd6fec0099 Hector Martin 2022-03-10 950 case 1: {
dc97fd6fec0099 Hector Martin 2022-03-10 951 u32 info;
dc97fd6fec0099 Hector Martin 2022-03-10 952
76cde26394114f Hector Martin 2021-01-21 953 info = aic_ic_read(irqc, AIC_INFO);
7c841f5f6fa3f9 Hector Martin 2022-03-10 954 irqc->nr_irq = FIELD_GET(AIC_INFO_NR_IRQ, info);
dc97fd6fec0099 Hector Martin 2022-03-10 955 irqc->max_irq = AIC_MAX_IRQ;
a801f0ee563b81 Hector Martin 2022-03-10 956 irqc->nr_die = irqc->max_die = 1;
dc97fd6fec0099 Hector Martin 2022-03-10 957
a801f0ee563b81 Hector Martin 2022-03-10 958 off = start_off = irqc->info.target_cpu;
dc97fd6fec0099 Hector Martin 2022-03-10 959 off += sizeof(u32) * irqc->max_irq; /* TARGET_CPU */
dc97fd6fec0099 Hector Martin 2022-03-10 960
dc97fd6fec0099 Hector Martin 2022-03-10 961 break;
dc97fd6fec0099 Hector Martin 2022-03-10 962 }
dc97fd6fec0099 Hector Martin 2022-03-10 963 }
dc97fd6fec0099 Hector Martin 2022-03-10 964
dc97fd6fec0099 Hector Martin 2022-03-10 965 irqc->info.sw_set = off;
dc97fd6fec0099 Hector Martin 2022-03-10 966 off += sizeof(u32) * (irqc->max_irq >> 5); /* SW_SET */
dc97fd6fec0099 Hector Martin 2022-03-10 967 irqc->info.sw_clr = off;
dc97fd6fec0099 Hector Martin 2022-03-10 968 off += sizeof(u32) * (irqc->max_irq >> 5); /* SW_CLR */
dc97fd6fec0099 Hector Martin 2022-03-10 969 irqc->info.mask_set = off;
dc97fd6fec0099 Hector Martin 2022-03-10 970 off += sizeof(u32) * (irqc->max_irq >> 5); /* MASK_SET */
dc97fd6fec0099 Hector Martin 2022-03-10 971 irqc->info.mask_clr = off;
dc97fd6fec0099 Hector Martin 2022-03-10 972 off += sizeof(u32) * (irqc->max_irq >> 5); /* MASK_CLR */
dc97fd6fec0099 Hector Martin 2022-03-10 973 off += sizeof(u32) * (irqc->max_irq >> 5); /* HW_STATE */
76cde26394114f Hector Martin 2021-01-21 974
2cf68211664acd Hector Martin 2022-03-10 975 if (irqc->info.fast_ipi)
2cf68211664acd Hector Martin 2022-03-10 976 static_branch_enable(&use_fast_ipi);
2cf68211664acd Hector Martin 2022-03-10 977 else
2cf68211664acd Hector Martin 2022-03-10 978 static_branch_disable(&use_fast_ipi);
2cf68211664acd Hector Martin 2022-03-10 979
a801f0ee563b81 Hector Martin 2022-03-10 @980 irqc->info.die_stride = off - start_off;
a801f0ee563b81 Hector Martin 2022-03-10 981
7c841f5f6fa3f9 Hector Martin 2022-03-10 982 irqc->hw_domain = irq_domain_create_tree(of_node_to_fwnode(node),
76cde26394114f Hector Martin 2021-01-21 983 &aic_irq_domain_ops, irqc);
76cde26394114f Hector Martin 2021-01-21 984 if (WARN_ON(!irqc->hw_domain)) {
76cde26394114f Hector Martin 2021-01-21 985 iounmap(irqc->base);
76cde26394114f Hector Martin 2021-01-21 986 kfree(irqc);
76cde26394114f Hector Martin 2021-01-21 987 return -ENODEV;
76cde26394114f Hector Martin 2021-01-21 988 }
76cde26394114f Hector Martin 2021-01-21 989
76cde26394114f Hector Martin 2021-01-21 990 irq_domain_update_bus_token(irqc->hw_domain, DOMAIN_BUS_WIRED);
76cde26394114f Hector Martin 2021-01-21 991
76cde26394114f Hector Martin 2021-01-21 992 if (aic_init_smp(irqc, node)) {
76cde26394114f Hector Martin 2021-01-21 993 irq_domain_remove(irqc->hw_domain);
76cde26394114f Hector Martin 2021-01-21 994 iounmap(irqc->base);
76cde26394114f Hector Martin 2021-01-21 995 kfree(irqc);
76cde26394114f Hector Martin 2021-01-21 996 return -ENODEV;
76cde26394114f Hector Martin 2021-01-21 997 }
76cde26394114f Hector Martin 2021-01-21 998
76cde26394114f Hector Martin 2021-01-21 999 set_handle_irq(aic_handle_irq);
76cde26394114f Hector Martin 2021-01-21 1000 set_handle_fiq(aic_handle_fiq);
76cde26394114f Hector Martin 2021-01-21 1001
a801f0ee563b81 Hector Martin 2022-03-10 1002 off = 0;
a801f0ee563b81 Hector Martin 2022-03-10 1003 for (die = 0; die < irqc->nr_die; die++) {
7c841f5f6fa3f9 Hector Martin 2022-03-10 1004 for (i = 0; i < BITS_TO_U32(irqc->nr_irq); i++)
a801f0ee563b81 Hector Martin 2022-03-10 1005 aic_ic_write(irqc, irqc->info.mask_set + off + i * 4, U32_MAX);
7c841f5f6fa3f9 Hector Martin 2022-03-10 1006 for (i = 0; i < BITS_TO_U32(irqc->nr_irq); i++)
a801f0ee563b81 Hector Martin 2022-03-10 1007 aic_ic_write(irqc, irqc->info.sw_clr + off + i * 4, U32_MAX);
a801f0ee563b81 Hector Martin 2022-03-10 1008 if (irqc->info.target_cpu)
7c841f5f6fa3f9 Hector Martin 2022-03-10 1009 for (i = 0; i < irqc->nr_irq; i++)
a801f0ee563b81 Hector Martin 2022-03-10 1010 aic_ic_write(irqc, irqc->info.target_cpu + off + i * 4, 1);
a801f0ee563b81 Hector Martin 2022-03-10 1011 off += irqc->info.die_stride;
a801f0ee563b81 Hector Martin 2022-03-10 1012 }
76cde26394114f Hector Martin 2021-01-21 1013
76cde26394114f Hector Martin 2021-01-21 1014 if (!is_kernel_in_hyp_mode())
76cde26394114f Hector Martin 2021-01-21 1015 pr_info("Kernel running in EL1, mapping interrupts");
76cde26394114f Hector Martin 2021-01-21 1016
2cf68211664acd Hector Martin 2022-03-10 1017 if (static_branch_likely(&use_fast_ipi))
2cf68211664acd Hector Martin 2022-03-10 1018 pr_info("Using Fast IPIs");
2cf68211664acd Hector Martin 2022-03-10 1019
76cde26394114f Hector Martin 2021-01-21 1020 cpuhp_setup_state(CPUHP_AP_IRQ_APPLE_AIC_STARTING,
76cde26394114f Hector Martin 2021-01-21 1021 "irqchip/apple-aic/ipi:starting",
76cde26394114f Hector Martin 2021-01-21 1022 aic_init_cpu, NULL);
76cde26394114f Hector Martin 2021-01-21 1023
b6ca556c352979 Marc Zyngier 2021-02-28 1024 vgic_set_kvm_info(&vgic_info);
b6ca556c352979 Marc Zyngier 2021-02-28 1025
a801f0ee563b81 Hector Martin 2022-03-10 1026 pr_info("Initialized with %d/%d IRQs * %d/%d die(s), %d FIQs, %d vIPIs",
a801f0ee563b81 Hector Martin 2022-03-10 1027 irqc->nr_irq, irqc->max_irq, irqc->nr_die, irqc->max_die, AIC_NR_FIQ, AIC_NR_SWIPI);
76cde26394114f Hector Martin 2021-01-21 1028
76cde26394114f Hector Martin 2021-01-21 1029 return 0;
76cde26394114f Hector Martin 2021-01-21 1030 }
76cde26394114f Hector Martin 2021-01-21 1031
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-12-09 3:43 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-08 2:02 drivers/irqchip/irq-apple-aic.c:980 aic_of_ic_init() error: uninitialized symbol 'start_off' kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2023-12-09 3:43 kernel test robot
2023-12-03 23:10 kernel test robot
2022-06-04 5:31 kernel test robot
2022-06-01 2:50 kernel test robot
2022-06-06 11:18 ` Dan Carpenter
2022-06-06 11:18 ` Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.