From: Jakub Kicinski <kuba@kernel.org>
To: Pavel Begunkov <asml.silence@gmail.com>
Cc: io-uring@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
jannh@google.com, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, netdev@vger.kernel.org
Subject: Re: [PATCH RESEND] io_uring/af_unix: disable sending io_uring over sockets
Date: Fri, 8 Dec 2023 17:40:41 -0800 [thread overview]
Message-ID: <20231208174041.3eddcc6b@kernel.org> (raw)
In-Reply-To: <c716c88321939156909cfa1bd8b0faaf1c804103.1701868795.git.asml.silence@gmail.com>
On Wed, 6 Dec 2023 13:55:19 +0000 Pavel Begunkov wrote:
> File reference cycles have caused lots of problems for io_uring
> in the past, and it still doesn't work exactly right and races with
> unix_stream_read_generic(). The safest fix would be to completely
> disallow sending io_uring files via sockets via SCM_RIGHT, so there
> are no possible cycles invloving registered files and thus rendering
> SCM accounting on the io_uring side unnecessary.
>
> Cc: stable@vger.kernel.org
> Fixes: 0091bfc81741b ("io_uring/af_unix: defer registered files gc to io_uring release")
> Reported-and-suggested-by: Jann Horn <jannh@google.com>
> Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Acked-by: Jakub Kicinski <kuba@kernel.org>
FWIW
next prev parent reply other threads:[~2023-12-09 1:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 13:26 [PATCH 1/1] io_uring/af_unix: disable sending io_uring over sockets Pavel Begunkov
2023-12-06 13:55 ` [PATCH RESEND] " Pavel Begunkov
2023-12-06 13:53 ` [PATCH 1/1] " Pavel Begunkov
2023-12-07 20:33 ` Jens Axboe
2023-12-08 14:59 ` Jeff Moyer
2023-12-08 15:09 ` Jann Horn
2023-12-08 16:06 ` Jeff Moyer
2023-12-08 16:28 ` Jens Axboe
2023-12-08 17:08 ` Jeff Moyer
2023-12-10 1:23 ` Pavel Begunkov
2023-12-09 1:40 ` Jakub Kicinski [this message]
2023-12-09 21:30 ` [PATCH RESEND] " patchwork-bot+netdevbpf
2023-12-10 1:18 ` Pavel Begunkov
2023-12-12 2:39 ` Jakub Kicinski
2023-12-12 4:45 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231208174041.3eddcc6b@kernel.org \
--to=kuba@kernel.org \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=io-uring@vger.kernel.org \
--cc=jannh@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.