From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Christoph Hellwig <hch@lst.de>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, linux-block@vger.kernel.org,
linux-fsdevel@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
Daejun Park <daejun7.park@samsung.com>,
Kanchan Joshi <joshi.k@samsung.com>,
Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <chao@kernel.org>
Subject: Re: [PATCH v5 03/17] fs/f2fs: Restore the whint_mode mount option
Date: Mon, 11 Dec 2023 17:44:43 +0100 [thread overview]
Message-ID: <20231211164443.GA25306@lst.de> (raw)
In-Reply-To: <fd6d207d-fe03-4fdf-bd74-3463860135ef@acm.org>
On Thu, Dec 07, 2023 at 09:39:06AM -1000, Bart Van Assche wrote:
> On 12/7/23 07:45, Christoph Hellwig wrote:
>> On Wed, Nov 29, 2023 at 05:33:08PM -0800, Bart Van Assche wrote:
>>> Restore support for the whint_mode mount option by reverting commit
>>> 930e2607638d ("f2fs: remove obsolete whint_mode").
>>
>> I know that commit sets a precedence by having a horribly short and
>> uninformative commit message, but please write a proper one for this
>> commit and explain why you are restoring the option. Also if anything
>> changed since last year.
>
> Hi Christoph,
>
> A possible approach is that I drop this patch from this patch series and
> that I let the F2FS maintainers restore write hint support in F2FS.
I'm not saying you should drop it. Just that it should have a useful
commit message.
next prev parent reply other threads:[~2023-12-11 16:44 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 1:33 [PATCH v5 00/17] Pass data lifetime information to SCSI disk devices Bart Van Assche
2023-11-30 1:33 ` [PATCH v5 01/17] fs: Fix rw_hint validation Bart Van Assche
2023-12-07 17:42 ` Christoph Hellwig
2023-11-30 1:33 ` [PATCH v5 02/17] fs: Move enum rw_hint into a new header file Bart Van Assche
2023-12-07 17:44 ` Christoph Hellwig
2023-11-30 1:33 ` [PATCH v5 03/17] fs/f2fs: Restore the whint_mode mount option Bart Van Assche
2023-12-07 17:45 ` Christoph Hellwig
2023-12-07 19:39 ` Bart Van Assche
2023-12-11 16:44 ` Christoph Hellwig [this message]
2023-11-30 1:33 ` [PATCH v5 04/17] fs: Restore F_[GS]ET_FILE_RW_HINT support Bart Van Assche
2023-12-07 17:46 ` Christoph Hellwig
2023-12-07 19:37 ` Bart Van Assche
2023-12-11 16:45 ` Christoph Hellwig
2023-11-30 1:33 ` [PATCH v5 05/17] fs: Restore kiocb.ki_hint Bart Van Assche
2023-12-07 17:46 ` Christoph Hellwig
2023-12-07 23:40 ` Bart Van Assche
2023-12-11 16:46 ` Christoph Hellwig
2023-11-30 1:33 ` [PATCH v5 06/17] block: Restore the per-bio/request data lifetime fields Bart Van Assche
2023-11-30 1:33 ` [PATCH v5 07/17] block: Propagate write hints to the block device inode Bart Van Assche
2023-11-30 1:33 ` [PATCH v5 08/17] scsi: core: Query the Block Limits Extension VPD page Bart Van Assche
2023-11-30 12:21 ` Johannes Thumshirn
2023-11-30 1:33 ` [PATCH v5 09/17] scsi_proto: Add structures and constants related to I/O groups and streams Bart Van Assche
2023-11-30 13:19 ` Johannes Thumshirn
2023-12-01 1:46 ` Bart Van Assche
2023-11-30 1:33 ` [PATCH v5 10/17] sd: Translate data lifetime information Bart Van Assche
2023-11-30 1:33 ` [PATCH v5 11/17] scsi_debug: Reduce code duplication Bart Van Assche
2023-11-30 1:33 ` [PATCH v5 12/17] scsi_debug: Support the block limits extension VPD page Bart Van Assche
2023-11-30 1:33 ` [PATCH v5 13/17] scsi_debug: Rework page code error handling Bart Van Assche
2023-11-30 1:33 ` [PATCH v5 14/17] scsi_debug: Rework subpage " Bart Van Assche
2023-11-30 1:33 ` [PATCH v5 15/17] scsi_debug: Implement the IO Advice Hints Grouping mode page Bart Van Assche
2023-11-30 1:33 ` [PATCH v5 16/17] scsi_debug: Implement GET STREAM STATUS Bart Van Assche
2023-11-30 1:33 ` [PATCH v5 17/17] scsi_debug: Maintain write statistics per group number Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231211164443.GA25306@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=chao@kernel.org \
--cc=daejun7.park@samsung.com \
--cc=jaegeuk@kernel.org \
--cc=joshi.k@samsung.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.