All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Wu <dan1.wu@intel.com>
To: seanjc@google.com, pbonzini@redhat.com, kvm@vger.kernel.org
Cc: xiaoyao.li@intel.com, dan1.wu@intel.com
Subject: [kvm-unit-tests PATCH v1 0/3] x86: fix async page fault issues
Date: Tue, 12 Dec 2023 14:27:05 +0800	[thread overview]
Message-ID: <20231212062708.16509-1-dan1.wu@intel.com> (raw)

When running asyncpf test, it gets skipped without a clear reason:

    ./asyncpf

    enabling apic
    smp: waiting for 0 APs
    paging enabled
    cr0 = 80010011
    cr3 = 107f000
    cr4 = 20
    install handler
    enable async pf
    alloc memory
    start loop
    end loop
    start loop
    end loop
    SUMMARY: 0 tests
    SKIP asyncpf (0 tests)

The reason is that KVM changed to use interrupt-based 'page-ready' notification
and abandoned #PF-based 'page-ready' notification mechanism. Interrupt-based
'page-ready' notification requires KVM_ASYNC_PF_DELIVERY_AS_INT to be set as well
in MSR_KVM_ASYNC_PF_EN to enable asyncpf.

This series tries to fix the problem by separating two testcases for different mechanisms.

- For old #PF-based notification, changes current asyncpf.c to add CPUID check
  at the beginning. It checks (KVM_FEATURE_ASYNC_PF && !KVM_FEATURE_ASYNC_PF_INT),
  otherwise it gets skipped.

- For new interrupt-based notification, add a new test, asyncpf-int.c, to check
  (KVM_FEATURE_ASYNC_PF && KVM_FEATURE_ASYNC_PF_INT) and implement interrupt-based
  'page-ready' handler.

Dan Wu (3):
  x86: Add a common header asyncpf.h
  x86: Add async page fault int test
  x86/asyncpf: Add CPUID feature bits check to ensure feature is
    available

 ci/cirrus-ci-fedora.yml |   1 +
 lib/x86/processor.h     |   6 ++
 x86/Makefile.common     |   3 +-
 x86/asyncpf.c           |  31 ++++++----
 x86/asyncpf.h           |  23 ++++++++
 x86/asyncpf_int.c       | 127 ++++++++++++++++++++++++++++++++++++++++
 x86/unittests.cfg       |   6 +-
 7 files changed, 185 insertions(+), 12 deletions(-)
 create mode 100644 x86/asyncpf.h
 create mode 100644 x86/asyncpf_int.c

-- 
2.39.3


             reply	other threads:[~2023-12-12  6:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-12  6:27 Dan Wu [this message]
2023-12-12  6:27 ` [kvm-unit-tests PATCH v1 1/3] x86: Add a common header asyncpf.h Dan Wu
2023-12-12  6:27 ` [kvm-unit-tests PATCH v1 2/3] x86: Add async page fault int test Dan Wu
2023-12-12  6:27 ` [kvm-unit-tests PATCH v1 3/3] x86/asyncpf: Add CPUID feature bits check to ensure feature is available Dan Wu
2023-12-12 15:17 ` [kvm-unit-tests PATCH v1 0/3] x86: fix async page fault issues Sean Christopherson
2023-12-13  1:36   ` Wu, Dan1
2023-12-13 18:20     ` Sean Christopherson
2023-12-14  2:32       ` Wu, Dan1

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231212062708.16509-1-dan1.wu@intel.com \
    --to=dan1.wu@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=seanjc@google.com \
    --cc=xiaoyao.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.