Re: [PATCH v8 9/9] landlock: Document IOCTL support

["Mickaël Salaün" <mic@digikod.net>]

On Mon, Dec 11, 2023 at 09:49:14AM +0100, Günther Noack wrote:
> Hello Mickaël!
> 
> Thanks for the review!
> 
> On Mon, Dec 11, 2023 at 08:04:33AM +0100, Mickaël Salaün wrote:
> > On Fri, Dec 08, 2023 at 04:51:21PM +0100, Günther Noack wrote:
> > > ++------------------------+-------------+-------------------+-------------------+
> > > +|                        | ``IOCTL``   | ``IOCTL`` handled | ``IOCTL`` handled |
> > > +|                        | not handled | and permitted     | and not permitted |
> > > ++------------------------+-------------+-------------------+-------------------+
> > > +| ``READ_FILE`` not      | allow       | allow             | deny              |
> > > +| handled                |             |                   |                   |
> > > ++------------------------+             +-------------------+-------------------+
> > > +| ``READ_FILE`` handled  |             | allow                                 |
> > > +| and permitted          |             |                                       |
> > > ++------------------------+             +-------------------+-------------------+
> > > +| ``READ_FILE`` handled  |             | deny                                  |
> > > +| and not permitted      |             |                                       |
> > > ++------------------------+-------------+-------------------+-------------------+
> > 
> > Great! Could you please format this table with the flat-table syntax?
> > See https://docs.kernel.org/doc-guide/sphinx.html#tables
> 
> This link actually says that “Kernel style for tables is to prefer simple table
> syntax or grid table syntax” (instead of the flat-table syntax).
> 
> This "visual" style is more cumbersome to edit, but editing documentation
> happens less than reading it, so further edits are less likely.  I also find it
> easier to reason about what the cell sizes are that way, rather than having to
> wrap my head around special :rspan: and :cspan: syntax.

Indeed, let's keep this ascii art.

> 
> If you are not strongly opposed to it, I'd prefer to keep the existing style,
> but we can do it either way if you feel strongly about it.  Let me know how
> important this is to you.
> 
> Thanks,
> —Günther
>