From: Al Viro <viro@zeniv.linux.org.uk>
To: linux-fsdevel@vger.kernel.org
Cc: Evgeniy Dushistov <dushistov@mail.ru>,
"Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
Matthew Wilcox <willy@infradead.org>
Subject: Re: [patches][cft] ufs stuff
Date: Wed, 13 Dec 2023 06:53:16 +0000 [thread overview]
Message-ID: <20231213065316.GK1674809@ZenIV> (raw)
In-Reply-To: <20231213031639.GJ1674809@ZenIV>
On Wed, Dec 13, 2023 at 03:16:39AM +0000, Al Viro wrote:
> More old stuff, this time UFS one. Part of that is
> yet another kmap_local_page() conversion, part - assorted
> cleanups.
> It seems to survive local beating, but it needs
> more review and testing.
Sigh... That it does - especially since a bit more testing
has caught this (in mainline):
[PATCH] fix ufs_get_locked_folio() breakage
filemap_lock_folio() returns ERR_PTR(-ENOENT) if the thing is not
in cache - not NULL like find_lock_page() used to.
Fixes: 5fb7bd50b351 "ufs: add ufs_get_locked_folio and ufs_put_locked_folio"
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
diff --git a/fs/ufs/util.c b/fs/ufs/util.c
index 535c7ee80a10..f0e906ab4ddd 100644
--- a/fs/ufs/util.c
+++ b/fs/ufs/util.c
@@ -199,7 +199,7 @@ struct folio *ufs_get_locked_folio(struct address_space *mapping,
{
struct inode *inode = mapping->host;
struct folio *folio = filemap_lock_folio(mapping, index);
- if (!folio) {
+ if (IS_ERR(folio)) {
folio = read_mapping_folio(mapping, index, NULL);
if (IS_ERR(folio)) {
prev parent reply other threads:[~2023-12-13 6:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-13 3:16 [patches][cft] ufs stuff Al Viro
2023-12-13 3:18 ` [PATCH 01/12] fs/ufs: Use the offset_in_page() helper Al Viro
2023-12-13 3:18 ` [PATCH 02/12] fs/ufs: Change the signature of ufs_get_page() Al Viro
2023-12-13 3:18 ` [PATCH 03/12] fs/ufs: Use ufs_put_page() in ufs_rename() Al Viro
2023-12-13 3:18 ` [PATCH 04/12] fs/ufs: Replace kmap() with kmap_local_page() Al Viro
2023-12-13 3:18 ` [PATCH 05/12] ufs: fix handling of delete_entry and set_link failures Al Viro
2023-12-13 3:18 ` [PATCH 06/12] ufs: untangle ubh_...block...() macros, part 1 Al Viro
2023-12-13 3:18 ` [PATCH 07/12] ufs: untangle ubh_...block...(), part 2 Al Viro
2023-12-13 3:18 ` [PATCH 08/12] ufs: untangle ubh_...block...(), part 3 Al Viro
2023-12-13 3:18 ` [PATCH 09/12] ufs_clusteracct(): switch to passing fragment number Al Viro
2023-12-13 3:18 ` [PATCH 10/12] ufs_inode_getfrag(): remove junk comment Al Viro
2023-12-13 3:18 ` [PATCH 11/12] ufs: get rid of ubh_{ubhcpymem,memcpyubh}() Al Viro
2023-12-13 3:18 ` [PATCH 12/12] clean ufs_trunc_direct() up a bit Al Viro
2023-12-13 6:53 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231213065316.GK1674809@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=dushistov@mail.ru \
--cc=fmdefrancesco@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.