From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from Atcsqr.andestech.com (60-248-80-70.hinet-ip.hinet.net [60.248.80.70]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E423D3; Tue, 12 Dec 2023 23:05:02 -0800 (PST) Received: from mail.andestech.com (ATCPCS16.andestech.com [10.0.1.222]) by Atcsqr.andestech.com with ESMTP id 3BD73HrQ032167; Wed, 13 Dec 2023 15:03:17 +0800 (+08) (envelope-from peterlin@andestech.com) Received: from swlinux02.andestech.com (10.0.15.183) by ATCPCS16.andestech.com (10.0.1.222) with Microsoft SMTP Server id 14.3.498.0; Wed, 13 Dec 2023 15:03:13 +0800 From: Yu Chien Peter Lin To: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: [PATCH v5 02/16] irqchip/riscv-intc: Allow large non-standard interrupt number Date: Wed, 13 Dec 2023 15:02:47 +0800 Message-ID: <20231213070301.1684751-3-peterlin@andestech.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231213070301.1684751-1-peterlin@andestech.com> References: <20231213070301.1684751-1-peterlin@andestech.com> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-DNSRBL: X-SPAM-SOURCE-CHECK: pass X-MAIL:Atcsqr.andestech.com 3BD73HrQ032167 Currently, the implementation of the RISC-V INTC driver uses the interrupt cause as hardware interrupt number and has a limitation of supporting a maximum of 64 interrupts. However, according to the privileged spec, interrupt causes >= 16 are defined for platform use. This limitation prevents to fully utilize the available local interrupt sources. Additionally, the interrupt number used on RISC-V are sparse, with only interrupt numbers 1, 5 and 9 (plus Sscofpmf or T-Head's PMU interrupt) being currently used for supervisor mode. Switch to using irq_domain_create_tree() to create the radix tree map, so a larger number of hardware interrupts can be handled. Signed-off-by: Yu Chien Peter Lin Reviewed-by: Charles Ci-Jyun Wu Reviewed-by: Leo Yu-Chi Liang --- Changes v1 -> v2: - Fixed irq mapping failure checking (suggested by Clément and Anup) Changes v2 -> v3: - No change Changes v3 -> v4: (Suggested by Thomas [1]) - Use pr_warn_ratelimited instead - Fix coding style and commit message Changes v4 -> v5: (Suggested by Thomas) - Fix commit message [1] https://patchwork.kernel.org/project/linux-riscv/patch/20231023004100.2663486-3-peterlin@andestech.com/#25573085 --- drivers/irqchip/irq-riscv-intc.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/irqchip/irq-riscv-intc.c b/drivers/irqchip/irq-riscv-intc.c index e8d01b14ccdd..2fdd40f2a791 100644 --- a/drivers/irqchip/irq-riscv-intc.c +++ b/drivers/irqchip/irq-riscv-intc.c @@ -24,10 +24,9 @@ static asmlinkage void riscv_intc_irq(struct pt_regs *regs) { unsigned long cause = regs->cause & ~CAUSE_IRQ_FLAG; - if (unlikely(cause >= BITS_PER_LONG)) - panic("unexpected interrupt cause"); - - generic_handle_domain_irq(intc_domain, cause); + if (generic_handle_domain_irq(intc_domain, cause)) + pr_warn_ratelimited("Failed to handle interrupt (cause: %ld)\n", + cause); } /* @@ -117,8 +116,7 @@ static int __init riscv_intc_init_common(struct fwnode_handle *fn) { int rc; - intc_domain = irq_domain_create_linear(fn, BITS_PER_LONG, - &riscv_intc_domain_ops, NULL); + intc_domain = irq_domain_create_tree(fn, &riscv_intc_domain_ops, NULL); if (!intc_domain) { pr_err("unable to add IRQ domain\n"); return -ENXIO; @@ -132,8 +130,6 @@ static int __init riscv_intc_init_common(struct fwnode_handle *fn) riscv_set_intc_hwnode_fn(riscv_intc_hwnode); - pr_info("%d local interrupts mapped\n", BITS_PER_LONG); - return 0; } -- 2.34.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 60BE9C4332F for ; Wed, 13 Dec 2023 07:04:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9IZQWzhmIrWcnCCNWJNAkmZBui0RHKH9f7XzulH5AY8=; b=dv2DV5VlnEoOyY Si483c+/ma3q/OwIlLj0XlJLBSm37uMSitHgQJOSGSemf2MyMuBxkBqWGWPTTXvIw2hIwpsnontLW 7DHj3JEp2lE67xjv95SKWzXE7mTF39XhI+6uBX1v1ZgUNAN4bHO+M7WFO5xWSsqwonVRTpp0RJu0w n7L4IAVzlDJTe1tYFiA0dWzRiijqIwe0aEcvGSu+Na2IqFcuELxwkw5oNk4L5nZQCRWW/qSBf774+ r9vzxs1BqfMaW9VQwDqx2Xa0QLPTnCEA1sJMCilELdbZg1nNVDog68poPw4heHeb7NGChwx91PDBJ CJFenzYcb/z9WZVtv8KA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rDJIC-00DrLl-0n; Wed, 13 Dec 2023 07:04:28 +0000 Received: from 60-248-80-70.hinet-ip.hinet.net ([60.248.80.70] helo=Atcsqr.andestech.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rDJI6-00DrHP-2l; Wed, 13 Dec 2023 07:04:24 +0000 Received: from mail.andestech.com (ATCPCS16.andestech.com [10.0.1.222]) by Atcsqr.andestech.com with ESMTP id 3BD73HrQ032167; Wed, 13 Dec 2023 15:03:17 +0800 (+08) (envelope-from peterlin@andestech.com) Received: from swlinux02.andestech.com (10.0.15.183) by ATCPCS16.andestech.com (10.0.1.222) with Microsoft SMTP Server id 14.3.498.0; Wed, 13 Dec 2023 15:03:13 +0800 From: Yu Chien Peter Lin To: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: [PATCH v5 02/16] irqchip/riscv-intc: Allow large non-standard interrupt number Date: Wed, 13 Dec 2023 15:02:47 +0800 Message-ID: <20231213070301.1684751-3-peterlin@andestech.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231213070301.1684751-1-peterlin@andestech.com> References: <20231213070301.1684751-1-peterlin@andestech.com> MIME-Version: 1.0 X-Originating-IP: [10.0.15.183] X-DNSRBL: X-MAIL: Atcsqr.andestech.com 3BD73HrQ032167 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231212_230423_350666_CD830491 X-CRM114-Status: UNSURE ( 9.88 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org Q3VycmVudGx5LCB0aGUgaW1wbGVtZW50YXRpb24gb2YgdGhlIFJJU0MtViBJTlRDIGRyaXZlciB1 c2VzIHRoZQppbnRlcnJ1cHQgY2F1c2UgYXMgaGFyZHdhcmUgaW50ZXJydXB0IG51bWJlciBhbmQg aGFzIGEgbGltaXRhdGlvbiBvZgpzdXBwb3J0aW5nIGEgbWF4aW11bSBvZiA2NCBpbnRlcnJ1cHRz LiBIb3dldmVyLCBhY2NvcmRpbmcgdG8gdGhlCnByaXZpbGVnZWQgc3BlYywgaW50ZXJydXB0IGNh dXNlcyA+PSAxNiBhcmUgZGVmaW5lZCBmb3IgcGxhdGZvcm0gdXNlLgoKVGhpcyBsaW1pdGF0aW9u IHByZXZlbnRzIHRvIGZ1bGx5IHV0aWxpemUgdGhlIGF2YWlsYWJsZSBsb2NhbCBpbnRlcnJ1cHQK c291cmNlcy4gQWRkaXRpb25hbGx5LCB0aGUgaW50ZXJydXB0IG51bWJlciB1c2VkIG9uIFJJU0Mt ViBhcmUgc3BhcnNlLAp3aXRoIG9ubHkgaW50ZXJydXB0IG51bWJlcnMgMSwgNSBhbmQgOSAocGx1 cyBTc2NvZnBtZiBvciBULUhlYWQncyBQTVUKaW50ZXJydXB0KSBiZWluZyBjdXJyZW50bHkgdXNl ZCBmb3Igc3VwZXJ2aXNvciBtb2RlLgoKU3dpdGNoIHRvIHVzaW5nIGlycV9kb21haW5fY3JlYXRl X3RyZWUoKSB0byBjcmVhdGUgdGhlIHJhZGl4IHRyZWUKbWFwLCBzbyBhIGxhcmdlciBudW1iZXIg b2YgaGFyZHdhcmUgaW50ZXJydXB0cyBjYW4gYmUgaGFuZGxlZC4KClNpZ25lZC1vZmYtYnk6IFl1 IENoaWVuIFBldGVyIExpbiA8cGV0ZXJsaW5AYW5kZXN0ZWNoLmNvbT4KUmV2aWV3ZWQtYnk6IENo YXJsZXMgQ2ktSnl1biBXdSA8ZG1pbnVzQGFuZGVzdGVjaC5jb20+ClJldmlld2VkLWJ5OiBMZW8g WXUtQ2hpIExpYW5nIDx5Y2xpYW5nQGFuZGVzdGVjaC5jb20+Ci0tLQpDaGFuZ2VzIHYxIC0+IHYy OgogIC0gRml4ZWQgaXJxIG1hcHBpbmcgZmFpbHVyZSBjaGVja2luZyAoc3VnZ2VzdGVkIGJ5IENs w6ltZW50IGFuZCBBbnVwKQpDaGFuZ2VzIHYyIC0+IHYzOgogIC0gTm8gY2hhbmdlCkNoYW5nZXMg djMgLT4gdjQ6IChTdWdnZXN0ZWQgYnkgVGhvbWFzIFsxXSkKICAtIFVzZSBwcl93YXJuX3JhdGVs aW1pdGVkIGluc3RlYWQKICAtIEZpeCBjb2Rpbmcgc3R5bGUgYW5kIGNvbW1pdCBtZXNzYWdlCkNo YW5nZXMgdjQgLT4gdjU6IChTdWdnZXN0ZWQgYnkgVGhvbWFzKQogIC0gRml4IGNvbW1pdCBtZXNz YWdlCgpbMV0gaHR0cHM6Ly9wYXRjaHdvcmsua2VybmVsLm9yZy9wcm9qZWN0L2xpbnV4LXJpc2N2 L3BhdGNoLzIwMjMxMDIzMDA0MTAwLjI2NjM0ODYtMy1wZXRlcmxpbkBhbmRlc3RlY2guY29tLyMy NTU3MzA4NQotLS0KIGRyaXZlcnMvaXJxY2hpcC9pcnEtcmlzY3YtaW50Yy5jIHwgMTIgKysrKy0t LS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCA4IGRlbGV0aW9ucygtKQoK ZGlmZiAtLWdpdCBhL2RyaXZlcnMvaXJxY2hpcC9pcnEtcmlzY3YtaW50Yy5jIGIvZHJpdmVycy9p cnFjaGlwL2lycS1yaXNjdi1pbnRjLmMKaW5kZXggZThkMDFiMTRjY2RkLi4yZmRkNDBmMmE3OTEg MTAwNjQ0Ci0tLSBhL2RyaXZlcnMvaXJxY2hpcC9pcnEtcmlzY3YtaW50Yy5jCisrKyBiL2RyaXZl cnMvaXJxY2hpcC9pcnEtcmlzY3YtaW50Yy5jCkBAIC0yNCwxMCArMjQsOSBAQCBzdGF0aWMgYXNt bGlua2FnZSB2b2lkIHJpc2N2X2ludGNfaXJxKHN0cnVjdCBwdF9yZWdzICpyZWdzKQogewogCXVu c2lnbmVkIGxvbmcgY2F1c2UgPSByZWdzLT5jYXVzZSAmIH5DQVVTRV9JUlFfRkxBRzsKIAotCWlm ICh1bmxpa2VseShjYXVzZSA+PSBCSVRTX1BFUl9MT05HKSkKLQkJcGFuaWMoInVuZXhwZWN0ZWQg aW50ZXJydXB0IGNhdXNlIik7Ci0KLQlnZW5lcmljX2hhbmRsZV9kb21haW5faXJxKGludGNfZG9t YWluLCBjYXVzZSk7CisJaWYgKGdlbmVyaWNfaGFuZGxlX2RvbWFpbl9pcnEoaW50Y19kb21haW4s IGNhdXNlKSkKKwkJcHJfd2Fybl9yYXRlbGltaXRlZCgiRmFpbGVkIHRvIGhhbmRsZSBpbnRlcnJ1 cHQgKGNhdXNlOiAlbGQpXG4iLAorCQkJCSAgICBjYXVzZSk7CiB9CiAKIC8qCkBAIC0xMTcsOCAr MTE2LDcgQEAgc3RhdGljIGludCBfX2luaXQgcmlzY3ZfaW50Y19pbml0X2NvbW1vbihzdHJ1Y3Qg Zndub2RlX2hhbmRsZSAqZm4pCiB7CiAJaW50IHJjOwogCi0JaW50Y19kb21haW4gPSBpcnFfZG9t YWluX2NyZWF0ZV9saW5lYXIoZm4sIEJJVFNfUEVSX0xPTkcsCi0JCQkJCSAgICAgICAmcmlzY3Zf aW50Y19kb21haW5fb3BzLCBOVUxMKTsKKwlpbnRjX2RvbWFpbiA9IGlycV9kb21haW5fY3JlYXRl X3RyZWUoZm4sICZyaXNjdl9pbnRjX2RvbWFpbl9vcHMsIE5VTEwpOwogCWlmICghaW50Y19kb21h aW4pIHsKIAkJcHJfZXJyKCJ1bmFibGUgdG8gYWRkIElSUSBkb21haW5cbiIpOwogCQlyZXR1cm4g LUVOWElPOwpAQCAtMTMyLDggKzEzMCw2IEBAIHN0YXRpYyBpbnQgX19pbml0IHJpc2N2X2ludGNf aW5pdF9jb21tb24oc3RydWN0IGZ3bm9kZV9oYW5kbGUgKmZuKQogCiAJcmlzY3Zfc2V0X2ludGNf aHdub2RlX2ZuKHJpc2N2X2ludGNfaHdub2RlKTsKIAotCXByX2luZm8oIiVkIGxvY2FsIGludGVy cnVwdHMgbWFwcGVkXG4iLCBCSVRTX1BFUl9MT05HKTsKLQogCXJldHVybiAwOwogfQogCi0tIAoy LjM0LjEKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwps aW51eC1yaXNjdiBtYWlsaW5nIGxpc3QKbGludXgtcmlzY3ZAbGlzdHMuaW5mcmFkZWFkLm9yZwpo dHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJpc2N2Cg==