From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
To: Dave Hansen <dave.hansen@intel.com>
Cc: Arnd Bergmann <arnd@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, Yuan Yao <yuan.yao@intel.com>,
Kai Huang <kai.huang@intel.com>, Tony Luck <tony.luck@intel.com>,
Arnd Bergmann <arnd@arndb.de>, "H. Peter Anvin" <hpa@zytor.com>,
Isaku Yamahata <isaku.yamahata@intel.com>,
linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: tdx: hide unused tdx_dump_mce_info()
Date: Wed, 13 Dec 2023 15:02:15 +0300 [thread overview]
Message-ID: <20231213120215.64wcryk5k75cymop@box> (raw)
In-Reply-To: <39cf0ad5-bbef-4fb9-81a3-9d2891cc7450@intel.com>
On Tue, Dec 12, 2023 at 01:42:09PM -0800, Dave Hansen wrote:
> On 12/12/23 13:36, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> >
> > When TDX is enabled but MCE is not, the tdx_dump_mce_info() function
> > fails to link:
>
> Thanks for the report, Arnd.
>
> The only way that TDX has to report integrity errors is an MCE. I'm not
> sure it even makes sense to have TDX support but not MCE support. Maybe
> we should just make TDX host support depend on MCE.
I agree. Silently ignore integrity errors is not good idea.
TDX module spec also supports it:
"The machine-check exception handler is expected to be implemented in the
VMM."
--
Kiryl Shutsemau / Kirill A. Shutemov
next prev parent reply other threads:[~2023-12-13 12:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 21:36 [PATCH] x86: tdx: hide unused tdx_dump_mce_info() Arnd Bergmann
2023-12-12 21:42 ` Dave Hansen
2023-12-12 21:46 ` Borislav Petkov
2023-12-13 12:02 ` Kirill A. Shutemov [this message]
2023-12-13 20:11 ` Huang, Kai
2023-12-13 20:13 ` Dave Hansen
2023-12-13 20:29 ` Huang, Kai
2023-12-13 20:41 ` Huang, Kai
2023-12-13 22:32 ` Huang, Kai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231213120215.64wcryk5k75cymop@box \
--to=kirill.shutemov@linux.intel.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=isaku.yamahata@intel.com \
--cc=kai.huang@intel.com \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=yuan.yao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.