From: Jakub Kicinski <kuba@kernel.org>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: Jamal Hadi Salim <hadi@mojatatu.com>,
Eric Dumazet <edumazet@google.com>,
Victor Nogueira <victor@mojatatu.com>,
xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net,
pabeni@redhat.com, daniel@iogearbox.net, dcaratti@redhat.com,
netdev@vger.kernel.org, kernel@mojatatu.com
Subject: Re: [PATCH net-next v3 2/3] net: sched: Make tc-related drop reason more flexible for remaining qdiscs
Date: Wed, 13 Dec 2023 13:08:07 -0800 [thread overview]
Message-ID: <20231213130807.503e1332@kernel.org> (raw)
In-Reply-To: <CAM0EoMk9cA0qCGNa181QkGjRHr=4oZhvfMGEWoTRS-kHXFWt7g@mail.gmail.com>
On Wed, 13 Dec 2023 13:36:31 -0500 Jamal Hadi Salim wrote:
> Putting this to rest:
> Other than fq codel, the others that deal with multiple skbs due to
> gso segments. So the conclusion is: if we have a bunch in the list
> then they all suffer the same fate. So a single reason for the list is
> sufficient.
Alright.
I'm still a bit confused about the cb, tho.
struct qdisc_skb_cb is the state struct.
But we put the drop reason in struct tc_skb_cb.
How does that work. Qdiscs will assume they own all of
qdisc_skb_cb::data ?
Maybe some documentation about the lifetimes of these things
would clarify things?
next prev parent reply other threads:[~2023-12-13 21:08 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 20:50 [PATCH net-next v3 0/3] net: sched: Make tc-related drop reason more flexible for remaining qdiscs Victor Nogueira
2023-12-05 20:50 ` [PATCH net-next v3 1/3] net: sched: Move drop_reason to struct tc_skb_cb Victor Nogueira
2023-12-05 21:17 ` Daniel Borkmann
2023-12-11 13:37 ` Simon Horman
2023-12-05 20:50 ` [PATCH net-next v3 2/3] net: sched: Make tc-related drop reason more flexible for remaining qdiscs Victor Nogueira
2023-12-05 21:20 ` Daniel Borkmann
2023-12-11 13:38 ` Simon Horman
2023-12-12 2:25 ` Jakub Kicinski
2023-12-12 16:27 ` Jamal Hadi Salim
2023-12-12 16:57 ` Eric Dumazet
2023-12-12 17:16 ` Jamal Hadi Salim
2023-12-13 18:36 ` Jamal Hadi Salim
2023-12-13 21:08 ` Jakub Kicinski [this message]
2023-12-14 15:31 ` Jamal Hadi Salim
2023-12-14 17:18 ` Taehee Yoo
2023-12-15 14:42 ` Jamal Hadi Salim
2023-12-14 18:01 ` Jakub Kicinski
2023-12-05 20:50 ` [PATCH net-next v3 3/3] net: sched: Add initial TC error skb drop reasons Victor Nogueira
2023-12-11 13:38 ` Simon Horman
2023-12-12 2:30 ` Jakub Kicinski
2023-12-13 18:25 ` Victor Nogueira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231213130807.503e1332@kernel.org \
--to=kuba@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dcaratti@redhat.com \
--cc=edumazet@google.com \
--cc=hadi@mojatatu.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kernel@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=victor@mojatatu.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.