From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 40010C4332F for ; Wed, 13 Dec 2023 15:37:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=27oRVSmGnhjocLh6sFzygCz4IWJAvl+GGBJpFEGkYdE=; b=I59OI4dBpLOC/mUzM3IWVWxvFz 9DmcXiFVEOcGOslH7rNkIi9KVlV3iQKSZ47hrx1bi87XQ20nD9UfgMxzKeHZIxY4IiNHPSwTmuJgu HsqL98D69FlAFxXBnQGP6UrVXZbDRBThMGyNUBCLWGN3nCag8YoR+RU7MsuSpj9RX17wi7xTlkvtv if+k243mL1i7rVHIBthhTgYKgB4oTVGzmm9m3jJfX/gs5Cujdt1oBvMWWMRqG2oNRMRfdopQ+3J60 9IL6woXJzFiUCzNKOsAUAKlYMP794kJSoxVylCohCDDsbM/vlXZlfyAcjIKE/Pgz86AeE4IhU7QmZ n+gEsKcg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rDRIk-00FH7A-04; Wed, 13 Dec 2023 15:37:34 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rDRIh-00FH6X-02 for linux-nvme@lists.infradead.org; Wed, 13 Dec 2023 15:37:32 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 66E9C68B05; Wed, 13 Dec 2023 16:37:28 +0100 (CET) Date: Wed, 13 Dec 2023 16:37:28 +0100 From: Christoph Hellwig To: Guixin Liu Cc: Christoph Hellwig , sagi@grimberg.me, kch@nvidia.com, linux-nvme@lists.infradead.org Subject: Re: [PATCH 4/5] nvmet: relocate the cntlid_ida to the internal of subsystem Message-ID: <20231213153728.GB7301@lst.de> References: <1702449172-8920-1-git-send-email-kanie@linux.alibaba.com> <1702449172-8920-5-git-send-email-kanie@linux.alibaba.com> <20231213084649.GE6184@lst.de> <1db09834-5cbe-4e27-938d-8ba4d50347d0@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1db09834-5cbe-4e27-938d-8ba4d50347d0@linux.alibaba.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231213_073731_196831_28B29E50 X-CRM114-Status: GOOD ( 11.71 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Wed, Dec 13, 2023 at 08:59:26PM +0800, Guixin Liu wrote: >> nvmet: Make cntlid globally unique >> We usually log the cntlid which is confusing in case >> we have multiple subsystems each with it's own cntlid ida. >> Instead make cntlid ida globally unique and log the initial >> association. >> " >> >> which seems reasonable. If you have a reason for not making it unique, >> it needs to be stated here so we can weight it against the original >> reason for making the ids globally unique. > > Emm, I just change this per the NVMe spec, Sagi's comment is reasonable. It's probably worth moving the above into a comment to explain what we're doing here..