From: Lee Jones <lee@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, Alex Vinarskis <alex.vinarskis@gmail.com>
Subject: Re: [PATCH v1 1/1] mfd: intel-lpss: Fix the fractional clock divider flags
Date: Wed, 13 Dec 2023 16:18:54 +0000 [thread overview]
Message-ID: <20231213161854.GR111411@google.com> (raw)
In-Reply-To: <ZXnZDjnor8oQNo2g@smile.fi.intel.com>
On Wed, 13 Dec 2023, Andy Shevchenko wrote:
> On Wed, Dec 13, 2023 at 04:13:52PM +0000, Lee Jones wrote:
> > On Mon, 11 Dec 2023, Andy Shevchenko wrote:
>
> ...
>
> > > tmp = clk_register_fractional_divider(NULL, name, __clk_get_name(tmp),
> > > + 0, lpss->priv, 1, 15, 16, 15,
> > > CLK_FRAC_DIVIDER_POWER_OF_TWO_PS,
> > > - lpss->priv, 1, 15, 16, 15, 0,
> > > NULL);
> >
> > What an ugly interface. Intel-only too, right?
>
> Nope, de facto way how custom clocks are being introduced.
> See clk-provider.h for several similar APIs (that require an
> additional, custom, flags to be supplied).
This call only has 2 call-sites, both Intel.
Anyway, just checking to ensure both are being fixed-up.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2023-12-13 16:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-11 11:14 [PATCH v1 1/1] mfd: intel-lpss: Fix the fractional clock divider flags Andy Shevchenko
2023-12-13 16:13 ` Lee Jones
2023-12-13 16:17 ` Andy Shevchenko
2023-12-13 16:18 ` Lee Jones [this message]
2023-12-13 16:26 ` Andy Shevchenko
2023-12-13 17:46 ` Lee Jones
2023-12-13 18:47 ` Andy Shevchenko
2023-12-13 16:19 ` (subset) " Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231213161854.GR111411@google.com \
--to=lee@kernel.org \
--cc=alex.vinarskis@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.