All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Seiderer <ps.report@gmx.net>
To: James Le Cuirot <chewi@gentoo.org>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH 1/2] meson: Fix building with -Dv4l-utils=false
Date: Wed, 13 Dec 2023 22:43:51 +0100	[thread overview]
Message-ID: <20231213224351.3f31b5fa@gmx.net> (raw)
In-Reply-To: <20231212152418.20584-1-chewi@gentoo.org>

On Tue, 12 Dec 2023 15:24:05 +0000, James Le Cuirot <chewi@gentoo.org> wrote:

> ir_bpf_enabled was referenced without being defined.
> ---
>  meson.build | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/meson.build b/meson.build
> index 03508bc8..d9689d35 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -382,6 +382,8 @@ subdir('lib')
>  if get_option('v4l-utils')
>      subdir('utils')
>      subdir('contrib')
> +else
> +    ir_bpf_enabled = false
>  endif
>
>  subdir('doc')

Can confirm the following error/failure without the patch (using
buildroot where v4l-utils is known as libv4l package)

  .../libv4l-1.26.0/meson.build:406:32: ERROR: Unknown variable "ir_bpf_enabled".

and no error with the patch applied, so you can add my

Tested-by: Peter Seiderer <ps.report@gmx.net>

Regards,
Peter


      parent reply	other threads:[~2023-12-13 21:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-12 15:24 [PATCH 1/2] meson: Fix building with -Dv4l-utils=false James Le Cuirot
2023-12-12 15:24 ` [PATCH 2/2] meson: Allow documentation directory to be specified with -Ddocdir James Le Cuirot
2023-12-13 21:43 ` Peter Seiderer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231213224351.3f31b5fa@gmx.net \
    --to=ps.report@gmx.net \
    --cc=chewi@gentoo.org \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.