From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 63C8977B34 for ; Wed, 13 Dec 2023 23:28:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Nl9eBYnI" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0AE29C433C7; Wed, 13 Dec 2023 23:28:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702510139; bh=4gKidT0yhMom5LZFkC+V9sWURd/W6+Efd8VGEETESnM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Nl9eBYnIIqPUoY10qXWQ2oii2454652b5sPYirYZd2/P8gLT+Off8wdu0uODQwbWs jkMoROuORiNa2wv1rN26unk6upb3O3Rniwsd8bhtxkMrlBYDbG0fAI+01oZX/OTEaS SWShTIzUBZEO2WAcUs40s2Fq1xVsKFFpQiWzjgtmIhII4Y3hvRaofIcxhACPQGTHXA 9FM1+00B+8NLHgbuPl5JbBxZcKzveJvN6guNm7N9Ij7yIZ+OTMpLBTiAcEtDxHq4An m323ehQLaOXPYIJgqmZ6Fo1+7bFhzRKWdWwaM26Os8CLXt1a6FcrMc/f80gdcz/xCS MHsiE2nyYsgmA== From: Jakub Kicinski To: davem@davemloft.net Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com, donald.hunter@gmail.com, Jakub Kicinski Subject: [PATCH net-next 1/3] netlink: specs: ovs: remove fixed header fields from attrs Date: Wed, 13 Dec 2023 15:28:20 -0800 Message-ID: <20231213232822.2950853-2-kuba@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231213232822.2950853-1-kuba@kernel.org> References: <20231213232822.2950853-1-kuba@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Op's "attributes" list is a workaround for families with a single attr set. We don't want to render a single huge request structure, the same for each op since we know that most ops accept only a small set of attributes. "Attributes" list lets us narrow down the attributes to what op acctually pays attention to. It doesn't make sense to put names of fixed headers in there. They are not "attributes" and we can't really narrow down the struct members. Remove the fixed header fields from attrs for ovs families in preparation for C codegen support. Signed-off-by: Jakub Kicinski --- Documentation/netlink/specs/ovs_datapath.yaml | 2 -- Documentation/netlink/specs/ovs_flow.yaml | 3 --- Documentation/netlink/specs/ovs_vport.yaml | 4 ---- 3 files changed, 9 deletions(-) diff --git a/Documentation/netlink/specs/ovs_datapath.yaml b/Documentation/netlink/specs/ovs_datapath.yaml index f709c26c3e92..067c54a52d7a 100644 --- a/Documentation/netlink/specs/ovs_datapath.yaml +++ b/Documentation/netlink/specs/ovs_datapath.yaml @@ -142,7 +142,6 @@ uapi-header: linux/openvswitch.h do: request: attributes: - - dp-ifindex - name - upcall-pid - user-features @@ -154,7 +153,6 @@ uapi-header: linux/openvswitch.h do: request: attributes: - - dp-ifindex - name mcast-groups: diff --git a/Documentation/netlink/specs/ovs_flow.yaml b/Documentation/netlink/specs/ovs_flow.yaml index 109ca1f57b6c..29315f3538fd 100644 --- a/Documentation/netlink/specs/ovs_flow.yaml +++ b/Documentation/netlink/specs/ovs_flow.yaml @@ -947,13 +947,11 @@ uapi-header: linux/openvswitch.h do: &flow-get-op request: attributes: - - dp-ifindex - key - ufid - ufid-flags reply: attributes: - - dp-ifindex - key - ufid - mask @@ -968,7 +966,6 @@ uapi-header: linux/openvswitch.h do: request: attributes: - - dp-ifindex - key - ufid - mask diff --git a/Documentation/netlink/specs/ovs_vport.yaml b/Documentation/netlink/specs/ovs_vport.yaml index f65ce62cd60d..86ba9ac2a521 100644 --- a/Documentation/netlink/specs/ovs_vport.yaml +++ b/Documentation/netlink/specs/ovs_vport.yaml @@ -135,7 +135,6 @@ uapi-header: linux/openvswitch.h - name - type - upcall-pid - - dp-ifindex - ifindex - options - @@ -146,7 +145,6 @@ uapi-header: linux/openvswitch.h do: request: attributes: - - dp-ifindex - port-no - type - name @@ -158,11 +156,9 @@ uapi-header: linux/openvswitch.h do: &vport-get-op request: attributes: - - dp-ifindex - name reply: &dev-all attributes: - - dp-ifindex - port-no - type - name -- 2.43.0