From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="nKrYKE8U" Received: from mail-oa1-x35.google.com (mail-oa1-x35.google.com [IPv6:2001:4860:4864:20::35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 955C2F5 for ; Wed, 13 Dec 2023 21:13:39 -0800 (PST) Received: by mail-oa1-x35.google.com with SMTP id 586e51a60fabf-203061bbf3aso1774169fac.3 for ; Wed, 13 Dec 2023 21:13:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702530819; x=1703135619; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=tGvsJDQAMzLezaJvKe+SydOVs1hJQDGaynKlMwoskT4=; b=nKrYKE8Uf3UL7w0vaBWQi2gBRLEIiBZfJH50f9E2d5qKLJtbbyBWNCsvC7qT6W3sYC eg4yaoNsac3k94gxt8H68ThiL6xthPpgbr+nh//+oT2HH2H+spOBXkmISH07n0cA9p7/ /1ziGdf/L0PhBDcbxGVoYpbMwEbqei+sw/J5ture6HUUTcm0X4LeFRSP+E2eOuQ50y2x tnn0Q5GjEoER16bjBZnjF4d3tJEjXKOXWXyaBtrg9ogrF75kpYAfYXZA+/cC75BsyfC6 MFEGGSUHwwsmUpwVK3HZ9V+BjwNle9f19nykV42O5F+FGwL8Fqvfx2P05CXl3I9eA2rx OXXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702530819; x=1703135619; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tGvsJDQAMzLezaJvKe+SydOVs1hJQDGaynKlMwoskT4=; b=hpmKGidVYrD0WwkQliWIpMgt/uW9GfTqF7HM+TDAuMafeiJhTM8LsG71EUIdV+hX6f ii0I4M6VhcBY9DiofWn4fQZQbAIBdx1RCfb8Gi4LznJeibg21k/QLpYYp3i6eSn6ALLp EP00pxXkBaAnqRVcRKLAVl1CZyaKr3hs2vfObyM8paNCPKDqi/aOYYc4bsLSXXT7r7fB eUawty3rhnz3uaDa3704J66LRIOIRBPfkw+ZWAKT1kwlmZakP5mmiDEtm+/fhO87jo+z 8aEcYJN5ymM2PDfPGLSj19NTdikFE56CcVdBywx7bKy+x2N48N95NMlDgXWJcPJMhiFW irjQ== X-Gm-Message-State: AOJu0YzhC5g6Hd7SoxjMsW/n5HtNzvg++KYhwZRyDua8e+agA2pyHDMv /9oQGRfmrULbhmMrsZicpo9t X-Google-Smtp-Source: AGHT+IF7Jn4S+prGJxVJcS2oGK9Fh6M9OUtE75CGnfrjrN6KWZmfHgWTJpIwPzVP3dRI2hzJ3wX4Jw== X-Received: by 2002:a05:6870:4987:b0:1fb:75a:778f with SMTP id ho7-20020a056870498700b001fb075a778fmr10833283oab.64.1702530818876; Wed, 13 Dec 2023 21:13:38 -0800 (PST) Received: from thinkpad ([117.213.102.12]) by smtp.gmail.com with ESMTPSA id n2-20020a170902d2c200b001bf044dc1a6sm11413219plc.39.2023.12.13.21.13.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 21:13:38 -0800 (PST) Date: Thu, 14 Dec 2023 10:43:28 +0530 From: Manivannan Sadhasivam To: Sherry Sun Cc: hongxing.zhu@nxp.com, l.stach@pengutronix.de, lpieralisi@kernel.org, kw@linux.com, robh@kernel.org, bhelgaas@google.com, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2 0/4] PCI: imx6: Add pci host wakeup support Message-ID: <20231214051328.GD2938@thinkpad> References: <20231213092850.1706042-1-sherry.sun@nxp.com> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231213092850.1706042-1-sherry.sun@nxp.com> On Wed, Dec 13, 2023 at 05:28:46PM +0800, Sherry Sun wrote: > Add pci host wakeup feature for imx platforms. The host wake pin is a > standard feature in the PCIe bus specification, so we can add this > property under PCI dts node to support the host gpio wakeup feature. > > Example of configuring the corresponding dts property under the PCI node: > wake-gpios = <&gpio5 21 GPIO_ACTIVE_LOW>; > As you mentioned, WAKE# is a standard sideband signal defined in the PCI spec. So the support for handling it has to be in the PCI core layer, not in the host controller drivers. There is already a series floating to add support for WAKE# in PCI core. Please take a look: https://lore.kernel.org/linux-pci/20230208111645.3863534-1-mmaddireddy@nvidia.com/ - Mani > --- > changes in V2: > 1. Rename host-wake-gpio property to wake-gpios. > 2. Improve the wake-gpios property description in the dt-binding doc to avoid > confusion. > 3. Remove unnecessary debugging info in host_wake_irq_handler(). > 4. Remove unnecessary imx6_pcie->host_wake_irq = -1 resetting in error paths. > 5. Use dev_err_probe() to simplify error path code. > --- > > Sherry Sun (4): > PCI: imx6: Add pci host wakeup support on imx platforms. > dt-bindings: imx6q-pcie: Add wake-gpios property > arm64: dts: imx8mp-evk: add wake-gpios property for pci bus > arm64: dts: imx8mq-evk: add wake-gpios property for pci bus > > .../bindings/pci/fsl,imx6q-pcie.yaml | 6 ++ > arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 2 + > arch/arm64/boot/dts/freescale/imx8mq-evk.dts | 2 + > drivers/pci/controller/dwc/pci-imx6.c | 60 +++++++++++++++++++ > 4 files changed, 70 insertions(+) > > -- > 2.34.1 > > -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0DB6EC4332F for ; Thu, 14 Dec 2023 05:14:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=w5AswwKAvkA5nh8aNpqIlwuXOh9wu4/4CAh6HHam/9w=; b=T1VGt/lfNCbVWt /oz2PLkSnOVmRPfP/McjvkVC8DB6MSJQtt5T/SMEzr/mZAZkg86ZFNGUczOlgTG04NqT/5AohUJMc 74a1+D2KlQdQiK1qPf2C1KSIJ+j3DxTu91IS3HmYWf7J2A2uo59yxME+3Ptaf1mKotAiITP67tkMT TJzH8XFJ9m3cXh1ChImr/gSKHxCdidfj+ZtyBTkj1lwCFEiGClTymlHm4nAJ35J1cRwY3NeCSjHTI 2ehFYYpEgygqOyBfzpQsUx+L5pWFyZgee+VqxqnhuQQCf8dsLhPDGtp1rMX0siNl5GlaPWOHWm4ZR rH14ci8UBAZ0ZwtsbO8A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rDe2b-00Gm32-1I; Thu, 14 Dec 2023 05:13:45 +0000 Received: from mail-oa1-x2d.google.com ([2001:4860:4864:20::2d]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rDe2Y-00Gm2W-23 for linux-arm-kernel@lists.infradead.org; Thu, 14 Dec 2023 05:13:44 +0000 Received: by mail-oa1-x2d.google.com with SMTP id 586e51a60fabf-203061bbf3aso1774168fac.3 for ; Wed, 13 Dec 2023 21:13:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702530819; x=1703135619; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=tGvsJDQAMzLezaJvKe+SydOVs1hJQDGaynKlMwoskT4=; b=UQmufjxq11IyAMFiEfJgZAbS/sWIO8IKna5gfCy/i9XRmPL0KsZUI+CUjrSUzXvB69 aFTU8ePdrFrSyn0+hB7s82hqpLqZRXMjWaySRwZELV+vJACRk+e4KNMBhh/06GUEk78r OvNKeOOk0tPPJebF/sVrUeW2Xx+WWHfIXhEFfw9eLHLn39cN7wBLH2rIIxZ000M3eL35 Q+x2o55nX9k10UNlty10HpDe2YrbuGQVNsHfiPAEbkSsmMYHZAgB/aGMEvc/+wYPc5zP 6rYK5WWl27LOOa8i3ZXMvzr7Ooj5S0USHHtbtsV8PvC5wM49KamXkpCanOY9ayZTY7KK KxHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702530819; x=1703135619; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tGvsJDQAMzLezaJvKe+SydOVs1hJQDGaynKlMwoskT4=; b=CpnIX8RAT3JPeKX/3KdjmvvfQWfvNEXrT+TGHqbbnsJobFqjmXMyQn9/j+PSDEF5kd 2t2bmSXAHQk31y1C4P/bUduWmvDg/FRI6rUVAGLcdk8AfttSCUMkgGklBtrHVpkiZ8Cr So10glqN88TF7lm+qES1XWsaX5oDoaknuhaXytxXRU2B5J0w7wtSf4jH1jaRJCsme7n+ bNqXjqEdCiCsvgVXYWuiwqGxQW6ycBK5xGAOj9PciSNPEPA5WmiDVeYiWzTfl3qbd55E qC1eEb8IbqKQA8tWL8/5vSxM4gNVzWpQaxn+Tp9eT4l0NavAkj55YqFxEy4uW07uQ7A0 YHdg== X-Gm-Message-State: AOJu0YwrnbKw4MP9kI4Vuz1VrOZr96eft1pB8uV30IYPJol2CT/ihiDS FfD3Va2qvP1ErvFaJQ0pTTag X-Google-Smtp-Source: AGHT+IF7Jn4S+prGJxVJcS2oGK9Fh6M9OUtE75CGnfrjrN6KWZmfHgWTJpIwPzVP3dRI2hzJ3wX4Jw== X-Received: by 2002:a05:6870:4987:b0:1fb:75a:778f with SMTP id ho7-20020a056870498700b001fb075a778fmr10833283oab.64.1702530818876; Wed, 13 Dec 2023 21:13:38 -0800 (PST) Received: from thinkpad ([117.213.102.12]) by smtp.gmail.com with ESMTPSA id n2-20020a170902d2c200b001bf044dc1a6sm11413219plc.39.2023.12.13.21.13.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 21:13:38 -0800 (PST) Date: Thu, 14 Dec 2023 10:43:28 +0530 From: Manivannan Sadhasivam To: Sherry Sun Cc: hongxing.zhu@nxp.com, l.stach@pengutronix.de, lpieralisi@kernel.org, kw@linux.com, robh@kernel.org, bhelgaas@google.com, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2 0/4] PCI: imx6: Add pci host wakeup support Message-ID: <20231214051328.GD2938@thinkpad> References: <20231213092850.1706042-1-sherry.sun@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231213092850.1706042-1-sherry.sun@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231213_211342_700436_3E5FD10F X-CRM114-Status: GOOD ( 18.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBEZWMgMTMsIDIwMjMgYXQgMDU6Mjg6NDZQTSArMDgwMCwgU2hlcnJ5IFN1biB3cm90 ZToKPiBBZGQgcGNpIGhvc3Qgd2FrZXVwIGZlYXR1cmUgZm9yIGlteCBwbGF0Zm9ybXMuIFRoZSBo b3N0IHdha2UgcGluIGlzIGEKPiBzdGFuZGFyZCBmZWF0dXJlIGluIHRoZSBQQ0llIGJ1cyBzcGVj aWZpY2F0aW9uLCBzbyB3ZSBjYW4gYWRkIHRoaXMKPiBwcm9wZXJ0eSB1bmRlciBQQ0kgZHRzIG5v ZGUgdG8gc3VwcG9ydCB0aGUgaG9zdCBncGlvIHdha2V1cCBmZWF0dXJlLgo+IAo+IEV4YW1wbGUg b2YgY29uZmlndXJpbmcgdGhlIGNvcnJlc3BvbmRpbmcgZHRzIHByb3BlcnR5IHVuZGVyIHRoZSBQ Q0kgbm9kZToKPiAgICAgd2FrZS1ncGlvcyA9IDwmZ3BpbzUgMjEgR1BJT19BQ1RJVkVfTE9XPjsK PiAKCkFzIHlvdSBtZW50aW9uZWQsIFdBS0UjIGlzIGEgc3RhbmRhcmQgc2lkZWJhbmQgc2lnbmFs IGRlZmluZWQgaW4gdGhlIFBDSSBzcGVjLgpTbyB0aGUgc3VwcG9ydCBmb3IgaGFuZGxpbmcgaXQg aGFzIHRvIGJlIGluIHRoZSBQQ0kgY29yZSBsYXllciwgbm90IGluIHRoZQpob3N0IGNvbnRyb2xs ZXIgZHJpdmVycy4KClRoZXJlIGlzIGFscmVhZHkgYSBzZXJpZXMgZmxvYXRpbmcgdG8gYWRkIHN1 cHBvcnQgZm9yIFdBS0UjIGluIFBDSSBjb3JlLiBQbGVhc2UKdGFrZSBhIGxvb2s6CgpodHRwczov L2xvcmUua2VybmVsLm9yZy9saW51eC1wY2kvMjAyMzAyMDgxMTE2NDUuMzg2MzUzNC0xLW1tYWRk aXJlZGR5QG52aWRpYS5jb20vCgotIE1hbmkKCj4gLS0tCj4gY2hhbmdlcyBpbiBWMjoKPiAxLiBS ZW5hbWUgaG9zdC13YWtlLWdwaW8gcHJvcGVydHkgdG8gd2FrZS1ncGlvcy4KPiAyLiBJbXByb3Zl IHRoZSB3YWtlLWdwaW9zIHByb3BlcnR5IGRlc2NyaXB0aW9uIGluIHRoZSBkdC1iaW5kaW5nIGRv YyB0byBhdm9pZAo+IGNvbmZ1c2lvbi4KPiAzLiBSZW1vdmUgdW5uZWNlc3NhcnkgZGVidWdnaW5n IGluZm8gaW4gaG9zdF93YWtlX2lycV9oYW5kbGVyKCkuCj4gNC4gUmVtb3ZlIHVubmVjZXNzYXJ5 IGlteDZfcGNpZS0+aG9zdF93YWtlX2lycSA9IC0xIHJlc2V0dGluZyBpbiBlcnJvciBwYXRocy4K PiA1LiBVc2UgZGV2X2Vycl9wcm9iZSgpIHRvIHNpbXBsaWZ5IGVycm9yIHBhdGggY29kZS4KPiAt LS0KPiAKPiBTaGVycnkgU3VuICg0KToKPiAgIFBDSTogaW14NjogQWRkIHBjaSBob3N0IHdha2V1 cCBzdXBwb3J0IG9uIGlteCBwbGF0Zm9ybXMuCj4gICBkdC1iaW5kaW5nczogaW14NnEtcGNpZTog QWRkIHdha2UtZ3Bpb3MgcHJvcGVydHkKPiAgIGFybTY0OiBkdHM6IGlteDhtcC1ldms6IGFkZCB3 YWtlLWdwaW9zIHByb3BlcnR5IGZvciBwY2kgYnVzCj4gICBhcm02NDogZHRzOiBpbXg4bXEtZXZr OiBhZGQgd2FrZS1ncGlvcyBwcm9wZXJ0eSBmb3IgcGNpIGJ1cwo+IAo+ICAuLi4vYmluZGluZ3Mv cGNpL2ZzbCxpbXg2cS1wY2llLnlhbWwgICAgICAgICAgfCAgNiArKwo+ICBhcmNoL2FybTY0L2Jv b3QvZHRzL2ZyZWVzY2FsZS9pbXg4bXAtZXZrLmR0cyAgfCAgMiArCj4gIGFyY2gvYXJtNjQvYm9v dC9kdHMvZnJlZXNjYWxlL2lteDhtcS1ldmsuZHRzICB8ICAyICsKPiAgZHJpdmVycy9wY2kvY29u dHJvbGxlci9kd2MvcGNpLWlteDYuYyAgICAgICAgIHwgNjAgKysrKysrKysrKysrKysrKysrKwo+ ICA0IGZpbGVzIGNoYW5nZWQsIDcwIGluc2VydGlvbnMoKykKPiAKPiAtLSAKPiAyLjM0LjEKPiAK PiAKCi0tIArgrq7grqPgrr/grrXgrqPgr43grqPgrqngr40g4K6a4K6k4K6+4K6a4K6/4K614K6u 4K+NCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51 eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVh ZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1h cm0ta2VybmVsCg==