Re: [Buildroot] [PATCH v8 01/10] package/binutils-bare-metal: new package

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

On Thu, 14 Dec 2023 07:10:39 +0000
"Frager, Neal" <neal.frager@amd.com> wrote:

> I just made a patch which removes my post install fixup with the
> newlib configure script patch.
> 
> Below you can find a pull request to apply it to your bare-metal
> branch: https://github.com/tpetazzoni/buildroot/pull/1

As replied to another e-mail, the newlib patch will have to be improved
to make tooldir configurable, as I don't think your patch can be
acceptable as-is in newlib, as it would break things for existing users.

Also, the way your formatted the patch is not correct: you have made
yourself the author of the patch, but you kept the original author of
the patch as the first Signed-off-by. Golden rule: the patch author
must *always* match the first Signed-off-by line.

So here two options:

- You want to keep the original author: he must appear as From: and
  first Signed-off-by, you add your Signed-off-by after, to indicate
  that you're conveying the patch

- You want to make yourself the author because you made substantial
  changes: you must appear as From: and first Signed-off-by, and then
  you can put a Co-Developed-By: or something like that to credit the
  original author.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot