From: Jakub Kicinski <kuba@kernel.org>
To: Daniel Golle <daniel@makrotopia.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: phy: skip LED triggers on PHYs on SFP modules
Date: Thu, 14 Dec 2023 18:31:23 -0800 [thread overview]
Message-ID: <20231214183123.0f0af377@kernel.org> (raw)
In-Reply-To: <102a9dce38bdf00215735d04cd4704458273ad9c.1702339354.git.daniel@makrotopia.org>
On Tue, 12 Dec 2023 00:05:35 +0000 Daniel Golle wrote:
> Calling led_trigger_register() when attaching a PHY located on an SFP
> module potentially (and practically) leads into a deadlock.
> Fix this by not calling led_trigger_register() for PHYs localted on SFP
> modules as such modules actually never got any LEDs.
Any suggestion of a Fixes tag?
Looks like the triggers were added a while back, are we only seeing it
now because we started exercising the code more?
next prev parent reply other threads:[~2023-12-15 2:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 0:05 [PATCH net] net: phy: skip LED triggers on PHYs on SFP modules Daniel Golle
2023-12-12 14:35 ` Maxime Chevallier
2023-12-13 9:08 ` Andrew Lunn
2023-12-13 10:06 ` Maxime Chevallier
2023-12-13 10:47 ` Andrew Lunn
2023-12-13 15:35 ` Russell King (Oracle)
2023-12-13 15:27 ` Russell King (Oracle)
2023-12-13 17:12 ` Maxime Chevallier
2023-12-13 19:01 ` Daniel Golle
2023-12-13 20:23 ` Russell King (Oracle)
2023-12-14 9:48 ` Paolo Abeni
2023-12-14 16:52 ` Russell King (Oracle)
2023-12-15 9:46 ` Andrew Lunn
2023-12-15 9:59 ` Maxime Chevallier
2023-12-15 15:39 ` Maxime Chevallier
2023-12-15 2:31 ` Jakub Kicinski [this message]
2023-12-15 2:54 ` Daniel Golle
2023-12-15 9:53 ` Andrew Lunn
2023-12-15 16:45 ` Russell King (Oracle)
2023-12-16 2:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231214183123.0f0af377@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.