From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Julia Lawall <julia.lawall@inria.fr>
Subject: drivers/net/ethernet/marvell/sky2.c:4298:11-12: WARNING opportunity for min()
Date: Thu, 14 Dec 2023 23:01:55 +0800 [thread overview]
Message-ID: <202312142203.fdlM62DP-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Heiner Kallweit <hkallweit1@gmail.com>
CC: Stephen Hemminger <stephen@networkplumber.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 5bd7ef53ffe5ca580e93e74eb8c81ed191ddc4bd
commit: 92e888bc6f1b84cb4dee23d768777362221be1d4 sky2: use PCI VPD API in eeprom ethtool ops
date: 2 years, 1 month ago
:::::: branch date: 20 hours ago
:::::: commit date: 2 years, 1 month ago
config: x86_64-randconfig-102-20231210 (https://download.01.org/0day-ci/archive/20231214/202312142203.fdlM62DP-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20231214/202312142203.fdlM62DP-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Julia Lawall <julia.lawall@inria.fr>
| Closes: https://lore.kernel.org/r/202312142203.fdlM62DP-lkp@intel.com/
cocci warnings: (new ones prefixed by >>)
>> drivers/net/ethernet/marvell/sky2.c:4298:11-12: WARNING opportunity for min()
vim +4298 drivers/net/ethernet/marvell/sky2.c
f4331a6d24f2e55 drivers/net/sky2.c Stephen Hemminger 2007-07-09 4285
f4331a6d24f2e55 drivers/net/sky2.c Stephen Hemminger 2007-07-09 4286 static int sky2_set_eeprom(struct net_device *dev, struct ethtool_eeprom *eeprom,
f4331a6d24f2e55 drivers/net/sky2.c Stephen Hemminger 2007-07-09 4287 u8 *data)
f4331a6d24f2e55 drivers/net/sky2.c Stephen Hemminger 2007-07-09 4288 {
f4331a6d24f2e55 drivers/net/sky2.c Stephen Hemminger 2007-07-09 4289 struct sky2_port *sky2 = netdev_priv(dev);
92e888bc6f1b84c drivers/net/ethernet/marvell/sky2.c Heiner Kallweit 2021-11-18 4290 int rc;
f4331a6d24f2e55 drivers/net/sky2.c Stephen Hemminger 2007-07-09 4291
f4331a6d24f2e55 drivers/net/sky2.c Stephen Hemminger 2007-07-09 4292 if (eeprom->magic != SKY2_EEPROM_MAGIC)
f4331a6d24f2e55 drivers/net/sky2.c Stephen Hemminger 2007-07-09 4293 return -EINVAL;
f4331a6d24f2e55 drivers/net/sky2.c Stephen Hemminger 2007-07-09 4294
92e888bc6f1b84c drivers/net/ethernet/marvell/sky2.c Heiner Kallweit 2021-11-18 4295 rc = pci_write_vpd_any(sky2->hw->pdev, eeprom->offset, eeprom->len,
92e888bc6f1b84c drivers/net/ethernet/marvell/sky2.c Heiner Kallweit 2021-11-18 4296 data);
f4331a6d24f2e55 drivers/net/sky2.c Stephen Hemminger 2007-07-09 4297
92e888bc6f1b84c drivers/net/ethernet/marvell/sky2.c Heiner Kallweit 2021-11-18 @4298 return rc < 0 ? rc : 0;
f4331a6d24f2e55 drivers/net/sky2.c Stephen Hemminger 2007-07-09 4299 }
f4331a6d24f2e55 drivers/net/sky2.c Stephen Hemminger 2007-07-09 4300
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2023-12-14 15:02 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202312142203.fdlM62DP-lkp@intel.com \
--to=lkp@intel.com \
--cc=julia.lawall@inria.fr \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.