All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Philip Müller" <philm@manjaro.org>
Cc: "Berg, Johannes" <johannes.berg@intel.com>,
	"Léo Lam" <leo@leolam.fr>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [Regression] 6.1.66, 6.6.5 - wifi: cfg80211: fix CQM for non-range use
Date: Thu, 14 Dec 2023 12:59:10 +0100	[thread overview]
Message-ID: <2023121450-habitual-transpose-68a1@gregkh> (raw)
In-Reply-To: <779818b0-5175-449f-93fb-6e76166a325f@manjaro.org>

On Thu, Dec 14, 2023 at 03:32:47PM +0700, Philip Müller wrote:
> On 14.12.23 15:24, Berg, Johannes wrote:
> > > > > So Greg, how we move forward with this one? Keep the revert or
> > > > > integrate Leo's work on top of Johannes'?
> > > > 
> > > > It would be "resend with the fixes rolled in as a new backport".
> > > 
> > > No, the new change needs to be a seprate commit.
> > 
> > Oh, I stand corrected. I thought you said earlier you'd prefer a new, fixed, backport of the change that was meant to fix CQM but broke the locking, rather than two new commits.
> > 
> > > > > Johannes, how important is your fix for the stable 6.x kernels when
> > > > > done properly?
> > > > 
> > > > Well CQM was broken completely for anything but (effectively) brcmfmac ...
> > > That means roaming decisions will be less optimal, mostly.
> > > > 
> > > > Is that annoying? Probably. Super critical? I guess not.
> > > 
> > > Is it a regression or was it always like this?
> > 
> > It was a regression.
> > 
> > johannes
> 
> So basically the reversed patch by Johannes gets re-applied as it was and
> Leo's patch added to the series of patches to fix it. That is the way I
> currently ship it in my kernels so far.

Great, can someone please send the series like this with your:

> We can add a Tested-by from my end if wanted.

that would be wonderful.

greg k-h


  reply	other threads:[~2023-12-14 11:59 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-11  9:02 [Regression] 6.1.66, 6.6.5 - wifi: cfg80211: fix CQM for non-range use Philip Müller
2023-12-11  9:25 ` Greg Kroah-Hartman
2023-12-11  9:26   ` Philip Müller
2023-12-11  9:39     ` Greg Kroah-Hartman
2023-12-11  9:40       ` Greg Kroah-Hartman
2023-12-11  9:46         ` Philip Müller
2023-12-11 10:17           ` Philip Müller
2023-12-11 11:50             ` Greg Kroah-Hartman
2023-12-11 20:58       ` Berg, Johannes
2023-12-11 22:26         ` Philip Müller
2023-12-13 23:38           ` Philip Müller
2023-12-14  8:05             ` Berg, Johannes
2023-12-14  8:18               ` Greg Kroah-Hartman
2023-12-14  8:24                 ` Berg, Johannes
2023-12-14  8:32                   ` Philip Müller
2023-12-14 11:59                     ` Greg Kroah-Hartman [this message]
2023-12-16 10:47                       ` Philip Müller
2023-12-16 17:58                         ` Léo Lam
2024-01-03  3:45                           ` Philip Müller
2024-01-03 10:09                             ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2023121450-habitual-transpose-68a1@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=johannes.berg@intel.com \
    --cc=leo@leolam.fr \
    --cc=philm@manjaro.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.