All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Jijie Shao <shaojijie@huawei.com>
Cc: yisen.zhuang@huawei.com, salil.mehta@huawei.com,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, shenjian15@huawei.com, wangjie125@huawei.com,
	liuyonglong@huawei.com, lanhao@huawei.com,
	wangpeiyang1@huawei.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 net-next 3/3] net: hns3: support dump pfc frame statistics in tx timeout log
Date: Fri, 15 Dec 2023 08:03:40 +0000	[thread overview]
Message-ID: <20231215080340.GW5817@kernel.org> (raw)
In-Reply-To: <20231214141135.613485-4-shaojijie@huawei.com>

On Thu, Dec 14, 2023 at 10:11:35PM +0800, Jijie Shao wrote:
> Continuous pfc frames may cause tx timeout.
> Therefore, pfc frame statistics are added to logs.
> 
> Signed-off-by: Jijie Shao <shaojijie@huawei.com>

Thanks,

I agree it is good to include this information, which may relate to a
timeout, in the existing log message for timeouts.

Reviewed-by: Simon Horman <horms@kernel.org>

      reply	other threads:[~2023-12-15  8:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-14 14:11 [PATCH V2 net-next 0/3] There are some features for the HNS3 ethernet driver Jijie Shao
2023-12-14 14:11 ` [PATCH V2 net-next 1/3] net: hns3: add command queue trace for hns3 Jijie Shao
2023-12-14 21:04   ` Simon Horman
2023-12-16  1:42     ` Jijie Shao
2023-12-14 14:11 ` [PATCH V2 net-next 2/3] net: hns3: dump more reg info based on ras mod Jijie Shao
2023-12-15  8:01   ` Simon Horman
2023-12-16  1:37     ` Jijie Shao
2023-12-14 14:11 ` [PATCH V2 net-next 3/3] net: hns3: support dump pfc frame statistics in tx timeout log Jijie Shao
2023-12-15  8:03   ` Simon Horman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231215080340.GW5817@kernel.org \
    --to=horms@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=lanhao@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liuyonglong@huawei.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=salil.mehta@huawei.com \
    --cc=shaojijie@huawei.com \
    --cc=shenjian15@huawei.com \
    --cc=wangjie125@huawei.com \
    --cc=wangpeiyang1@huawei.com \
    --cc=yisen.zhuang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.