All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Disseldorp <ddiss@suse.de>
To: Naohiro Aota <naohiro.aota@wdc.com>
Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] fstests: filter.btrfs: update _filter_transaction_commit()
Date: Fri, 15 Dec 2023 15:23:18 +1100	[thread overview]
Message-ID: <20231215152318.78149dec@echidna> (raw)
In-Reply-To: <20231215030951.449252-1-naohiro.aota@wdc.com>

On Fri, 15 Dec 2023 12:09:51 +0900, Naohiro Aota wrote:
...
> diff --git a/common/filter.btrfs b/common/filter.btrfs
> index 02c6b92dfa94..cea9911448eb 100644
> --- a/common/filter.btrfs
> +++ b/common/filter.btrfs
> @@ -70,6 +70,7 @@ _filter_btrfs_device_stats()
>  
>  _filter_transaction_commit() {
>  	sed -e "/Transaction commit: none (default)/d" | \
> +	sed -e "s/Delete subvolume [0-9]\+/Delete subvolume/g" | \
>  	sed -e "s/Delete subvolume (.*commit):/Delete subvolume/g"
>  }
>  


Looks fine
Reviewed-by: David Disseldorp <ddiss@suse.de>

Nit: the pipe chain can be removed. It might also be a little simpler
if each version had an independent filter, e.g.
  sed -e "/Transaction commit: none (default)/d" \
      -e "s/Delete subvolume [0-9]\+ (.*commit)/Delete subvolume/g" \
      -e "s/Delete subvolume (.*commit):/Delete subvolume/g"

  reply	other threads:[~2023-12-15  4:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-15  3:09 [PATCH] fstests: filter.btrfs: update _filter_transaction_commit() Naohiro Aota
2023-12-15  4:23 ` David Disseldorp [this message]
2023-12-15  4:59   ` Zorro Lang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231215152318.78149dec@echidna \
    --to=ddiss@suse.de \
    --cc=fstests@vger.kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=naohiro.aota@wdc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.