From: Stefan Haberland <sth@linux.ibm.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org,
Jan Hoeppner <hoeppner@linux.ibm.com>,
linux-s390@vger.kernel.org, Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>
Subject: [PATCH 04/10] s390/dasd: Move allocation error message to DBF
Date: Fri, 15 Dec 2023 16:28:04 +0100 [thread overview]
Message-ID: <20231215152809.882602-5-sth@linux.ibm.com> (raw)
In-Reply-To: <20231215152809.882602-1-sth@linux.ibm.com>
From: Jan Höppner <hoeppner@linux.ibm.com>
All error messages for a failling dasd_smalloc_request() call are logged
via DBF, except one. There is no value in logging this particular
allocation failure via dev_err(). Move the message to DBF, too, to be
in line with the rest.
Signed-off-by: Jan Höppner <hoeppner@linux.ibm.com>
Reviewed-by: Stefan Haberland <sth@linux.ibm.com>
Signed-off-by: Stefan Haberland <sth@linux.ibm.com>
---
drivers/s390/block/dasd.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/s390/block/dasd.c b/drivers/s390/block/dasd.c
index 2e084fd8e520..60e666b7ca05 100644
--- a/drivers/s390/block/dasd.c
+++ b/drivers/s390/block/dasd.c
@@ -3969,10 +3969,8 @@ static struct dasd_ccw_req *dasd_generic_build_rdc(struct dasd_device *device,
NULL);
if (IS_ERR(cqr)) {
- /* internal error 13 - Allocating the RDC request failed*/
- dev_err(&device->cdev->dev,
- "An error occurred in the DASD device driver, "
- "reason=%s\n", "13");
+ DBF_EVENT_DEVID(DBF_WARNING, device->cdev, "%s",
+ "Could not allocate RDC request");
return cqr;
}
--
2.40.1
next prev parent reply other threads:[~2023-12-15 15:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-15 15:28 [PATCH 00/10] s390/dasd: string handling cleanups Stefan Haberland
2023-12-15 15:28 ` [PATCH 01/10] s390/dasd: Simplify uid string generation Stefan Haberland
2023-12-15 15:28 ` [PATCH 02/10] s390/dasd: Use sysfs_emit() over sprintf() Stefan Haberland
2023-12-15 15:28 ` [PATCH 03/10] s390/dasd: Remove unnecessary errorstring generation Stefan Haberland
2023-12-15 15:28 ` Stefan Haberland [this message]
2023-12-15 15:28 ` [PATCH 05/10] s390/dasd: Remove unused message logging macros Stefan Haberland
2023-12-15 15:28 ` [PATCH 06/10] s390/dasd: Use dev_err() over printk() Stefan Haberland
2023-12-15 15:28 ` [PATCH 07/10] s390/dasd: Remove %p format specifier from error messages Stefan Haberland
2023-12-15 15:28 ` [PATCH 08/10] s390/dasd: Remove PRINTK_HEADER and KMSG_COMPONENT definitions Stefan Haberland
2023-12-15 15:28 ` [PATCH 09/10] s390/dasd: Use dev_*() for device log messages Stefan Haberland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231215152809.882602-5-sth@linux.ibm.com \
--to=sth@linux.ibm.com \
--cc=axboe@kernel.dk \
--cc=borntraeger@de.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=hoeppner@linux.ibm.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.