From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6640FDDAF; Sat, 16 Dec 2023 04:12:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id ED12168B05; Sat, 16 Dec 2023 05:12:21 +0100 (CET) Date: Sat, 16 Dec 2023 05:12:21 +0100 From: Christoph Hellwig To: Josef Bacik Cc: Christoph Hellwig , Eric Biggers , Christian Brauner , linux-f2fs-devel@lists.sourceforge.net, linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org Subject: Re: [f2fs-dev] [PATCH 1/3] btrfs: call btrfs_close_devices from ->kill_sb Message-ID: <20231216041221.GA8850@lst.de> References: <20231213040018.73803-1-ebiggers@kernel.org> <20231213040018.73803-2-ebiggers@kernel.org> <20231213084123.GA6184@lst.de> <20231215214550.GB883762@perftesting> Precedence: bulk X-Mailing-List: linux-btrfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231215214550.GB883762@perftesting> User-Agent: Mutt/1.5.17 (2007-11-01) On Fri, Dec 15, 2023 at 04:45:50PM -0500, Josef Bacik wrote: > I ran it through, you broke a test that isn't upstream yet to test the old mount > api double mount thing that I have a test for > > https://github.com/btrfs/fstests/commit/2796723e77adb0f9da1059acf13fc402467f7ac4 > > In this case we end up leaking a reference on the fs_devices. If you add this > fixup to "btrfs: call btrfs_close_devices from ->kill_sb" it fixes that failure. > I'm re-running with that fixup applied, but I assume the rest is fine. Thanks, Is "this fixup" referring to a patch that was supposed to be attached but is't? :) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6B956C46CA2 for ; Sat, 16 Dec 2023 04:12:42 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1rEM2Y-0003sT-Vx; Sat, 16 Dec 2023 04:12:39 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rEM2W-0003sN-Ri for linux-f2fs-devel@lists.sourceforge.net; Sat, 16 Dec 2023 04:12:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=kRU4cn2DRyLUD/bI43KtM26WoUSlojIWqOSiVAfHiMA=; b=aXx26e4Vwrpoe+YbqTGvrmppy1 NDoaB+GMgtC8roOagyYyDJGxIg468xdI8+Xq86w8uFSZCI9eyM9r8yvFuMbnZQdvW+jzP+Gq0Szn5 vjSLGs47cEHAVoz4o6K8XRbUEH566S2yGw1xJ21F0WiMEcddUCHx2sCC7POrDz0YYzss=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=kRU4cn2DRyLUD/bI43KtM26WoUSlojIWqOSiVAfHiMA=; b=P6fp9ICMjZhzXlRonnqo/fet9W NVRuzIst//Y1VKkfnHsuiUaECOzNg+WLgguIAiADV2yTsPVi+e5I9Wktd1dKH73pgbTWKL6GrYU0u afAZoXxRkU1fl0W3tZCVBH3hxT+8o+Xo4TNDhs26eFx7wgfFF39VeEuxT477rAohWoeU=; Received: from verein.lst.de ([213.95.11.211]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1rEM2V-0000Fo-34 for linux-f2fs-devel@lists.sourceforge.net; Sat, 16 Dec 2023 04:12:37 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id ED12168B05; Sat, 16 Dec 2023 05:12:21 +0100 (CET) Date: Sat, 16 Dec 2023 05:12:21 +0100 From: Christoph Hellwig To: Josef Bacik Message-ID: <20231216041221.GA8850@lst.de> References: <20231213040018.73803-1-ebiggers@kernel.org> <20231213040018.73803-2-ebiggers@kernel.org> <20231213084123.GA6184@lst.de> <20231215214550.GB883762@perftesting> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231215214550.GB883762@perftesting> User-Agent: Mutt/1.5.17 (2007-11-01) X-Headers-End: 1rEM2V-0000Fo-34 Subject: Re: [f2fs-dev] [PATCH 1/3] btrfs: call btrfs_close_devices from ->kill_sb X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Christian Brauner , linux-f2fs-devel@lists.sourceforge.net, Eric Biggers , linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org, Christoph Hellwig , linux-btrfs@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Fri, Dec 15, 2023 at 04:45:50PM -0500, Josef Bacik wrote: > I ran it through, you broke a test that isn't upstream yet to test the old mount > api double mount thing that I have a test for > > https://github.com/btrfs/fstests/commit/2796723e77adb0f9da1059acf13fc402467f7ac4 > > In this case we end up leaking a reference on the fs_devices. If you add this > fixup to "btrfs: call btrfs_close_devices from ->kill_sb" it fixes that failure. > I'm re-running with that fixup applied, but I assume the rest is fine. Thanks, Is "this fixup" referring to a patch that was supposed to be attached but is't? :) _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel