From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: Joshua Watt <JPEWhacker@gmail.com>,
openembedded-core@lists.openembedded.org, ross.burton@arm.com,
raj.khem@gmail.com
Subject: Re: [OE-core][PATCH] ipk: Switch to using zstd compression
Date: Mon, 18 Dec 2023 12:05:26 +0100 [thread overview]
Message-ID: <20231218110526aa418fee@mail.local> (raw)
In-Reply-To: <7c7052bbd533d3357b9c679736b7c40985a6b227.camel@linuxfoundation.org>
On 15/12/2023 22:48:51+0000, Richard Purdie wrote:
> On Fri, 2023-12-15 at 13:51 -0700, Joshua Watt wrote:
> >
> > @@ -337,7 +335,7 @@ CONVERSION_CMD:lz4 = "lz4 -9 -z -l ${IMAGE_NAME}.${type} ${IMAGE_NAME}.${type}.l
> > CONVERSION_CMD:lzo = "lzop -9 ${IMAGE_NAME}.${type}"
> > CONVERSION_CMD:zip = "zip ${ZIP_COMPRESSION_LEVEL} ${IMAGE_NAME}.${type}.zip ${IMAGE_NAME}.${type}"
> > CONVERSION_CMD:7zip = "7za a -mx=${7ZIP_COMPRESSION_LEVEL} -mm=${7ZIP_COMPRESSION_METHOD} ${IMAGE_NAME}.${type}.${7ZIP_EXTENSION} ${IMAGE_NAME}.${type}"
> > -CONVERSION_CMD:zst = "zstd -f -k -T0 -c ${ZSTD_COMPRESSION_LEVEL} ${IMAGE_NAME}.${type} > ${IMAGE_NAME}.${type}.zst"
> > +CONVERSION_CMD:zst = "zstd -f -k -c ${ZSTD_DEFAULTS} ${IMAGE_NAME}.${type} > ${IMAGE_NAME}.${type}.zst"
> > CONVERSION_CMD:sum = "sumtool -i ${IMAGE_NAME}.${type} -o ${IMAGE_NAME}.${type}.sum ${JFFS2_SUM_EXTRA_ARGS}"
> > CONVERSION_CMD:md5sum = "md5sum ${IMAGE_NAME}.${type} > ${IMAGE_NAME}.${type}.md5sum"
> > CONVERSION_CMD:sha1sum = "sha1sum ${IMAGE_NAME}.${type} > ${IMAGE_NAME}.${type}.sha1sum"
> > diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> > index 55166d01784..4b1fe28c85a 100644
> > --- a/meta/conf/bitbake.conf
> > +++ b/meta/conf/bitbake.conf
> > @@ -878,6 +878,10 @@ XZ_DEFAULTS[vardepsexclude] += "XZ_MEMLIMIT XZ_THREADS"
> > ZSTD_THREADS ?= "${@oe.utils.cpu_count(at_least=2)}"
> > ZSTD_THREADS[vardepvalue] = "1"
> >
> > +ZSTD_COMPRESSION_LEVEL ?= "-3"
> > +ZSTD_DEFAULTS ?= "--threads=${ZSTD_THREADS} ${ZSTD_COMPRESSION_LEVEL}"
> > +ZSTD_DEFAULTS[vardepsexclude] = "ZSTD_COMPRESSION_LEVEL ZSTD_THREADS"
> > +
>
> Threads, sure but the compression level does change the output...
Indeed: https://autobuilder.yoctoproject.org/typhoon/#/builders/117/builds/4098/steps/12/logs/stdio
>
> Cheers,
>
> Richard
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#192550): https://lists.openembedded.org/g/openembedded-core/message/192550
> Mute This Topic: https://lists.openembedded.org/mt/103198693/3617179
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alexandre.belloni@bootlin.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2023-12-18 11:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-15 20:51 [OE-core][PATCH] ipk: Switch to using zstd compression Joshua Watt
2023-12-15 22:48 ` Richard Purdie
2023-12-18 11:05 ` Alexandre Belloni [this message]
2023-12-18 12:24 ` Etienne Cordonnier
2023-12-18 15:37 ` [OE-core][PATCH v2] " Joshua Watt
2023-12-20 7:47 ` Alexandre Belloni
2023-12-20 21:31 ` [OE-core][PATCH v3] " Joshua Watt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231218110526aa418fee@mail.local \
--to=alexandre.belloni@bootlin.com \
--cc=JPEWhacker@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=raj.khem@gmail.com \
--cc=richard.purdie@linuxfoundation.org \
--cc=ross.burton@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.