From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 474DC3714D for ; Mon, 18 Dec 2023 11:49:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="C80ZJkxi" Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-5cd51c0e8ebso972281a12.3 for ; Mon, 18 Dec 2023 03:49:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702900147; x=1703504947; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=WFiECuxQKf4bQHzOWrQB9O9iOx/6SZrLhJKr/Z2J67E=; b=C80ZJkxiwR9Zm0ZsEKM8BmKcnvSLYCkhtK1dQvnDmoi9wbVvIeHxftsgmgH0afTE7u tv86Bo8M8rIqdWJYLKfhlF5aJeO4RaxULPRK75GlvL7OpGIe7LDthzkcV6e73mekVU+K eG0YxNCQ7FYoSsNsMCb41ntmlKlvGjbHxQM/W0tDIxGbG/wYPKt380CkOa1ZGzZkJu6P yqa73Vg7lgWCGGbwj8f3fEOTg8Y8lEhhERQSkXuIB6xlzRlXrXNec9PpvtVmP9U7r6LO EqEawO8Cry1p56dNMBPbO31C9vlWGCiOn/NA7T4Lid2Pi+4cJCeM0Q3VGXhWAqyPgGuw pBLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702900147; x=1703504947; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WFiECuxQKf4bQHzOWrQB9O9iOx/6SZrLhJKr/Z2J67E=; b=o7j4BCVtsUCqyuSvetrQYJCUP1bQCzcqsJrep7ko45gl+F6fZAIU4g9pRmHPk8AUvp 37IVHneZ2BJaWp6A+2X1+M/WlTlShTHMKSdDEp3+NnceU2f+8ir1oHP+AVxQr1Feu0Um 4MRp6veUxihKzmVXGRpWvuIeBK5dO91fZUZ1ep1v7b/jc+A/6qhIab3c3P8S1IPoYTFe h2u8+Ah4w0vy/hjN8eBrVh5oJDwqXC97tgtnlDmUiHvSOw7Rx2xN3CazR+CIrspOZ7Ea f5yhTEUJ7AWMXHSjTgWmL0Qyz9d8GRHpSKLHHIOpd/aHZhgpZZUZcQo7YhKUe3idKWgC Tpqg== X-Gm-Message-State: AOJu0Yxg5T75IjgZoKG/XaFqrbY8v5Ry96AMcwG0qeaUzP+CaCHx1OIZ 8baQdPd/hDCGvaltoqxfB16g X-Google-Smtp-Source: AGHT+IFNm7vnn6dj9ZJCS5JUQjewTTJwImMcXsK4yzYDnO65BIHPMtdEVIr3bR2Db4u/3gv4EFWJDQ== X-Received: by 2002:a05:6a20:3d81:b0:190:c314:35f8 with SMTP id s1-20020a056a203d8100b00190c31435f8mr7847690pzi.46.1702900147590; Mon, 18 Dec 2023 03:49:07 -0800 (PST) Received: from thinkpad ([117.207.27.21]) by smtp.gmail.com with ESMTPSA id ha9-20020a17090af3c900b0028b8bb9e5cbsm1526025pjb.25.2023.12.18.03.49.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Dec 2023 03:49:07 -0800 (PST) Date: Mon, 18 Dec 2023 17:18:58 +0530 From: Manivannan Sadhasivam To: Rob Herring Cc: andersson@kernel.org, konrad.dybcio@linaro.org, vkoul@kernel.org, sboyd@kernel.org, mturquette@baylibre.com, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 01/16] dt-bindings: phy: qmp-ufs: Fix PHY clocks Message-ID: <20231218114858.GA2900@thinkpad> References: <20231214091101.45713-1-manivannan.sadhasivam@linaro.org> <20231214091101.45713-2-manivannan.sadhasivam@linaro.org> <20231214172051.GA611674-robh@kernel.org> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231214172051.GA611674-robh@kernel.org> On Thu, Dec 14, 2023 at 11:20:51AM -0600, Rob Herring wrote: > On Thu, Dec 14, 2023 at 02:40:46PM +0530, Manivannan Sadhasivam wrote: > > All QMP UFS PHYs except MSM8996 require 3 clocks: > > > > * ref - 19.2MHz reference clock from RPMh > > * ref_aux - Auxiliary reference clock from GCC > > * qref - QREF clock from GCC or TCSR (since SM8550) > > > > MSM8996 only requires 'ref' and 'qref' clocks. Hence, fix the binding to > > reflect the actual clock topology. > > Breaking the ABI is okay because...? Please explain in the commit msg. > I will update the commit message in v2. - Mani > Rob > -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 70A90C35274 for ; Mon, 18 Dec 2023 11:49:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fi1TiO+Yq/nQIHgvdSGfOCThpCOIazLVxXBx7qnp0us=; b=NzFDzTp/C0kBvP bZgG3+RuclFAHhTvHrV3aOTajPZO3yknGYLZEZGvWrieBIgMILzUYd9jio14FozISNg57iEk5F4oz Sk789JQHYFUjiKYzB3iWhSCatsZPt4jKHQOotaixkzqOuLq5pBojOsjmeyf+HxKuo5EtFFv8aPo2Y VonzPFHgfiB7tFkUP01kYyYrhB5SSCTV8uycViJsR1xS9QWPLAOnsRpyqbKoewbCaGgNXF7N7Rrel 2sIKEoTWhjpVEurlqSRRheXgD/+HLvwGG95us4P02w4dziXnLPzDRvNAIcHc+WOVI/tjB8hQkHmix NU3lUbrgzLHpZ64rXaDw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rFC7V-00ALuF-09; Mon, 18 Dec 2023 11:49:13 +0000 Received: from mail-pg1-x532.google.com ([2607:f8b0:4864:20::532]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rFC7R-00ALqY-1D for linux-phy@lists.infradead.org; Mon, 18 Dec 2023 11:49:10 +0000 Received: by mail-pg1-x532.google.com with SMTP id 41be03b00d2f7-5cd51c0e8ebso972282a12.3 for ; Mon, 18 Dec 2023 03:49:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702900147; x=1703504947; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=WFiECuxQKf4bQHzOWrQB9O9iOx/6SZrLhJKr/Z2J67E=; b=IsUnI97yGKWqIOdURjSXzCMXbZDtJhCKdFyye75YLoR3dXNf8SfaxEKVhah7fe/C/E IjdxtD7FhsEclp3wmrz48P/AzVRqYRxs/sIMLbquvBI1/QDkv4pTwTTvEjNQHAnblXpN HUct7InRwvJ6RvhX79VWEb9GY8kzCWaYyyyNSIWius8tcZuo2Y1eEFQQJeygZgRPopf0 s4PDysOxv9szHFjGjueRfLTUwnr+bRpUykXhS8B4HAdxfXqSBvkNfmsfGKt76381cbkc 9QxRoob2qO0si64ZK8gcjmgT7vcANtVW7wJeziq3eFBuliMNFNzL7RBJmw6AuRaTVUh0 Ddrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702900147; x=1703504947; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WFiECuxQKf4bQHzOWrQB9O9iOx/6SZrLhJKr/Z2J67E=; b=SXmzwo7XhQQZWXGL1G9OmU6A83N1lAbZj7puRGyL09M5aHDE44SDRI1mtp9HJTfmAA cFE6bK1sx0pk+mcP/UuzUCv0mEdR1FdLvd76sAWdRLqGF+LWcMZKxAkOSeia1cBnj/Ch VpxRSr8TmrFIS9YJSs1uiZPqTc4FEMIMvHOVW1dO6z5jWpHP3mxVRSDacCRGQzIwSm6t O2STA4EXrID4C56LvnXPn6vDdm9HB3OLdIHjSJKupZz4mQ6hIjsxIft/5/TaIlqY72Xx F4PWccyjKgpivYbnHB7Nthc/WgBjCXIUt/ifYvlCT6k+4a2MP2hwVc4e4Mk4ph03OhwU kobA== X-Gm-Message-State: AOJu0Yym/lnd8QDCbpwfyuLYrAZsmoKP0Vq3V2kLZjzdfaISmvrv15NP vYmjGUstyt1zQil9Ze+9jDTF X-Google-Smtp-Source: AGHT+IFNm7vnn6dj9ZJCS5JUQjewTTJwImMcXsK4yzYDnO65BIHPMtdEVIr3bR2Db4u/3gv4EFWJDQ== X-Received: by 2002:a05:6a20:3d81:b0:190:c314:35f8 with SMTP id s1-20020a056a203d8100b00190c31435f8mr7847690pzi.46.1702900147590; Mon, 18 Dec 2023 03:49:07 -0800 (PST) Received: from thinkpad ([117.207.27.21]) by smtp.gmail.com with ESMTPSA id ha9-20020a17090af3c900b0028b8bb9e5cbsm1526025pjb.25.2023.12.18.03.49.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Dec 2023 03:49:07 -0800 (PST) Date: Mon, 18 Dec 2023 17:18:58 +0530 From: Manivannan Sadhasivam To: Rob Herring Cc: andersson@kernel.org, konrad.dybcio@linaro.org, vkoul@kernel.org, sboyd@kernel.org, mturquette@baylibre.com, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 01/16] dt-bindings: phy: qmp-ufs: Fix PHY clocks Message-ID: <20231218114858.GA2900@thinkpad> References: <20231214091101.45713-1-manivannan.sadhasivam@linaro.org> <20231214091101.45713-2-manivannan.sadhasivam@linaro.org> <20231214172051.GA611674-robh@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231214172051.GA611674-robh@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231218_034909_477525_555C7C8A X-CRM114-Status: UNSURE ( 9.40 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org T24gVGh1LCBEZWMgMTQsIDIwMjMgYXQgMTE6MjA6NTFBTSAtMDYwMCwgUm9iIEhlcnJpbmcgd3Jv dGU6Cj4gT24gVGh1LCBEZWMgMTQsIDIwMjMgYXQgMDI6NDA6NDZQTSArMDUzMCwgTWFuaXZhbm5h biBTYWRoYXNpdmFtIHdyb3RlOgo+ID4gQWxsIFFNUCBVRlMgUEhZcyBleGNlcHQgTVNNODk5NiBy ZXF1aXJlIDMgY2xvY2tzOgo+ID4gCj4gPiAqIHJlZiAtIDE5LjJNSHogcmVmZXJlbmNlIGNsb2Nr IGZyb20gUlBNaAo+ID4gKiByZWZfYXV4IC0gQXV4aWxpYXJ5IHJlZmVyZW5jZSBjbG9jayBmcm9t IEdDQwo+ID4gKiBxcmVmIC0gUVJFRiBjbG9jayBmcm9tIEdDQyBvciBUQ1NSIChzaW5jZSBTTTg1 NTApCj4gPiAKPiA+IE1TTTg5OTYgb25seSByZXF1aXJlcyAncmVmJyBhbmQgJ3FyZWYnIGNsb2Nr cy4gSGVuY2UsIGZpeCB0aGUgYmluZGluZyB0bwo+ID4gcmVmbGVjdCB0aGUgYWN0dWFsIGNsb2Nr IHRvcG9sb2d5Lgo+IAo+IEJyZWFraW5nIHRoZSBBQkkgaXMgb2theSBiZWNhdXNlLi4uPyBQbGVh c2UgZXhwbGFpbiBpbiB0aGUgY29tbWl0IG1zZy4KPiAKCkkgd2lsbCB1cGRhdGUgdGhlIGNvbW1p dCBtZXNzYWdlIGluIHYyLgoKLSBNYW5pCgo+IFJvYgo+IAoKLS0gCuCuruCuo+Cuv+CuteCuo+Cv jeCuo+CuqeCvjSDgrprgrqTgrr7grprgrr/grrXgrq7gr40KCi0tIApsaW51eC1waHkgbWFpbGlu ZyBsaXN0CmxpbnV4LXBoeUBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHBzOi8vbGlzdHMuaW5mcmFk ZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXBoeQo=