Re: [LTP] [PATCH v4 2/2] swapping01.c: Reporting /proc/meminfo during test

[Petr Vorel <pvorel@suse.cz>]

Hi Wei,

> Get clear overview memory status during test is good for debug, such as
> get report before the test and also at the moment of the failure.

> Signed-off-by: Wei Gao <wegao@suse.com>
> ---
>  testcases/kernel/mem/swapping/swapping01.c | 4 ++++
>  1 file changed, 4 insertions(+)

> diff --git a/testcases/kernel/mem/swapping/swapping01.c b/testcases/kernel/mem/swapping/swapping01.c
> index fc225e4a6..025f44363 100644
> --- a/testcases/kernel/mem/swapping/swapping01.c
> +++ b/testcases/kernel/mem/swapping/swapping01.c
> @@ -83,7 +83,9 @@ static void test_swapping(void)

>  	switch (pid = SAFE_FORK()) {
>  	case 0:
> +		TST_PRINT_MEMINFO();
>  		do_alloc(0);
> +		TST_PRINT_MEMINFO();
Developer asked you to print /proc/meminfo "before the test starts and at the
moment of the failure" Wouldn't be just this second TST_PRINT_MEMINFO() enough?

Kind regards,
Petr

>  		do_alloc(1);
>  		exit(0);
>  	default:
> @@ -138,6 +140,7 @@ static void check_swapping(void)
>  		swap_free_now = SAFE_READ_MEMINFO("SwapFree:");
>  		sleep(1);
>  		long diff = labs(swap_free_now - SAFE_READ_MEMINFO("SwapFree:"));
> +
>  		if (diff < 10)
>  			break;

> @@ -146,6 +149,7 @@ static void check_swapping(void)

>  	swapped = SAFE_READ_PROC_STATUS(pid, "VmSwap:");
>  	if (swapped > mem_over_max) {
> +		TST_PRINT_MEMINFO();
>  		kill(pid, SIGCONT);
>  		tst_brk(TFAIL, "heavy swapping detected: "
>  				"%ld MB swapped.", swapped / 1024);

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp