From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DBCA6C46CD3 for ; Mon, 18 Dec 2023 15:49:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jEDhLc4jQdXXTJgtSxhlyCdpiTkBcsIA12np3rAsa8Y=; b=fmcNuQaUfhkHApyk3UePhXl6nH TDHu0RX67QYuNFsuTtndXmjo2QjxVPtplrTyBbc5bcHaHDy9iL/D+ncGniPTE2G8AxUFYAmAhj3bu 1eLaqjQ0hTegUFGsoM2FLemJlygp18b4MUBfqxwdzYpX0cIiGDHqQaaKsIQK4mXFNpd/1djhxRwes Fe0ogTU8WPkFK5/rj9CRBXb2hYiDJ4ouQ4S4b97Z3oDVCMuE629/lX8VtmANXOitFa7begxgBM/cP 8swv/92NlVyo0I7z5wzbSSn3WmSk4TXDDWaUMA5OrOTmHmcurI9d1P8fqtiD/8gz8Ru+A0hLyRUfV r8IHq4qw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rFFry-00BI2J-1i; Mon, 18 Dec 2023 15:49:26 +0000 Received: from smtp-out2.suse.de ([2a07:de40:b251:101:10:150:64:2]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rFFrv-00BI0V-0L for linux-nvme@lists.infradead.org; Mon, 18 Dec 2023 15:49:24 +0000 Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [10.150.64.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 88D411FD48; Mon, 18 Dec 2023 15:49:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1702914561; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jEDhLc4jQdXXTJgtSxhlyCdpiTkBcsIA12np3rAsa8Y=; b=I1WW/2YiqJ8hfTQulgEFb5CoSJKSeekBRCgLecy5L/P68I/YNUgiUCTAv24YVZ6BWy15Dw xPd2asIL8jWv6E1fs/PxgtInhi9WqYDkk+zZf6ogvsH7f1nJYxe2Lx9zL2hqxGF3EZ/Ceh AMz4upviPFh8SDeAWjGTvU5mIQEj7kQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1702914561; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jEDhLc4jQdXXTJgtSxhlyCdpiTkBcsIA12np3rAsa8Y=; b=WVXkYC6fLXCf+XlHomWRGhXfGDDfHIc0zid4fUcE4NM/ePwwQgFtjou79jbj1eB+Hpe9uQ OfST+GZYumbPFlCA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1702914561; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jEDhLc4jQdXXTJgtSxhlyCdpiTkBcsIA12np3rAsa8Y=; b=I1WW/2YiqJ8hfTQulgEFb5CoSJKSeekBRCgLecy5L/P68I/YNUgiUCTAv24YVZ6BWy15Dw xPd2asIL8jWv6E1fs/PxgtInhi9WqYDkk+zZf6ogvsH7f1nJYxe2Lx9zL2hqxGF3EZ/Ceh AMz4upviPFh8SDeAWjGTvU5mIQEj7kQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1702914561; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jEDhLc4jQdXXTJgtSxhlyCdpiTkBcsIA12np3rAsa8Y=; b=WVXkYC6fLXCf+XlHomWRGhXfGDDfHIc0zid4fUcE4NM/ePwwQgFtjou79jbj1eB+Hpe9uQ OfST+GZYumbPFlCA== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 7B06C13BC8; Mon, 18 Dec 2023 15:49:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id Xw4QHQFqgGWSfwAAn2gu4w (envelope-from ); Mon, 18 Dec 2023 15:49:21 +0000 From: Daniel Wagner To: linux-nvme@lists.infradead.org Cc: linux-kernel@vger.kernel.org, Christoph Hellwig , Sagi Grimberg , Keith Busch , James Smart , Hannes Reinecke , Daniel Wagner Subject: [PATCH v3 07/16] nvmet-fc: Release reference on target port Date: Mon, 18 Dec 2023 16:30:55 +0100 Message-ID: <20231218153105.12717-8-dwagner@suse.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231218153105.12717-1-dwagner@suse.de> References: <20231218153105.12717-1-dwagner@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [0.79 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_MISSING_CHARSET(2.50)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; REPLY(-4.00)[]; BROKEN_CONTENT_TYPE(1.50)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCPT_COUNT_SEVEN(0.00)[8]; MID_CONTAINS_FROM(1.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-0.11)[66.19%] Authentication-Results: smtp-out2.suse.de; none X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231218_074923_317461_E06EAABD X-CRM114-Status: GOOD ( 10.36 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org In case we return early out of __nvmet_fc_finish_ls_req() we still have to release the reference on the target port. Signed-off-by: Daniel Wagner --- drivers/nvme/target/fc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/nvme/target/fc.c b/drivers/nvme/target/fc.c index bda7a3009e85..28e432e62361 100644 --- a/drivers/nvme/target/fc.c +++ b/drivers/nvme/target/fc.c @@ -360,6 +360,7 @@ __nvmet_fc_finish_ls_req(struct nvmet_fc_ls_req_op *lsop) if (!lsop->req_queued) { spin_unlock_irqrestore(&tgtport->lock, flags); + nvmet_fc_tgtport_put(tgtport); return; } -- 2.43.0