From: kernel test robot <lkp@intel.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev
Subject: [bvanassche:mq-deadline 4/4] block/mq-deadline.c:222:16: error: call to undeclared function 'blk_rq_zone_no'; ISO C99 and later do not support implicit function declarations
Date: Tue, 19 Dec 2023 00:06:32 +0800 [thread overview]
Message-ID: <202312190011.JYlG3HVC-lkp@intel.com> (raw)
tree: https://github.com/bvanassche/linux mq-deadline
head: f1201b17a2fec011e8cdd6be24a413a5693941b7
commit: f1201b17a2fec011e8cdd6be24a413a5693941b7 [4/4] block/mq-deadline: Prevent zoned write reordering due to I/O prioritization
config: i386-randconfig-016-20231218 (https://download.01.org/0day-ci/archive/20231219/202312190011.JYlG3HVC-lkp@intel.com/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231219/202312190011.JYlG3HVC-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312190011.JYlG3HVC-lkp@intel.com/
All errors (new ones prefixed by >>):
>> block/mq-deadline.c:222:16: error: call to undeclared function 'blk_rq_zone_no'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
while (rq && blk_rq_zone_no(rq) == zno) {
^
1 error generated.
vim +/blk_rq_zone_no +222 block/mq-deadline.c
204
205 /*
206 * If any sequential write requests are pending for the zone containing @pos,
207 * return the I/O priority for these write requests.
208 */
209 static enum dd_prio dd_zone_prio(struct deadline_data *dd,
210 struct block_device *bdev, sector_t pos)
211 {
212 struct gendisk *disk = bdev->bd_disk;
213 const unsigned int zno = disk_zone_no(disk, pos);
214 enum dd_prio prio;
215
216 pos -= bdev_offset_from_zone_start(bdev, pos);
217 for (prio = DD_PRIO_MIN; prio <= DD_PRIO_MAX; prio++) {
218 struct dd_per_prio *per_prio = &dd->per_prio[prio];
219 struct request *rq;
220
221 rq = deadline_first_rq_past_pos(per_prio, DD_WRITE, pos);
> 222 while (rq && blk_rq_zone_no(rq) == zno) {
223 struct rb_node *node;
224
225 if (blk_rq_is_seq_zoned_write(rq))
226 return prio;
227 node = rb_next(&rq->rb_node);
228 if (!node)
229 break;
230 rq = rb_entry_rq(node);
231 }
232 }
233 return DD_INVALID_PRIO;
234 }
235
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2023-12-18 16:07 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202312190011.JYlG3HVC-lkp@intel.com \
--to=lkp@intel.com \
--cc=bvanassche@acm.org \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.