From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9ECC05380 for ; Tue, 19 Dec 2023 04:21:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 7715B68AFE; Tue, 19 Dec 2023 05:21:39 +0100 (CET) Date: Tue, 19 Dec 2023 05:21:39 +0100 From: Christoph Hellwig To: "Darrick J. Wong" Cc: Christoph Hellwig , Chandan Babu R , linux-xfs@vger.kernel.org Subject: Re: [PATCH 3/8] xfs: move the xfs_attr_sf_lookup tracepoint Message-ID: <20231219042139.GB30534@lst.de> References: <20231217170350.605812-1-hch@lst.de> <20231217170350.605812-4-hch@lst.de> <20231218223902.GC361584@frogsfrogsfrogs> Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231218223902.GC361584@frogsfrogsfrogs> User-Agent: Mutt/1.5.17 (2007-11-01) On Mon, Dec 18, 2023 at 02:39:02PM -0800, Darrick J. Wong wrote: > > - trace_xfs_attr_sf_lookup(args); > > - > > ASSERT(ifp->if_format == XFS_DINODE_FMT_LOCAL); > > sfe = &sf->list[0]; > > for (i = 0; i < sf->hdr.count; > > @@ -905,6 +903,9 @@ xfs_attr_shortform_getvalue( > > int i; > > > > ASSERT(args->dp->i_af.if_format == XFS_DINODE_FMT_LOCAL); > > + > > + trace_xfs_attr_sf_lookup(args); > > Shouldn't this get renamed to trace_xfs_attr_shortform_getvalue to match > the function? Especially since xfs_attr_shortform_lookup disappears > later, AFAICT. If we value accurate naming over being able to use a historical trace point: yes. Although in that case I'd probably structure it as a patch adding the new xfs_attr_shortform_getvalue tracepoint only, and removing the xfs_attr_sf_lookup one with the function.