From: Simon Horman <horms@kernel.org>
To: Jijie Shao <shaojijie@huawei.com>
Cc: yisen.zhuang@huawei.com, salil.mehta@huawei.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, shenjian15@huawei.com, wangjie125@huawei.com,
liuyonglong@huawei.com, lanhao@huawei.com,
wangpeiyang1@huawei.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V4 net-next 2/4] net: hns3: move constants from hclge_debugfs.h to hclge_debugfs.c
Date: Tue, 19 Dec 2023 11:14:13 +0000 [thread overview]
Message-ID: <20231219111413.GI811967@kernel.org> (raw)
In-Reply-To: <20231219013513.2589845-3-shaojijie@huawei.com>
On Tue, Dec 19, 2023 at 09:35:11AM +0800, Jijie Shao wrote:
> some constants are defined in hclge_debugfs.h,
> but only used in hclge_debugfs.c.
> so move them from hclge_debugfs.h to hclge_debugfs.c.
>
> Signed-off-by: Jijie Shao <shaojijie@huawei.com>
Thanks, I agree that these symbols belong in hclge_debugfs.c.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2023-12-19 11:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 1:35 [PATCH V4 net-next 0/4] There are some features for the HNS3 ethernet driver Jijie Shao
2023-12-19 1:35 ` [PATCH V4 net-next 1/4] net: hns3: add command queue trace for hns3 Jijie Shao
2023-12-19 1:35 ` [PATCH V4 net-next 2/4] net: hns3: move constants from hclge_debugfs.h to hclge_debugfs.c Jijie Shao
2023-12-19 11:14 ` Simon Horman [this message]
2023-12-19 1:35 ` [PATCH V4 net-next 3/4] net: hns3: dump more reg info based on ras mod Jijie Shao
2023-12-19 11:18 ` Simon Horman
2023-12-19 1:35 ` [PATCH V4 net-next 4/4] net: hns3: support dump pfc frame statistics in tx timeout log Jijie Shao
2024-01-04 11:17 ` [PATCH V4 net-next 0/4] There are some features for the HNS3 ethernet driver Jijie Shao
2024-01-04 15:48 ` Jakub Kicinski
2024-01-05 1:11 ` Jijie Shao
-- strict thread matches above, loose matches on Subject: below --
2024-01-05 1:01 Jijie Shao
2024-01-05 1:01 ` [PATCH V4 net-next 2/4] net: hns3: move constants from hclge_debugfs.h to hclge_debugfs.c Jijie Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231219111413.GI811967@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=lanhao@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyonglong@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=salil.mehta@huawei.com \
--cc=shaojijie@huawei.com \
--cc=shenjian15@huawei.com \
--cc=wangjie125@huawei.com \
--cc=wangpeiyang1@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.