From: Simon Horman <horms@kernel.org>
To: Ioana Ciornei <ioana.ciornei@nxp.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v3 5/8] dpaa2-switch: do not clear any interrupts automatically
Date: Wed, 20 Dec 2023 15:48:22 +0100 [thread overview]
Message-ID: <20231220144822.GJ882741@kernel.org> (raw)
In-Reply-To: <20231219115933.1480290-6-ioana.ciornei@nxp.com>
On Tue, Dec 19, 2023 at 01:59:30PM +0200, Ioana Ciornei wrote:
> The DPSW object has multiple event sources multiplexed over the same
> IRQ. The driver has the capability to configure only some of these
> events to trigger the IRQ.
>
> The dpsw_get_irq_status() can clear events automatically based on the
> value stored in the 'status' variable passed to it. We don't want that
> to happen because we could get into a situation when we are clearing
> more events than we actually handled.
>
> Just resort to manually clearing the events that we handled. Also, since
> status is not used on the out path we remove its initialization to zero.
>
> This change does not have a user-visible effect because the dpaa2-switch
> driver enables and handles all the DPSW events which exist at the
> moment.
>
> Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
> ---
> Changes in v3:
> - mention that the change does not have a user visible impact
> Changes in v2:
> - add a bit more info in the commit message
Thanks for these updates too.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2023-12-20 14:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 11:59 [PATCH net-next v3 0/8] dpaa2-switch: small improvements Ioana Ciornei
2023-12-19 11:59 ` [PATCH net-next v3 1/8] dpaa2-switch: set interface MAC address only on endpoint change Ioana Ciornei
2023-12-19 11:59 ` [PATCH net-next v3 2/8] dpaa2-switch: declare the netdev as IFF_LIVE_ADDR_CHANGE capable Ioana Ciornei
2023-12-19 11:59 ` [PATCH net-next v3 3/8] dpaa2-switch: print an error when the vlan is already configured Ioana Ciornei
2023-12-19 11:59 ` [PATCH net-next v3 4/8] dpaa2-switch: add ENDPOINT_CHANGED to the irq_mask Ioana Ciornei
2023-12-20 14:47 ` Simon Horman
2023-12-19 11:59 ` [PATCH net-next v3 5/8] dpaa2-switch: do not clear any interrupts automatically Ioana Ciornei
2023-12-20 14:48 ` Simon Horman [this message]
2023-12-20 15:07 ` Ioana Ciornei
2023-12-19 11:59 ` [PATCH net-next v3 6/8] dpaa2-switch: reorganize the [pre]changeupper events Ioana Ciornei
2023-12-20 14:49 ` Simon Horman
2023-12-19 11:59 ` [PATCH net-next v3 7/8] dpaa2-switch: move a check to the prechangeupper stage Ioana Ciornei
2023-12-19 11:59 ` [PATCH net-next v3 8/8] dpaa2-switch: cleanup the egress flood of an unused FDB Ioana Ciornei
2023-12-23 1:20 ` [PATCH net-next v3 0/8] dpaa2-switch: small improvements patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231220144822.GJ882741@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ioana.ciornei@nxp.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.