From: Rob Herring <robh@kernel.org>
To: Christian Marangi <ansuelsmth@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Tobias Waldekranz <tobias@waldekranz.com>
Subject: Re: [net-next PATCH v4 1/4] dt-bindings: net: phy: Document new LEDs polarity property
Date: Wed, 20 Dec 2023 09:22:09 -0600 [thread overview]
Message-ID: <20231220152209.GA229412-robh@kernel.org> (raw)
In-Reply-To: <20231215212244.1658-2-ansuelsmth@gmail.com>
On Fri, Dec 15, 2023 at 10:22:41PM +0100, Christian Marangi wrote:
> Document new LEDs polarity property to define what mode the LED needs to
> be put to turn it on.
>
> Currently supported modes are:
>
> - active-low
> - active-high
> - active-low-tristate
> - active-high-tristate
Why is having a polarity unique to LEDs on ethernet PHYs? It's not. We
already have 'active-low' established on several LED bindings. Please
move the definition to leds/common.yaml and extend it. I would simply
add an 'inactive-tristate' boolean property (if there's an actual user).
I do worry this continues to evolve until we've re-created the pinctrl
binding...
Rob
next prev parent reply other threads:[~2023-12-20 15:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-15 21:22 [net-next PATCH v4 0/4] net: phy: generic polarity + LED support for qca808x Christian Marangi
2023-12-15 21:22 ` [net-next PATCH v4 1/4] dt-bindings: net: phy: Document new LEDs polarity property Christian Marangi
2023-12-20 15:22 ` Rob Herring [this message]
2023-12-20 22:53 ` Christian Marangi
2023-12-21 9:43 ` Andrew Lunn
2023-12-22 15:20 ` Conor Dooley
2023-12-21 9:34 ` Andrew Lunn
2023-12-22 22:09 ` Christian Marangi
2023-12-15 21:22 ` [net-next PATCH v4 2/4] net: phy: add support for PHY LEDs polarity modes Christian Marangi
2023-12-15 21:22 ` [net-next PATCH v4 3/4] dt-bindings: net: Document QCA808x PHYs Christian Marangi
2023-12-15 21:22 ` [net-next PATCH v4 4/4] net: phy: at803x: add LED support for qca808x Christian Marangi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231220152209.GA229412-robh@kernel.org \
--to=robh@kernel.org \
--cc=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tobias@waldekranz.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.