From: Al Viro <viro@zeniv.linux.org.uk>
To: Baoquan He <bhe@redhat.com>
Cc: kernel test robot <lkp@intel.com>,
oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: arch/sh/kernel/relocate_kernel.S:38: Error: invalid operands for opcode
Date: Wed, 20 Dec 2023 17:37:10 +0000 [thread overview]
Message-ID: <20231220173710.GX1674809@ZenIV> (raw)
In-Reply-To: <ZYLrxFyei79R5D8N@MiWiFi-R3L-srv>
On Wed, Dec 20, 2023 at 09:27:32PM +0800, Baoquan He wrote:
> Since the kexec_core code building depends on CONFIG_MMU=y, we may
> need to add dependency on MMU for ARCH_SUPPORTS_CRASH_DUMP. I made below
> change, do you think it's OK?
>
> diff --git a/arch/sh/Kconfig b/arch/sh/Kconfig
> index 7500521b2b98..fe1500871648 100644
> --- a/arch/sh/Kconfig
> +++ b/arch/sh/Kconfig
> @@ -548,6 +548,7 @@ config ARCH_SUPPORTS_KEXEC
>
> config ARCH_SUPPORTS_CRASH_DUMP
> def_bool BROKEN_ON_SMP
> + depends on MMU
>
> config ARCH_SUPPORTS_KEXEC_JUMP
> def_bool y
>
I'm *not* familiar with crashdump or kexec machinery, let alone the
current changes in there, so take the following with a cartload of
salt, but... does sh crash dump support depend upon the code in
question? From quick grep it looks like we only want it in machine_kexec(),
so the conditionals used in the commit in question might be wrong...
next prev parent reply other threads:[~2023-12-20 17:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-18 14:55 arch/sh/kernel/relocate_kernel.S:38: Error: invalid operands for opcode kernel test robot
2023-12-20 5:44 ` Baoquan He
2023-12-20 6:00 ` Al Viro
2023-12-20 13:27 ` Baoquan He
2023-12-20 17:37 ` Al Viro [this message]
2023-12-21 4:24 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231220173710.GX1674809@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.