From: Stephen Hemminger <stephen@networkplumber.org>
To: Benjamin Poirier <bpoirier@nvidia.com>
Cc: netdev@vger.kernel.org, Petr Machata <petrm@nvidia.com>,
Roopa Prabhu <roopa@nvidia.com>
Subject: Re: [PATCH iproute2-next 01/20] bridge: vni: Accept 'del' command
Date: Wed, 20 Dec 2023 19:57:08 -0800 [thread overview]
Message-ID: <20231220195708.2f69e265@hermes.local> (raw)
In-Reply-To: <20231211140732.11475-2-bpoirier@nvidia.com>
On Mon, 11 Dec 2023 09:07:13 -0500
Benjamin Poirier <bpoirier@nvidia.com> wrote:
> `bridge vni help` shows "bridge vni { add | del } ..." but currently
> `bridge vni del ...` errors out unexpectedly:
> # bridge vni del
> Command "del" is unknown, try "bridge vni help".
>
> Recognize 'del' as a synonym of the original 'delete' command.
>
> Fixes: 45cd32f9f7d5 ("bridge: vxlan device vnifilter support")
> Reviewed-by: Petr Machata <petrm@nvidia.com>
> Tested-by: Petr Machata <petrm@nvidia.com>
> Signed-off-by: Benjamin Poirier <bpoirier@nvidia.com>
Please no.
We are blocking uses of matches() and now other commands will want more synonyms
Instead fix the help and doc.
next prev parent reply other threads:[~2023-12-21 3:57 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-11 14:07 [PATCH iproute2-next 00/20] bridge: vni: UI fixes Benjamin Poirier
2023-12-11 14:07 ` [PATCH iproute2-next 01/20] bridge: vni: Accept 'del' command Benjamin Poirier
2023-12-21 3:57 ` Stephen Hemminger [this message]
2023-12-21 16:06 ` Stephen Hemminger
2023-12-21 16:54 ` Benjamin Poirier
2023-12-21 17:24 ` Stephen Hemminger
2023-12-21 17:46 ` Benjamin Poirier
2023-12-11 14:07 ` [PATCH iproute2-next 02/20] bridge: vni: Remove dead code in group argument parsing Benjamin Poirier
2023-12-21 3:58 ` Stephen Hemminger
2023-12-11 14:07 ` [PATCH iproute2-next 03/20] bridge: vni: Fix duplicate group and remote error messages Benjamin Poirier
2023-12-21 3:59 ` Stephen Hemminger
2023-12-11 14:07 ` [PATCH iproute2-next 04/20] bridge: vni: Report duplicate vni argument using duparg() Benjamin Poirier
2023-12-21 3:59 ` Stephen Hemminger
2023-12-11 14:07 ` [PATCH iproute2-next 05/20] bridge: vni: Fix vni filter help strings Benjamin Poirier
2023-12-21 4:00 ` Stephen Hemminger
2023-12-11 14:07 ` [PATCH iproute2-next 06/20] bridge: vlan: Use printf() to avoid temporary buffer Benjamin Poirier
2023-12-21 4:03 ` Stephen Hemminger
2023-12-11 14:07 ` [PATCH iproute2-next 07/20] bridge: vlan: Remove paranoid check Benjamin Poirier
2023-12-21 4:04 ` Stephen Hemminger
2023-12-11 14:07 ` [PATCH iproute2-next 08/20] bridge: vni: Remove print_vnifilter_rtm_filter() Benjamin Poirier
2023-12-21 4:05 ` Stephen Hemminger
2023-12-11 14:07 ` [PATCH iproute2-next 09/20] bridge: vni: Move open_json_object() within print_vni() Benjamin Poirier
2023-12-21 4:06 ` Stephen Hemminger
2023-12-11 14:07 ` [PATCH iproute2-next 10/20] bridge: vni: Guard close_vni_port() call Benjamin Poirier
2023-12-21 4:07 ` Stephen Hemminger
2023-12-11 14:07 ` [PATCH iproute2-next 11/20] bridge: vni: Reverse the logic in print_vnifilter_rtm() Benjamin Poirier
2023-12-11 14:07 ` [PATCH iproute2-next 12/20] bridge: vni: Remove stray newlines after each interface Benjamin Poirier
2023-12-11 14:07 ` [PATCH iproute2-next 13/20] bridge: vni: Replace open-coded instance of print_nl() Benjamin Poirier
2023-12-21 4:08 ` Stephen Hemminger
2023-12-11 14:07 ` [PATCH iproute2-next 14/20] bridge: vni: Remove unused argument in open_vni_port() Benjamin Poirier
2023-12-11 14:07 ` [PATCH iproute2-next 15/20] bridge: vni: Align output columns Benjamin Poirier
2023-12-11 14:07 ` [PATCH iproute2-next 16/20] bridge: vni: Indent statistics with 2 spaces Benjamin Poirier
2023-12-11 14:07 ` [PATCH iproute2-next 17/20] bridge: Deduplicate print_range() Benjamin Poirier
2023-12-11 14:07 ` [PATCH iproute2-next 18/20] json_print: Output to temporary buffer in print_range() only as needed Benjamin Poirier
2023-12-11 14:07 ` [PATCH iproute2-next 19/20] json_print: Rename print_range() argument Benjamin Poirier
2023-12-11 14:07 ` [PATCH iproute2-next 20/20] bridge: Provide rta_type() Benjamin Poirier
2023-12-21 4:10 ` [PATCH iproute2-next 00/20] bridge: vni: UI fixes Stephen Hemminger
2024-01-02 9:19 ` Petr Machata
2023-12-22 18:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231220195708.2f69e265@hermes.local \
--to=stephen@networkplumber.org \
--cc=bpoirier@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=petrm@nvidia.com \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.