All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Adam Duskett <adam.duskett@amarulasolutions.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 03/14] package/dmenu-wayland: new package
Date: Wed, 20 Dec 2023 23:07:05 +0100	[thread overview]
Message-ID: <20231220230705.0385be25@windsurf> (raw)
In-Reply-To: <20231218194001.544887-3-adam.duskett@amarulasolutions.com>

On Mon, 18 Dec 2023 12:39:48 -0700
Adam Duskett <adam.duskett@amarulasolutions.com> wrote:

> This package is an alternative to dmenu for X. Sway uses it by default as its
> menu bar.
> 
> Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com>
> ---
> v1 -> v2:
>   - ln -sf dmenu-wl $(TARGET_DIR)/usr/bin/dmenu (Thomas)
>   - v1 -> v2: Fix the sha256sum of LICENSE

I wanted to apply this, but unfortunately, it doesn't build:

Program /usr/bin/wayland-scanner found: NO

output/build/dmenu-wayland-a380201dff5bfac2dace553d7eaedb6cea6855f9/meson.build:30:22: ERROR: Program '/usr/bin/wayland-scanner' not found or not executable

I've quickly tried to find a way to feed the path to wayland-scanner,
but I haven't found. It's looking for it using pkg-config, but our
pkg-config doesn't return the path to our wayland-scanner.

Also, I did some adjustements in your patch:

1. Clean up the comments on the dependencies in the Config.in file, to
list only the first-order dependencies, but all of them

+       bool "dmenu-wayland"
+       depends on BR2_USE_MMU # pango, libglib2
+       depends on BR2_TOOLCHAIN_HAS_SYNC_4 # pango
+       depends on BR2_TOOLCHAIN_HAS_THREADS # pango, libglib2, wayland
+       depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # pango
+       depends on !BR2_STATIC_LIBS # wayland
+       depends on BR2_INSTALL_LIBSTDCPP # pango
+       depends on BR2_USE_WCHAR # pango, libglib2

2. Use the github macro

+DMENU_WAYLAND_VERSION = a380201dff5bfac2dace553d7eaedb6cea6855f9
+DMENU_WAYLAND_SITE = $(call github,nyyManni,dmenu-wayland,$(DMENU_WAYLAND_VERSION))

Could you fix (1) and (2) in your patch series, and address the
wayland-scanner issue?

This kind of issue can be detected prior to submitting a patch series
by doing a build in a clean container.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2023-12-20 22:07 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-18 19:39 [Buildroot] [PATCH v2 01/14] package/sway/Config.in: Remove duplicate dependencies Adam Duskett
2023-12-18 19:39 ` [Buildroot] [PATCH v2 02/14] package/sway/Config.in: select BR2_PACKAGE_XKEYBOARD_CONFIG Adam Duskett
2023-12-20 21:14   ` Thomas Petazzoni via buildroot
2024-01-07 17:34   ` Peter Korsgaard
2023-12-18 19:39 ` [Buildroot] [PATCH v2 03/14] package/dmenu-wayland: new package Adam Duskett
2023-12-20 22:07   ` Thomas Petazzoni via buildroot [this message]
2023-12-18 19:39 ` [Buildroot] [PATCH v2 04/14] package/tllist: " Adam Duskett
2023-12-20 22:11   ` Thomas Petazzoni via buildroot
2023-12-18 19:39 ` [Buildroot] [PATCH v2 05/14] package/fcft: " Adam Duskett
2023-12-20 22:22   ` Thomas Petazzoni via buildroot
2023-12-18 19:39 ` [Buildroot] [PATCH v2 06/14] package/libutempter: " Adam Duskett
2023-12-20 22:40   ` Thomas Petazzoni via buildroot
2023-12-18 19:39 ` [Buildroot] [PATCH v2 07/14] package/foot: " Adam Duskett
2023-12-18 19:39 ` [Buildroot] [PATCH v2 08/14] package/ncurses: install foot terminfo if foot is selected Adam Duskett
2023-12-18 19:39 ` [Buildroot] [PATCH v2 09/14] package/sway: enable bash-completion support Adam Duskett
2023-12-18 19:39 ` [Buildroot] [PATCH v2 10/14] package/sway: enable default-wallpaper support Adam Duskett
2023-12-18 19:39 ` [Buildroot] [PATCH v2 11/14] package/sway: enable swaybar support Adam Duskett
2023-12-18 19:39 ` [Buildroot] [PATCH v2 12/14] package/sway: enable swaybar tray support Adam Duskett
2023-12-18 19:39 ` [Buildroot] [PATCH v2 13/14] package/sway: enable swaynag support Adam Duskett
2023-12-18 19:39 ` [Buildroot] [PATCH v2 14/14] package/sway/Config.in: Add a help note about the default terminal Adam Duskett
2023-12-20 21:06 ` [Buildroot] [PATCH v2 01/14] package/sway/Config.in: Remove duplicate dependencies Thomas Petazzoni via buildroot
2024-01-07 17:34 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231220230705.0385be25@windsurf \
    --to=buildroot@buildroot.org \
    --cc=adam.duskett@amarulasolutions.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.