Re: [PATCH 2/2] PM: domains: Move genpd and its governor to the pmdomain subsystem

[kernel test robot <lkp@intel.com>]

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20231213113305.29098-1-ulf.hansson@linaro.org>
References: <20231213113305.29098-1-ulf.hansson@linaro.org>
TO: Ulf Hansson <ulf.hansson@linaro.org>

Hi Ulf,

kernel test robot noticed the following build warnings:

[auto build test WARNING on rafael-pm/linux-next]
[also build test WARNING on rafael-pm/acpi-bus linus/master v6.7-rc6]
[cannot apply to rafael-pm/devprop next-20231220]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Ulf-Hansson/PM-domains-Move-genpd-and-its-governor-to-the-pmdomain-subsystem/20231213-193436
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
patch link:    https://lore.kernel.org/r/20231213113305.29098-1-ulf.hansson%40linaro.org
patch subject: [PATCH 2/2] PM: domains: Move genpd and its governor to the pmdomain subsystem
:::::: branch date: 7 days ago
:::::: commit date: 7 days ago
config: powerpc64-randconfig-r071-20231220 (https://download.01.org/0day-ci/archive/20231221/202312210228.bcE94X2N-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project.git f28c006a5895fc0e329fe15fead81e37457cb1d1)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202312210228.bcE94X2N-lkp@intel.com/

smatch warnings:
drivers/pmdomain/core.c:427 genpd_dev_pm_set_performance_state() error: 'genpd' dereferencing possible ERR_PTR()
drivers/pmdomain/core.c:822 genpd_dev_pm_start() error: 'genpd' dereferencing possible ERR_PTR()

vim +/genpd +427 drivers/pmdomain/core.c

5937c3ce21228d drivers/base/power/domain.c Ulf Hansson 2021-06-03  420  
401e09201a0118 drivers/base/power/domain.c Ulf Hansson 2023-09-25  421  static int genpd_dev_pm_set_performance_state(struct device *dev,
401e09201a0118 drivers/base/power/domain.c Ulf Hansson 2023-09-25  422  					      unsigned int state)
401e09201a0118 drivers/base/power/domain.c Ulf Hansson 2023-09-25  423  {
401e09201a0118 drivers/base/power/domain.c Ulf Hansson 2023-09-25  424  	struct generic_pm_domain *genpd = dev_to_genpd(dev);
401e09201a0118 drivers/base/power/domain.c Ulf Hansson 2023-09-25  425  	int ret = 0;
401e09201a0118 drivers/base/power/domain.c Ulf Hansson 2023-09-25  426  
401e09201a0118 drivers/base/power/domain.c Ulf Hansson 2023-09-25 @427  	genpd_lock(genpd);
401e09201a0118 drivers/base/power/domain.c Ulf Hansson 2023-09-25  428  	if (pm_runtime_suspended(dev)) {
401e09201a0118 drivers/base/power/domain.c Ulf Hansson 2023-09-25  429  		dev_gpd_data(dev)->rpm_pstate = state;
401e09201a0118 drivers/base/power/domain.c Ulf Hansson 2023-09-25  430  	} else {
401e09201a0118 drivers/base/power/domain.c Ulf Hansson 2023-09-25  431  		ret = genpd_set_performance_state(dev, state);
401e09201a0118 drivers/base/power/domain.c Ulf Hansson 2023-09-25  432  		if (!ret)
401e09201a0118 drivers/base/power/domain.c Ulf Hansson 2023-09-25  433  			dev_gpd_data(dev)->rpm_pstate = 0;
401e09201a0118 drivers/base/power/domain.c Ulf Hansson 2023-09-25  434  	}
401e09201a0118 drivers/base/power/domain.c Ulf Hansson 2023-09-25  435  	genpd_unlock(genpd);
401e09201a0118 drivers/base/power/domain.c Ulf Hansson 2023-09-25  436  
401e09201a0118 drivers/base/power/domain.c Ulf Hansson 2023-09-25  437  	return ret;
401e09201a0118 drivers/base/power/domain.c Ulf Hansson 2023-09-25  438  }
401e09201a0118 drivers/base/power/domain.c Ulf Hansson 2023-09-25  439  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki