All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Adam Duskett <adam.duskett@amarulasolutions.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v3 02/10] package/dmenu-wayland: new package
Date: Thu, 21 Dec 2023 09:33:04 +0100	[thread overview]
Message-ID: <20231221093304.3b68da4b@windsurf> (raw)
In-Reply-To: <20231221001924.1356215-2-adam.duskett@amarulasolutions.com>

Hello,

Thanks for this new iteration.

On Wed, 20 Dec 2023 17:19:16 -0700
Adam Duskett <adam.duskett@amarulasolutions.com> wrote:

> diff --git a/package/dmenu-wayland/Config.in b/package/dmenu-wayland/Config.in
> new file mode 100644
> index 0000000000..111bbfb434
> --- /dev/null
> +++ b/package/dmenu-wayland/Config.in
> @@ -0,0 +1,26 @@
> +config BR2_PACKAGE_DMENU_WAYLAND
> +	bool "dmenu-wayland"
> +	depends on BR2_USE_MMU # pango -> lib2
> +	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # pango -> harfbuzz
> +	depends on BR2_TOOLCHAIN_HAS_THREADS # pango -> glib2, wayland
> +	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # pango -> harfbuz
> +	depends on !BR2_STATIC_LIBS # wayland -> dlfcn.h
> +	depends on BR2_INSTALL_LIBSTDCPP # pango -> freetype support
> +	depends on BR2_USE_WCHAR # pango -> glib2

You did not re-use the suggestions from my feedback.

> +DMENU_WAYLAND_VERSION = a380201dff5bfac2dace553d7eaedb6cea6855f9
> +DMENU_WAYLAND_SITE = https://github.com/nyyManni/dmenu-wayland.git

Ditto.

Please send new iterations less quickly, but with more
review/testing/validation.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2023-12-21  8:33 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-21  0:19 [Buildroot] [PATCH v3 01/10] package/wlroots: add hwdata and hwdata_pnp_ids as a dependency Adam Duskett
2023-12-21  0:19 ` [Buildroot] [PATCH v3 02/10] package/dmenu-wayland: new package Adam Duskett
2023-12-21  8:33   ` Thomas Petazzoni via buildroot [this message]
2023-12-21  0:19 ` [Buildroot] [PATCH v3 03/10] package/foot: " Adam Duskett
2023-12-21  0:19 ` [Buildroot] [PATCH v3 04/10] package/ncurses: install foot terminfo if foot is selected Adam Duskett
2023-12-21  0:19 ` [Buildroot] [PATCH v3 05/10] package/sway: enable bash-completion support Adam Duskett
2023-12-21  0:19 ` [Buildroot] [PATCH v3 06/10] package/sway: enable default-wallpaper support Adam Duskett
2023-12-21  8:35   ` Thomas Petazzoni via buildroot
2023-12-21 14:40     ` Adam Duskett
2023-12-21  0:19 ` [Buildroot] [PATCH v3 07/10] package/sway: enable swaybar support Adam Duskett
2023-12-21  0:19 ` [Buildroot] [PATCH v3 08/10] package/sway: enable swaybar tray support Adam Duskett
2023-12-21  0:19 ` [Buildroot] [PATCH v3 09/10] package/sway: enable swaynag support Adam Duskett
2023-12-21  0:19 ` [Buildroot] [PATCH v3 10/10] package/sway/Config.in: Add a help note about the default terminal Adam Duskett
2023-12-21  8:31 ` [Buildroot] [PATCH v3 01/10] package/wlroots: add hwdata and hwdata_pnp_ids as a dependency Thomas Petazzoni via buildroot
2023-12-21 14:43   ` Adam Duskett
2023-12-22  8:19     ` Thomas Petazzoni via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231221093304.3b68da4b@windsurf \
    --to=buildroot@buildroot.org \
    --cc=adam.duskett@amarulasolutions.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.