From: Thomas Huth <huth@tuxfamily.org>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH v2 10/11] next-cube.c: remove val and size arguments from nextscr2_write()
Date: Thu, 21 Dec 2023 09:35:15 +0100 [thread overview]
Message-ID: <20231221093515.3e29f7b5@fedora> (raw)
In-Reply-To: <20231220131641.592826-11-mark.cave-ayland@ilande.co.uk>
Am Wed, 20 Dec 2023 13:16:40 +0000
schrieb Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>:
> These are now redundant with the scr2 and old_scr2 fields in NeXTPC. Rename
> the function from nextscr2_write() to next_scr2_rtc_update() to better
> reflect its purpose. At the same time replace the manual bit manipulation with
> the extract32() and deposit32() functions.
>
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> ---
> hw/m68k/next-cube.c | 17 ++++++-----------
> 1 file changed, 6 insertions(+), 11 deletions(-)
Reviewed-by: Thomas Huth <huth@tuxfamily.org>
next prev parent reply other threads:[~2023-12-21 8:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-20 13:16 [PATCH v2 00/11] next-cube: various tidy-ups and improvements Mark Cave-Ayland
2023-12-20 13:16 ` [PATCH v2 01/11] next-cube.c: add dummy Ethernet register to allow diagnostic to timeout Mark Cave-Ayland
2023-12-20 13:16 ` [PATCH v2 02/11] next-cube.c: don't pulse SCSI DMA IRQ upon reception of FLUSH command Mark Cave-Ayland
2023-12-20 13:16 ` [PATCH v2 03/11] next-cube.c: update mmio_ops to properly use modern memory API Mark Cave-Ayland
2023-12-20 13:16 ` [PATCH v2 04/11] next-cube.c: update scr_ops " Mark Cave-Ayland
2023-12-20 13:16 ` [PATCH v2 05/11] next-cube.c: update and improve dma_ops Mark Cave-Ayland
2023-12-20 13:16 ` [PATCH v2 06/11] next-cube.c: move static led variable to NeXTPC Mark Cave-Ayland
2023-12-20 13:16 ` [PATCH v2 07/11] next-cube.c: move static phase variable to NextRtc Mark Cave-Ayland
2023-12-20 13:16 ` [PATCH v2 08/11] next-cube.c: move static old_scr2 variable to NeXTPC Mark Cave-Ayland
2023-12-20 19:20 ` Thomas Huth
2023-12-20 19:36 ` Mark Cave-Ayland
2023-12-21 8:33 ` Thomas Huth
2023-12-20 13:16 ` [PATCH v2 09/11] next-cube.c: move LED logic to new next_scr2_led_update() function Mark Cave-Ayland
2023-12-21 8:34 ` Thomas Huth
2023-12-20 13:16 ` [PATCH v2 10/11] next-cube.c: remove val and size arguments from nextscr2_write() Mark Cave-Ayland
2023-12-21 8:35 ` Thomas Huth [this message]
2023-12-20 13:16 ` [PATCH v2 11/11] next-cube.c: move machine MemoryRegions into NeXTState Mark Cave-Ayland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231221093515.3e29f7b5@fedora \
--to=huth@tuxfamily.org \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.