From: SeongJae Park <sj@kernel.org>
To: Tanzir Hasan <tanzirh@google.com>
Cc: SeongJae Park <sj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
damon@lists.linux.dev, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Nick Desaulniers <nnn@google.com>,
Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH] mm/damon/vaddr: changed asm-generic/mman-common.h to linux/mman.h
Date: Thu, 21 Dec 2023 23:49:47 +0000 [thread overview]
Message-ID: <20231221234947.59458-1-sj@kernel.org> (raw)
In-Reply-To: <20231221-asmgenericvaddr-v1-1-742b170c914e@google.com>
Hi Tanzir,
On Thu, 21 Dec 2023 23:11:01 +0000 Tanzir Hasan <tanzirh@google.com> wrote:
> asm-generic/mman-common.h can be replaced by linux/mman.h and the file
> will still build correctly. It is an asm-generic file which should be
> avoided if possible.
>
> Suggested-by: Al Viro <viro@zeniv.linux.org.uk>
> Signed-off-by: Tanzir Hasan <tanzirh@google.com>
Thank you for this patch :)
Maybe we could add below Fixes: line? I guess stable@ is intentionally not
added and that makes sense, but please let me know if you think differently.
Fixes: 6dea8add4d28 ("mm/damon/vaddr: support DAMON-based Operation Schemes")
Other than that, looks good to me.
Reviewed-by: SeongJae Park <sj@kernel.org>
Thanks,
SJ
[...]
next prev parent reply other threads:[~2023-12-21 23:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-21 23:11 [PATCH] mm/damon/vaddr: changed asm-generic/mman-common.h to linux/mman.h Tanzir Hasan
2023-12-21 23:49 ` SeongJae Park [this message]
2023-12-22 0:29 ` Tanzir Hasan
2023-12-22 0:34 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231221234947.59458-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nnn@google.com \
--cc=tanzirh@google.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.